exception in uploading the file

[ashwini hikulkarni]

I am getting the exception while uploading
please help me in fixing this exception


HTTP Status 500 -

--------------------------------------------------------------------------------

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException
org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:286)
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:462)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
javax.servlet.http.HttpServlet.service(HttpServlet.java:810)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:81)


root cause

java.lang.NullPointerException
com.MyPack.Datamatics.UploadAction.execute(UploadAction.java:27)
org.apache.struts.chain.commands.servlet.ExecuteAction.execute(ExecuteAction.java:58)
org.apache.struts.chain.commands.AbstractExecuteAction.execute(AbstractExecuteAction.java:67)
org.apache.struts.chain.commands.ActionCommandBase.execute(ActionCommandBase.java:51)
org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
org.apache.commons.chain.generic.LookupCommand.execute(LookupCommand.java:304)
org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:283)
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:462)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
javax.servlet.http.HttpServlet.service(HttpServlet.java:810)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:81)


note The full stack trace of the root cause is available in the Apache Tomcat/5.5 logs.


--------------------------------------------------------------------------------

Apache Tomcat/5.5

   package com.MyPack.Datamatics;
 
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.ServletException; 
 
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
 
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.upload.FormFile;
import java.io.*;
 
public class UploadAction extends Action
{
 public ActionForward execute(ActionMapping am,
 ActionForm form,
 HttpServletRequest req,
 HttpServletResponse res)throws IOException, ServletException
  {
 
UploadForm uploadForm = (UploadForm)form;
 
        // Process the FormFile
        FormFile myFile = uploadForm.getThefile();
        String contentType = myFile.getContentType();
    //Get the file name
        String fileName    = myFile.getFileName();
        //int fileSize       = myFile.getFileSize();
        byte[] fileData    = myFile.getFileData();
    //Get the servers upload directory real path name
    String filePath = getServlet().getServletContext().getRealPath("E:/store") ;
    /* Save file on the server */
    if(!fileName.equals("")){  
        System.out.println("Server path:" +filePath);
        //Create file
        File fileToCreate = new File(filePath, fileName);
        //If file does not exists create file                      
        if(!fileToCreate.exists()){
          FileOutputStream fileOutStream = new FileOutputStream(fileToCreate);
          fileOutStream.write(myFile.getFileData());
          fileOutStream.flush();
          fileOutStream.close();
        }  
 

    }
    //Set file name to the request object
    req.setAttribute("fileName",fileName);
      
        return am.findForward("success");
  }
}   

[John Robert]

from what you posted i only can think for some reason your form is giving null, did you try to find out if anything in the form is null?

[ashwini hikulkarni]

Ok i will post the source code

[Bear Bibeault]

"nash",

There aren't many rules that you need to worry about here on the Ranch, but one that we take very seriously regards the use of proper names. Please take a look at the JavaRanch Naming Policy and adjust your display name to match it.

In particular, your display name must be a first and a last name separated by a space character, and must not be obviously fictitious.

Thanks!
bear
JavaRanch Sheriff

[ashwini hikulkarni]

My task is to upload the file using struts


1>LoginAction.java
2>LoginForm.java
3>UploadForm.java
4>UploadAction.java
5>struts-config.xml
6>web.xml
7>upload.jsp
8>login.jsp

1>login.jsp

    <%@ page language="java"%>
 
<%@ page import="java.io.*"%>
 
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
 
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
 
 
 
<html>
 
<center><IMG SRC="E:\jboss-4.0.3SP1\server\default\deploy\TestApplication.war\image\welcome.jpg" HEIGHT=233 WIDTH=282 ALT="WELCOME TO DATAMATICS"></center>
 
 
 
<center><h1 style="color:blue"><hr>WELCOME TO DATAMATICS</hr></h1></center>
 
<h2 style="color:green">LOGIN FORM</h2>
 
 
 
<center>
 
<body>
 
            <form name="loginForm" type="com.MyPack.Datamatics.LoginForm" method="POST" action="login.do" >
 
            <table width="20%" border="0">
 
            <td>
 
                        <tr><h4 style="color:red">USER ID:<h4></tr>
 
                        <tr><input type="text"  name="username" value="" size="30"/></tr>
 
            <hr>
 
            </td>
 
            <td>
 
                        <tr><h4 style="color:red">PASSWORD:</h4></tr>
 
                        <tr><input type="password"  name="password" value="" size="30" /></tr>
 
            <hr>     
 
                        <tr><input type="submit" value="SUBMIT" ></tr><hr>
 
                        <tr><input type="reset" value="reset"></tr>
 
                        <tr></tr>
 
            </td>
 
</table>
 
</body>
 
            </form>
 
</center>
 
 
 
</html>
 

2>upload.jsp

  <%@ page language="java"%>
 
<%@ page import="java.io.*"%>
 
 
 
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html"%>
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean"%>
 
 
<html>
 
 <center><IMG SRC="E:\jboss-4.0.3SP1\server\default\deploy\TestApplication.war\image\welcome.jpg" HEIGHT=233 WIDTH=282 ALT="WELCOME TO DATAMATICS"></center>
 
 
 
<center><h1 style="color:blue"><hr>WELCOME TO DATAMATICS</hr></h1></center>
 
<h2 style="color:green">UPLOAD FILE</h2>
 
<h4 style="color :-P	 ink">Welcome <%= request.getAttribute("UserName") %> </h4>
<center>
 

<body bgcolor="white">
 
<form name="uploadForm" action="upload.do" method="post" enctype="multipart/form-data">
 
<table>
 
<tr>
 
<td align="center" colspan="2">
 
<font size="4">Please browse the file to UPLOAD</font>
 
</tr>
 
 
 
<tr>
 
<td align="left" colspan="2">
 
<font color="red"></font>
 

 
</tr>
 
 
 
 
 
 
 
<tr>
 
<td align="right">
 
File Name
 
</td>
 
<td align="left">
 
<input type="file"  name="theFile"> 
 
</td>
 
</tr>
 
 
 
 
 
<tr>
 
<td align="center" colspan="2">
 
<input type="submit" value="UPLOAD">
 
</td>
 
</tr>
 
</table>
 
 
</form>
 
</body>
 
</html>
 
  

3>LoginAction.java

    <%@ page language="java"%>
 
<%@ page import="java.io.*"%>
 
 
 
<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html"%>
<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean"%>
 
 
<html>
 
 <center><IMG SRC="E:\jboss-4.0.3SP1\server\default\deploy\TestApplication.war\image\welcome.jpg" HEIGHT=233 WIDTH=282 ALT="WELCOME TO DATAMATICS"></center>
 
 
 
<center><h1 style="color:blue"><hr>WELCOME TO DATAMATICS</hr></h1></center>
 
<h2 style="color:green">UPLOAD FILE</h2>
 
<h4 style="color :-P	 ink">Welcome <%= request.getAttribute("UserName") %> </h4>
<center>
 

<body bgcolor="white">
 
<form name="uploadForm" action="upload.do" method="post" enctype="multipart/form-data">
 
<table>
 
<tr>
 
<td align="center" colspan="2">
 
<font size="4">Please browse the file to UPLOAD</font>
 
</tr>
 
 
 
<tr>
 
<td align="left" colspan="2">
 
<font color="red"></font>
 

 
</tr>
 
 
 
 
 
 
 
<tr>
 
<td align="right">
 
File Name
 
</td>
 
<td align="left">
 
<input type="file"  name="theFile"> 
 
</td>
 
</tr>
 
 
 
 
 
<tr>
 
<td align="center" colspan="2">
 
<input type="submit" value="UPLOAD">
 
</td>
 
</tr>
 
</table>
 
 
</form>
 
</body>
 
</html>
 

5>LoginForm.java

  package com.MyPack.Datamatics;
//import com.MyPack.Datamatics.LoginAction;
import javax.servlet.http.*;
 
//import org.apache.struts.action.Action.*;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionErrors;
import org.apache.struts.action.ActionMessage;
//import org.apache.struts.action.ActionError.*;
//import java.util.*;
//import java.io.*;
 
public class LoginForm extends ActionForm
{
/**
 * 
 */
private static final long serialVersionUID = 1L;
private String username=null;
private String password=null;

public void setUsername(String username)
{
this.username=username;
}
public String getUsername()
{
return username;
}
public void setPassword(String password)
{
this.password=password;
}
public String getPassword()
{
return password;
}

public void reset(ActionMapping am,HttpServletRequest req)
{
this.username="";
this.password="";
}
public ActionErrors validate(ActionMapping am, HttpServletRequest req)
{
ActionErrors ae = new ActionErrors();
if ( (username==null) || (username.length()==0))
{
ae.add("username" , new ActionMessage("errors.username.required") );
}
if( (password==null) || (password.length()==0))
{
ae.add("password" , new ActionMessage("errors.password.required") );
}

return ae;
}
}
 
  

6>UploadAction.java

  package com.MyPack.Datamatics;
 
import javax.servlet.http.*;
import java.io.*;
import javax.servlet.ServletException; 
 
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.ServletException;
 
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.upload.FormFile;
import java.io.*;
 
public class UploadAction extends Action
{
 public ActionForward execute(ActionMapping am,
 ActionForm form,
 HttpServletRequest req,
 HttpServletResponse res)throws IOException, ServletException
  {
 
UploadForm uploadForm = (UploadForm)form;
 
        // Process the FormFile
        FormFile myFile = uploadForm.getThefile();
        String contentType = myFile.getContentType();
    //Get the file name
        String fileName    = myFile.getFileName();
        //int fileSize       = myFile.getFileSize();
        byte[] fileData    = myFile.getFileData();
    //Get the servers upload directory real path name
    String filePath = getServlet().getServletContext().getRealPath("E:/store") ;
    /* Save file on the server */
    if(!fileName.equals("")){  
        System.out.println("Server path:" +filePath);
        //Create file
        File fileToCreate = new File(filePath, fileName);
        //If file does not exists create file                      
        if(!fileToCreate.exists()){
          FileOutputStream fileOutStream = new FileOutputStream(fileToCreate);
          fileOutStream.write(myFile.getFileData());
          fileOutStream.flush();
          fileOutStream.close();
        }  
 

    }
    //Set file name to the request object
    req.setAttribute("fileName",fileName);
      
        return am.findForward("success");
  }
}    

7>struts-config.xml

  <?xml version="1.0" encoding="ISO-8859-1" ?>
<!DOCTYPE struts-config PUBLIC
          "-//Apache Software Foundation//DTD Struts Configuration 1.1//EN"
          "http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd">
<struts-config>
            <form-beans>
                        <form-bean name="loginForm" type="com.MyPack.Datamatics.LoginForm"  />
                        <form-bean name="uploadForm" type="com.MyPack.Datamatics.UploadForm" />
            </form-beans>
 
            <global-forwards>
 
                        <forward name="success" path="/index.jsp"/>
 
            </global-forwards>
 
            <action-mappings>
 
                        <action path="/login"
 
                                                type="com.MyPack.Datamatics.LoginAction"
 
                                                name="loginForm"
 
                                                scope="request"
 
                                                input="login.jsp">
 
                                    <forward name="success" path="/upload.jsp" />
 
                                    <forward name="failure" path="/index.jsp" />
 
                        </action>
 
                        <action path="/upload"
 
                                                type="com.MyPack.Datamatics.UploadAction"
 
                                                name="uploadForm"
 
                                                scope="request"
 
                                                input="upload.jsp">
 
                                    <forward name="success" path="/successUpload.jsp" />
 
                                    <forward name="failure" path="/index.jsp" />
 
                        </action>
 
            </action-mappings>
 
 
 
</struts-config>
 
  

8>web.xml

  <?xml version="1.0" encoding="ISO-8859-1"?>
 
<!DOCTYPE web-app PUBLIC "-//Sun Microsystems, Inc.//DTD Web
Application 2.3//EN" "http://java.sun.com/dtd/web-app_2_3.dtd">
<web-app>
 

    <servlet>
<servlet-name>action</servlet-name>
<servlet-class>org.apache.struts.action.ActionServlet</servlet-class>
<init-param>
<param-name>config</param-name>
<param-value>/WEB-INF/struts-config.xml</param-value>
</init-param> 
<load-on-startup>1</load-on-startup>
</servlet>

<servlet-mapping>
<servlet-name>action</servlet-name>
<url-pattern>*.do</url-pattern>
</servlet-mapping>
 

<taglib>
<taglib-uri>/WEB-INF/struts-html.tld</taglib-uri>
<taglib-location>/WEB-INF/struts-html.tld</taglib-location>
</taglib>
 
<taglib>
<taglib-uri>/WEB-INF/struts-bean.tld</taglib-uri>
<taglib-location>/WEB-INF/struts-bean.tld</taglib-location>
</taglib>
 
<taglib>
<taglib-uri>/WEB-INF/struts-tiles.tld</taglib-uri>
<taglib-location>/WEB-INF/struts-tiles.tld</taglib-location>
</taglib>
</web-app>  

Kindly help me in fixing the error mentioned in the above post
regards