button to new activity

[Amir Rahav]

i have my main activity, wich has fe buttons, one of them - COLOR, will open a new list view activity with a list of colors.
so i have both of the xml, and both of the java pages. i put in the main acticity a listener for that button and made a new intent and gave the start activity command. but when i run it on the emulator it crashes when ipress COLOR button.

this is in my main activity:

public class can2actv extends Activity implements OnClickListener{

   @Override
   public void onCreate(Bundle savedInstanceState) {
      super.onCreate(savedInstanceState);
      setContentView(R.layout.activity_can2actv);
      Button colorbtn= (Button)findViewById(R.id.colorsbtn);
      colorbtn.setOnClickListener(new OnClickListener() {
         @Override
         public void onClick(View v) {
             // TODO Auto-generated method stub
             Intent intent=new Intent(null, selecColor.class);
             startActivity(intent);
        }
      });
   }

what am i doing wrong?

[Amir Rahav]

and that is the second activity - the color selec page:

public class selecColor extends ListActivity {
   public void onCreate(Bundle icicle) {
      super.onCreate(icicle);
      ListView listview=(ListView)findViewById(R.id.colorlist);
      String[] values={"Red","Green","Blue"};
      setContentView(R.layout.colorlist);
      setListAdapter(new ArrayAdapter<String>(this,
         android.R.layout.simple_list_item_1,values));
      ArrayAdapter<String>adapter=
         new ArrayAdapter<String>(this,
            android.R.layout.simple_list_item_1,android.R.id.text1, values);
      listview.setAdapter(adapter);
      listview.setOnItemClickListener(new OnItemClickListener() {
         @Override
         public void onItemClick(
                AdapterView<?> parent, View View, int position, long id) {
                   // TODO Auto-generated method stub
                   Toast.makeText(getBaseContext(),
                         "Clickk List Item"+position, Toast.LENGTH_LONG)
                  .show();
        }
    });
  }
}

[Campbell Ritchie]

Welcome to the Ranch

Please indent your code correctly, and don’t double‑space it. I shall try to edit your code and you can see how much better it looks.
We can only help you if you give us more details. When does your application crash? Do you get a stack trace or error message? What does it say? Copy the exact text.

[Campbell Ritchie]

Is .show() really supposed to be on a line by itself? Is it the Component#show() method? You realise that has been deprecated?

[Darryl Burke]

That's Android code, not Swing. Moving the thread.

[Nick Johnson]

Please elaborate more, so that we can understand the problem easily.......

[Naishadh Parmar]

Have you written about the second activity in the manifest file.
Many people don't write in the manifest file, and when the activity does not start they scratch their head.

You have to write under the <application> tag

<activity android:name=".ListViewActivity"
             android:label="@string/app_name">
</activity>