Object Equality Google gwava and Apache Commons

Hello Guys

Trying to understand the results I am getting from object equality ...
Ok first let me describe the problem..

The is multiple i need to filter duplicates objects from two two tables from db (Hibenate all of the cluses are set up) preset condition is firstName, lastName, dateOfbirth. Not shure about best practices I have created an Class to hold a equality object

package com.equality.types;

import com.google.common.base.Objects;

import java.util.Date;

public class AsignoreTypes{
    private String firstname;
    private String lastname;
    private Date doa;

public String getFirstname() {
        return firstname;
    }

public void setFirstname(String firstname) {
        this.firstname = firstname;
    }

public String getLastname() {
        return lastname;
    }

public void setLastname(String lastname) {
        this.lastname = lastname;
    }

public Date getDoa() {
        return doa;
    }

public void setDoa(Date doa) {
        this.doa = doa;
    }

/*   @Override
    public boolean equals(Object obj) {
        if (obj instanceof AsignoreTypes == false) {
            return false;
        }

if (this == obj) {
            return true;
        }
        AsignoreTypes other = (AsignoreTypes) obj;
        return new EqualsBuilder().append(this.firstname , other.firstname)
                .append(this.lastname, other.lastname)
                .append(this.doa , other.doa).isEquals();
    }

@Override
    public int hashCode() {
        return new HashCodeBuilder().append(this.firstname)
                .append(this.lastname)
                .append(this.doa)
                .hashCode();
    }
     */
    @Override
    public int hashCode(){
        return Objects.hashCode(firstname, lastname, doa);
    }

@Override
    public boolean equals(final Object obj){
        if(obj instanceof AsignoreTypes){
            final AsignoreTypes other = (AsignoreTypes) obj;
               return Objects.equal(firstname, other.firstname)
                    &&Objects.equal(lastname, other.lastname)
                    && Objects.equal(doa, other.doa);
        } else{
            return false;
        }
    }
}

So in my service class I call Query on 2 tables and create custom list Iterate over list and objects

Session session = service.getDataServiceManager().getSession();
           SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd");
       Query query = session.createQuery("select upper(ass.firstName), upper(ass.lastName), ass.doa from AssignorInfo ass");
       List<Object> ass1 = null;
           ass1 =  query.list();
       List<AsignoreTypes> res1 = null;
       res1 = new ArrayList<AsignoreTypes>();
       Iterator<Object> it = ass1.iterator();
           while (it.hasNext()){
               Object[] row = (Object[])it.next();
               AsignoreTypes ass = new AsignoreTypes();
               if(row[0]!=null) ass.setFirstname(row[0].toString());
               if(row[1]!=null) ass.setLastname(row[1].toString());
               if(row[2]!=null) ass.setDoa(formatter.parse(row[2].toString()));
               res1.add(ass);
           }
           log(INFO, "List one size "+res1.size());
       Query q = session.createQuery("select upper(g.fname), upper(g.lname), g.doa from  GeneralInfo g where g.arbitrator like '%Bulel%' ");
       List<Object> ass2 = null;
           ass2 = q.list();
       log(INFO," Size from wizard "+ass2.size());
       List<AsignoreTypes> res2 = null;
       res2 = new ArrayList<AsignoreTypes>();
       Iterator<Object> iterator = ass2.iterator();
       // Set<AsignoreTypes> has = new HashSet<AsignoreTypes>();
       while ( iterator.hasNext() ){
           Boolean f = null;
           Object[] row = (Object[])iterator.next();
           AsignoreTypes ass = new AsignoreTypes();
           if(row[0]!=null) ass.setFirstname(row[0].toString());
           if(row[1]!=null) ass.setLastname(row[1].toString());
           if(row[2]!=null) ass.setDoa(formatter.parse(row[2].toString()));
           for (AsignoreTypes a1 : res1) {

f = ass.equals(a1);
               }
               if(f==false){
               res2.add(ass);
               //has.add(ass);
               log(INFO, "Got matchig element "+ass.getLastname());
           }
           //boolean m = compareToAssignor(ass, res1);
           //log(INFO, "Got Matching Assignor " + ass.getLastname());
           //Boolean res1 = compareToAssignor(a, ass2)
       }
       log(INFO, "List tow size "+res2.size()+" List hash set size ");
           HashSet<AsignoreTypes> asigors = new HashSet<AsignoreTypes>();
           HashSet<AsignoreTypes> wiz = new HashSet<AsignoreTypes>();
           asigors.addAll(res1);
           wiz.addAll(res2);
           wiz.removeAll(asigors);

log(INFO, "Added to hash set " + asigors.size());

log(INFO, "Added assignors to the list " + wiz.size());

So as you can see I have implemented a an equality and wiz.addAll on the list here is the funny result

2012-09-01 18:49:09,198 INFO [com.equality.service.CopareToServices] - < Size from wizard 392> (thread 1008 invoke CopareToServices.compareObjects)

After itteration >>>>

2012-09-01 18:49:09,910 INFO [com.equality.service.CopareToServices] - <List tow size 391 List hash set size > (thread 1008 invoke CopareToServices.compareObjects)
Equality method only found a single duplicate record >>>

And this is after Implementing removeAll on the heshSet
2012-09-01 18:49:09,918 INFO [com.equality.service.CopareToServices] - <Added assignors to the list 216> (thread 1008 invoke CopareToServices.compareObjects)

171 Duplicates were removed which sound about right...

I have tried with Apache commons and guava equality implementation ... for equality

Why native removeAll on the list removes duplicates but the equality does not return true ???

Will appreciate any help I can get on this

Just found out That ound out that loop with in the loop it's like testing against the last element ...

What would be the proper way to itterate over two lists and perform equality check of an element agains other list ..

Sincerely,

If your requirement is just to have a a collection of distinct objects and not to perform any deletion to the tables, you may consider just adding all the elements from both the tables into a Set. By definition of Set, it will not have any duplicates and even if there are duplicates as you are overriding the equals method, there will be only one instance of the object.

Thank you for you response Harsha Ka
Yes I did that while testing ..

But I need to preform an operation on the duplicate objects ...

In that case, you might try to add the elements of first table to one HashSet and then loop over the second table and call HashSet.contains() to check if the set already contains the element.