Storing a text file into a 3d Array

[Johnny Peterson]

Hi all,

I have the following task : I am supposed to create a maze from a text file, the maze can be multiple levels. A # is a wall, a . is a space, a @ is start, a * is an exit, and a ^ signifies a stair, which leads to a different level of the maze. I am supposed to determine the dimensions of the maze and store them into an array, as well as populate the array with the character at the given location. I am having trouble with the last part, and I would appreciate any help. Here is what I have so far :

import java.io.*;
import java.util.Scanner;
import javax.swing.*; 





public class Maze
{

	public static void main (String args[] ) throws IOException
	
	{
	
	
	 JFileChooser select = new JFileChooser();
     if (select.showOpenDialog(null)== JFileChooser.APPROVE_OPTION)
       {

			File file = select.getSelectedFile();
			Scanner scan = new Scanner(file);

			String x = scan.nextLine();
			final int width = x.length();
			int lines = 1;
			int depth = 0;
			
			
			
				
			
		while (scan.hasNextLine()) 
			{
				String line = scan.nextLine();
				lines++;
				
				if (line.charAt(0) == '-')
				    depth++;
					 
					 
				
					 
					 					 
					 
			}

				final int height = lines;
				
				
				
				
				
				char [][][] dimensions = new char [height][width][depth];
				
				
				
				
				
				for (int i = 1; i < dimensions.length; i ++)
				{
					for (int j = 0; j < dimensions[width].length; j++)
					{
					  					 
					  dimensions [height][width] = dimensions [i][j];
					  System.out.println (dimensions [i][j]);
					  
					}
					
				}
				
				
				
				
				
}

	  else 
		{
        System.out.println("No file selected");
      }
  
new Maze();

	
	 
	 
	 	
	  	 
	
	}
	
	
	 
	 public enum Success
	 {
	  		Walls("#"),
	  		Open ("."),
	  		Start ("@"),
	  		Stair("^"),
	  		Finish ("*");
	  
	  protected String ch;
	  
	  Success(String ch)
	  {
	  		this.ch = ch;
	  }
	  
	  public String toString()
	  {
	  		return ch;
	  }
	  
	  public static Success fromChar (char ch)
	  {
	   if (ch == '#')
		 return Walls;
		 
		else if (ch == '.')
		 return Open;
		 
		else if (ch == '@')
		 return Start;
		 
		else if (ch == '^')
		 return Stair;
		 
		else if (ch == '*') 
		 return Finish;
		 
	   else 
			throw new IllegalArgumentException();
	  }
	  
	 }
	 
	 
	 
	 
	 
	 
}

Here is what I get when I compile :

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 9
at Maze.main(Maze.java:65)

So my problem lies in the for loop, but I am unsure why it is giving me that error. I checked the height, width, and depth numbers, and they all are correct. Any hints or tips will be appreciated, I seem to be stuck on this. Also, here is the text file I am using :

#######
#...#@#
#^#...#
#######
-------
#######
#...###
#^#.*##
#######

Thanks in advance!

[John Jai]

Welcome to Javaranch, Johnny.

Yes the issue in the for loop. Note that array indices start from [0] to [array's length - 1]. So the char [height][width][depth] array can hold char[0][0][0] to char [height-1][width-1][depth-1] items (since index starts from 0).

Since you are not looping from 0 to length - 1, but directly try to assign to array's length, dimensions[height][width] you receive the ArrayIndexOutOfBoundsException.

I shall move the thread to Beginning Java forum.

[Johnny Peterson]

John Jai wrote:Welcome to Javaranch, Johnny.

Yes the issue in the for loop. Note that array indices start from [0] to [array's length - 1]. So the char [height][width][depth] array can hold char[0][0][0] to char [height-1][width-1][depth-1] items (since index starts from 0).

Since you are not looping from 0 to length - 1, but directly try to assign to array's length, dimensions[height][width] you receive the ArrayIndexOutOfBoundsException.

I shall move the thread to Beginning Java forum.

Thanks for the help, but when I do the following :

for (int i = 0; i < dimensions.length - 1; i ++)
				{
					for (int j = 1; j < dimensions[width].length - 1; j++)
					{
					  				 
					  dimensions [height][width] = dimensions [i][j];
					 System.out.println (dimensions [i][j]);
					  
					}
					
				}

I still get the same error, which confuses me.

[fred rosenberger]

System.out.println() is your best friend. I would stick some in just before line 65, so you have something like this:

System.out.println("Height is " + height);
System.out.println("Width is " + width);
System.out.println("i is " + i);
System.out.println("j is " + j);
dimensions [height][width] = dimensions [i][j];

i suppose you could print height and width before entering the loop on line 60, which would reduce the noise a little.

[Johnny Peterson]

fred rosenberger wrote:System.out.println() is your best friend. I would stick some in just before line 65, so you have something like this:

System.out.println("Height is " + height);
System.out.println("Width is " + width);
System.out.println("i is " + i);
System.out.println("j is " + j);
dimensions [height][width] = dimensions [i][j];

i suppose you could print height and width before entering the loop on line 60, which would reduce the noise a little.

Yes, that was a good tip of you. I got the height and the width right, but after it shows that i is 0 and j is 1, it displays the same error, which is weird, it does not store anything into the dimensions array. I think that maybe I am not saving the characters in the file correctly?

[John Jai]

Issue is here - dimensions[height][width] - As arrays have the index from 0 to length -1. Since you have declared dimensions[height]... you can use only from dimensions[0] till dimensions[height-1]. Read further in the array tutorials