How to avoid IndexOutOfBounds exception in this situation

[Jozo Stan]

Hello everyone!


I have a database table with sport matches. In my application users can choose which matches they want to follow by clicking on add in a data-tables table. I fetch matches from database with this method:

public List<Utakmica> fetchSveUtakmiceList(Date termin) {
	return getHibernateTemplate().find("FROM Utakmica WHERE DATE(termin) >= DATE(CURRENT_DATE)");

With that method I achieve that only new matches are shown to the user. Finished matches remain in database. For example, if there are 10 matches. 4 are finished. Number of matches is still 10 but I fetch in my list only 6. When user wants to add a match with ID >=6, application crashes and the java.lang.IndexOutOfBoundsException appears. If I remove the WHERE part of query, then I don't receive this exception.


Here is my code:

Controller index.java

@Controller
public class Index {

	@ModelAttribute("listaUtakmica")
	public List<Utakmica> getListaUtakmica() {
		return new ArrayList<Utakmica>();
	}
	
	
	@ModelAttribute("listaOdabranihUtakmica") //choosen matches
	public List<Utakmica> getListaOdabranihUtakmica() {
		return new ArrayList<Utakmica>();
	}
	
	
	@Autowired
	private SportService sportService;
	private String username;
	private Integer userID;
	private Date termin;

	

	@RequestMapping(value="/index.html", method=RequestMethod.GET)
	public String dohvatiUtakmicu(Model model, Principal principal) {
		
		
		
		List<Utakmica> listaOdabranihUtakmica=new ArrayList<Utakmica>(); 
		username = principal.getName();

		userID = sportService.getUserID(username);
		model.addAttribute("korisnik",username);

		List<Utakmica> tmpLista=new ArrayList<Utakmica>();
		tmpLista= sportService.fetchSveUtakmiceList(termin);
		model.addAttribute("listaUtakmica", tmpLista);


		List<OdabraneUtakmice> bazaLista=new ArrayList<>();
		bazaLista= sportService.fetchSveOdabraneUtakmice(userID);
		
		for(OdabraneUtakmice odabraneUtakmice: bazaLista){
			for(Utakmica utakmica: tmpLista){
				if((odabraneUtakmice.getUtakmica().getUtakmica_id() == utakmica.getUtakmica_id())){
					listaOdabranihUtakmica.add(utakmica);
				}
			}
		}




		model.addAttribute("listaOdabranihUtakmica",listaOdabranihUtakmica);
		return "index";
	}


	@RequestMapping(value="/index.html", method=RequestMethod.POST)
	public String izbor(Model model,@ModelAttribute("listaOdabranihUtakmica") List<Utakmica> listaOdabranihUtakmica,
			@ModelAttribute("listaUtakmica") List<Utakmica> tmpLista,@RequestParam("idOdabirUtakmice") String idOdabraneUtakmiceString) { //idOdabirUtakmice = id of the choosen match

		
		
		Long idOdabraneUtakmice=Long.parseLong(idOdabraneUtakmiceString);

		if (listaOdabranihUtakmica.contains(tmpLista.get((int) (idOdabraneUtakmice-1)))){
				
				
			listaOdabranihUtakmica.remove(tmpLista.get((int) (idOdabraneUtakmice-1)));
		} else {
			listaOdabranihUtakmica.add(tmpLista.get((int) (idOdabraneUtakmice-1)));
		}
		
		
		
		model.addAttribute("listaOdabranihUtakmica",listaOdabranihUtakmica);


		return "index";
	}

How could I solve this exception?

Thanks.
Jozo

[Bill Gorder]

I would step through your code in a debugger. You are removing and adding to lists by index. Clearly the size of the lists your are getting back are not what you are expecting. There is an error in your logic.