Spring commons-validator issue IlleagalArgumentException

[murali kankanala]

Hi I am trying to use commons-validator framework for validation in Spring MVC. i am getting following exception.

java.lang.IllegalArgumentException: Validator [org.springmodules.commons.validator.DefaultBeanValidator@1d5b945] does not support command class [com.training.springmvc.Details]


I have attached code in zip file. Could you please help me to resolve the issue.

[murali kankanala]

Also pasting the code.

Controller

package com.training.springmvc;

import java.util.*;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.validation.BindException;

public class HomePageSimpleFormController extends SimpleFormController {
	
	 private static final String[] ALL_STATES = { "AL", "AK", "AZ", "AR", "CA", "CO", "CT", "DE", "DC", "FL", 
												    "GA", "HI", "ID", "IL", "IN", "IA", "KS", "KY", "LA", "ME", 
												    "MD", "MA", "MI", "MN", "MS", "MO", "MT", "NE", "NV", "NH", 
												    "NJ", "NM", "NY", "NC", "ND", "OH", "OK", "OR", "PA", "RI", 
												    "SC", "SD", "TN", "TX", "UT", "VA", "VT", "WA", "WV", "WI", 
												    "WY"
												  };
	 
	public HomePageSimpleFormController() {
		System.out.println("---1---");
		setCommandClass(UserDetails.class);
	    setCommandName("user");
	}
	/**
	 * Setting up blank data just to avoid NullPointerException.
	 */
	protected Object formBackingObject(HttpServletRequest request)throws Exception {
		System.out.println("---2---");
		UserDetails user = (UserDetails) super.formBackingObject(request);
		return user;
	}
	/**
	 * Data to be used when Http GET called to display the form. Kind of Servlet doGet().
	 */
	protected Map referenceData(HttpServletRequest request) throws Exception {
		System.out.println("---3---");
		Map referenceData = new HashMap();
		referenceData.put("states", ALL_STATES);
		return referenceData;
	}
	
	/**
	 * After display the from when you click on Submit, when it sends Http POST, this onSubmit calls.
	 */
	protected ModelAndView onSubmit(Object command, BindException bindException)throws Exception {
		UserDetails user = (UserDetails)command;
		System.out.println("user.getUserName = "+user.getUserName());
		System.out.println("user.getPassword = "+user.getPassword());
		//Use the request data from user object.
		ArrayList alNames = new ArrayList();
		alNames.add("Murali");
		alNames.add("Krishna");
		
		Map model = bindException.getModel();
		model.put("names", alNames);
		model.put("user", user);
		
		return new ModelAndView(getSuccessView(),  model);
	}

	
}

Command

package com.training.springmvc;

public class UserDetails {
	
	private String userName;
	private String password;
	
	public String getUserName() {
		return userName;
	}
	public void setUserName(String userName) {
		this.userName = userName;
	}
	public String getPassword() {
		return password;
	}
	public void setPassword(String password) {
		this.password = password;
	}

}

application context xml

<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-2.5.xsd">

<bean id="homePageController" class="com.training.springmvc.HomePageSimpleFormController">
	<property name="formView" value="loginPage" />
	<property name="successView" value="home" />	
	<property name="validator" ref="beanValidator" />
</bean>

<bean id="viewResolver" 
    class="org.springframework.web.servlet.view.InternalResourceViewResolver">
  <property name="prefix">
    <value>/WEB-INF/jsp/</value>
  </property>
  <property name="suffix">
    <value>.jsp</value>
  </property>
</bean>

<bean id="simpleUrlMapping" class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping">
  <property name="mappings">
    <props>
      <prop key="/home.htm">homePageController</prop>     
    </props>
  </property>
</bean>

<!-- validation framework -->
<bean id="beanValidator" class="org.springmodules.commons.validator.DefaultBeanValidator">
  <property name="validatorFactory" ref="validatorFactory" />
</bean>

<bean id="validatorFactory" class="org.springmodules.commons.validator.DefaultValidatorFactory">
  <property name="validationConfigLocations">
    <list>
      <value>WEB-INF/validator-rules.xml</value>
      <value>WEB-INF/validation.xml</value>
    </list>
  </property>
</bean>
<!-- validation framework -->
</beans>

validation.xml

<?xml version="1.0" encoding="UTF-8" ?>

<!DOCTYPE form-validation PUBLIC
          "-//Apache Software Foundation//DTD Commons Validator Rules Configuration 1.1.3//EN"
          "http://jakarta.apache.org/commons/dtds/validator_1_1_3.dtd">

<form-validation>
    <formset>

	<form name="user">

		<field property="userName" depends="required,mask,minlength,maxlength">
			<arg0 key="loginForm.username" />
			<arg1 key="${var:minlength}" resource="false" />
			<arg2 key="${var:maxlength}" resource="false" />
			<var>
				<var-name>minlength</var-name>
				<var-value>3</var-value>
			</var>
			<var>
				<var-name>maxlength</var-name>
				<var-value>10</var-value>
			</var>
			<var>
				<var-name>mask</var-name>
				<var-value>^[a-zA-Z]*$</var-value>
			</var>
		</field>
	
		<field property="password" depends="required,mask">
			<arg0 key="loginForm.password" />
			<var>
				<var-name>mask</var-name>
				<var-value>^[0-9a-zA-Z]*$</var-value>
			</var>
		</field>


	</form>

   </formset>

</form-validation>

[Bill Gorder]

I would start with using the annotation based controllers which is the accepted way do controllers since Spring 2.5. There should not be a need to extend SimpleFormController. If you are using newer versions of Spring they have full support for the JSR303 Bean validation API. You can use these and just add hibernate-validator to your classpath.

See the reference documentation
http://static.springsource.org/spring/docs/3.1.x/spring-framework-reference/html/validation.html#validation-beanvalidation

[murali kankanala]

But i am using spring 2.0 in my project, so i need a solution with common-validator only.

[Bill Gorder]

The name of your command class must match the "name" attribute in yourform definition in validation.xml. If this is unacceptable you can look at using ConfigurableBeanValidator instead of DefaultBeanValidator.

http://www.springbyexample.org/maven/site/org.springbyexample.validation/0.94/apidocs/org/springmodules/validation/commons/ConfigurableBeanValidator.html

[murali kankanala]

You are right , i was assuming , in the below code i have set "user" as form name what being used in jsp to read from request scope. Usually in struts we assume this is the name that we have to use in validation.xml. Hmm but in spring it is different.

public HomePageSimpleFormController() {		
		setCommandClass(UserDetails.class);
	    setCommandName("user");
	}

Now what i understand is below

<form-validation>
    <formset>
	<!-- This name attribute must be equal to command class name (UserDetails) but starts with small letter -->
	<form name="userDetails">