Show div based on if statement

[Thomas Byrne]

Hi fellows,
I'm trying to use the following code to show a div based on the value returned by servlet (${message.errorID}). I can't get this to work and wonder if there is an other/better way?

<script>
window.onload = function() {
 var myVal = ${message.errorID};
  if(myVal != "") {
   document.getElementById('error').style.display = 'block'; 
   }
}
</script>

Cheers,
Thomas

[Bear Bibeault]

That doesn't look like it will generate valid JS syntax. Do View Source in the browser and see what gets generated.

[Thomas Byrne]

Thank you for remind me that we have something like source viewer in the browser. The key issue were missing quotations mark around ${message.errorID}.
So, working code looks like:

<script  language="javascript" type="text/javascript">
window.onload = function() {
 var myVal = "${message.errorID}";
  if(myVal != "") {
   document.getElementById('error').style.display = 'block'; 
   }
}
</script>

Cheers,
Thomas

[Bear Bibeault]

There are lots of tools in the modern browsers that can help diagnose these types of problems. In addition to View Source, all modern browsers except Firefox have built-in debuggers. For Firefox, there's the Firebug plugin.