Value in the else condition is getting printed as the page loads

<%-- 
    Document   : login
    Created on : 12 Sep, 2012, 4:30:37 PM
    Author     : sanidhya09
--%>

<%@page contentType="text/html" pageEncoding="UTF-8"%>
<!DOCTYPE html>
<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <title>Login Page</title>
        <link rel="stylesheet" href="css/margin.css" type="text/css" />
 
    </head>
       
    <body background="images/medicallogo.png">
      
      <form name="form" method="post" >

<%
 try{
 Connection con;
 Statement smt;
 ResultSet rs=null;
String user=request.getParameter("user_id");
String pass=request.getParameter("password");
//Class.forName("com.mysql.jdbc.Driver").newInstance();
//connection =DriverManager.getConnection("jdbc:mysql://localhost:3306/hospital", "root", "");
           
                con=Database_Connectivity.dbcon();
                smt=con.createStatement();
                rs=smt.executeQuery("select * from login where user_id='"+user+"' and password='"+pass+"'");
            if(rs.next()){
                while(rs.next())
                {
                    String str=rs.getString("type");
                    if(str.equals("employee"))
                    {
                     response.sendRedirect("index.jsp"); 
                    }              
                                      else{ out.print("Not valid Credentials");}   
                
                }
                               }
                   else {
                          out.print("Not valid Credentials");
                          // response.sendRedirect("login.jsp"); 
                                                     }
               }
            catch(Exception ex)
                {
                System.out.println("Error="+ex);
            }
%>

<p align="center"><font face="Arial Black" color="#800000"><b>PLEASE LOGIN HERE</b></font></p>                           
                <table cellpadding="0" cellspacing="0" width="300" height="250" BORDER="0" align="center">
                     <tr>
                        <td>
                            <font color="#000080" face="arial"/>USERNAME :
                        </td>
                       <td>
                           <input type="text" name="user_id" size="20" id="user_id" />    
                       </td>
                    </tr>
                  <tr>
                      <td>
                        <font face="arial" color="#000080" />PASSWORD :
                         </td>
                       <td>
                           <input type="password" name="password" size="20" id="password" />
                       </td>
                 </tr>
                 <tr>
                     <td>
                        <font face="arial" color="#000080" />COUNTER :  </td>
                       <td>
                           <select size="1" name="Counter">
                        <option>Counter 1</option>
                        <option>Counter 2</option>
                        <option>Counter 3</option>
                        <option>Counter 4</option>
                        <option>Counter 5</option>
                        </select>

</td>
        </tr>
        <tr>
                         <td>
                        <font face="arial" color="#000080" />Remember Me :
                         </td>
                       <td>
                           <input type="CHECKBOX" name="checkbox" />
                       </td>
                 </tr>
        <tr align="right">
            <td>	
                           <button name="reset" type="reset"  style="background-color:lightseagreen">RESET</button>
            </td>
            <td>
                            <button name="login" style="background-color:lightseagreen">LOGIN</button>
                                            
                             
            </td>
        </tr>
        
        </table>
                                        </td>
                                     </tr>
                                </table>
                            </div>                           
               <div id="footer"><br />
                    <%@ include file="footer2.jsp" %>
               </div> 
               
               </td> 
            </tr>          
        </table>
      </form>
    </body>
</html>

Posting just code without an explanation isn't going to get you much help. Just posting some text in the subject is not enough.

Please explain in detail what the problem is (beside using scriptlets in a modern JSP

)

sanidhya kumar wrote:
the message in else statement is getting printed as the page loads,
but it should have been printed only if user name and password is wrong.

<%-- Document : login Created on : 12 Sep, 2012, 4:30:37 PM Author : sanidhya09 --%> <%@page contentType="text/html" pageEncoding="UTF-8"%> <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>Login Page</title> <link rel="stylesheet" href="css/margin.css" type="text/css" /> </head> <body background="images/medicallogo.png"> <form name="form" method="post" > <table background="images/bg1.gif" id="table" width="1000" height="500" border="0" cellpadding="0" cellspacing="0" align="center"> <tr> <td> <div id="Header"> <%@ include file="Header2.jsp" %> </div> <div id="body"> <table id="body1" width="750" height="500" border="0" cellpadding="0" cellspacing="0" align="center"> <tr> <td> <%--Database Connectivity --%> <%@page import="java.sql.*"%> <%@page import="Hospital.Database_Connectivity;"%> <% try{ Connection con; Statement smt; ResultSet rs=null; String user=request.getParameter("user_id"); String pass=request.getParameter("password"); //Class.forName("com.mysql.jdbc.Driver").newInstance(); //connection =DriverManager.getConnection("jdbc:mysql://localhost:3306/hospital", "root", ""); con=Database_Connectivity.dbcon(); smt=con.createStatement(); rs=smt.executeQuery("select * from login where user_id='"+user+"' and password='"+pass+"'"); if(rs.next()){ while(rs.next()) { String str=rs.getString("type"); if(str.equals("employee")) { response.sendRedirect("index.jsp"); } else{ out.print("Not valid Credentials");} } } else { out.print("Not valid Credentials"); // response.sendRedirect("login.jsp"); } } catch(Exception ex) { System.out.println("Error="+ex); } %> <p align="center"><font face="Arial Black" color="#800000"><b>PLEASE LOGIN HERE</b></font></p> <table cellpadding="0" cellspacing="0" width="300" height="250" BORDER="0" align="center"> <tr> <td> <font color="#000080" face="arial"/>USERNAME : </td> <td> <input type="text" name="user_id" size="20" id="user_id" /> </td> </tr> <tr> <td> <font face="arial" color="#000080" />PASSWORD : </td> <td> <input type="password" name="password" size="20" id="password" /> </td> </tr> <tr> <td> <font face="arial" color="#000080" />COUNTER : </td> <td> <select size="1" name="Counter"> <option>Counter 1</option> <option>Counter 2</option> <option>Counter 3</option> <option>Counter 4</option> <option>Counter 5</option> </select> </td> </tr> <tr> <td> <font face="arial" color="#000080" />Remember Me : </td> <td> <input type="CHECKBOX" name="checkbox" /> </td> </tr> <tr align="right"> <td> <button name="reset" type="reset" style="background-color:lightseagreen">RESET</button> </td> <td> <button name="login" style="background-color:lightseagreen">LOGIN</button> </td> </tr> </table> </td> </tr> </table> </div> <div id="footer"><br /> <%@ include file="footer2.jsp" %> </div> </td> </tr> </table> </form> </body> </html>

sanidhya kumar wrote:

sanidhya kumar wrote:
the message in else statement is getting printed as the page loads,
but it should have been printed only if user name and password is wrong.
please see line no 64

<%-- Document : login Created on : 12 Sep, 2012, 4:30:37 PM Author : sanidhya09 --%> <%@page contentType="text/html" pageEncoding="UTF-8"%> <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>Login Page</title> <link rel="stylesheet" href="css/margin.css" type="text/css" /> </head> <body background="images/medicallogo.png"> <form name="form" method="post" > <table background="images/bg1.gif" id="table" width="1000" height="500" border="0" cellpadding="0" cellspacing="0" align="center"> <tr> <td> <div id="Header"> <%@ include file="Header2.jsp" %> </div> <div id="body"> <table id="body1" width="750" height="500" border="0" cellpadding="0" cellspacing="0" align="center"> <tr> <td> <%--Database Connectivity --%> <%@page import="java.sql.*"%> <%@page import="Hospital.Database_Connectivity;"%> <% try{ Connection con; Statement smt; ResultSet rs=null; String user=request.getParameter("user_id"); String pass=request.getParameter("password"); //Class.forName("com.mysql.jdbc.Driver").newInstance(); //connection =DriverManager.getConnection("jdbc:mysql://localhost:3306/hospital", "root", ""); con=Database_Connectivity.dbcon(); smt=con.createStatement(); rs=smt.executeQuery("select * from login where user_id='"+user+"' and password='"+pass+"'"); if(rs.next()){ while(rs.next()) { String str=rs.getString("type"); if(str.equals("employee")) { response.sendRedirect("index.jsp"); } else{ out.print("Not valid Credentials");} } } else { out.print("Not valid Credentials"); // response.sendRedirect("login.jsp"); } } catch(Exception ex) { System.out.println("Error="+ex); } %> <p align="center"><font face="Arial Black" color="#800000"><b>PLEASE LOGIN HERE</b></font></p> <table cellpadding="0" cellspacing="0" width="300" height="250" BORDER="0" align="center"> <tr> <td> <font color="#000080" face="arial"/>USERNAME : </td> <td> <input type="text" name="user_id" size="20" id="user_id" /> </td> </tr> <tr> <td> <font face="arial" color="#000080" />PASSWORD : </td> <td> <input type="password" name="password" size="20" id="password" /> </td> </tr> <tr> <td> <font face="arial" color="#000080" />COUNTER : </td> <td> <select size="1" name="Counter"> <option>Counter 1</option> <option>Counter 2</option> <option>Counter 3</option> <option>Counter 4</option> <option>Counter 5</option> </select> </td> </tr> <tr> <td> <font face="arial" color="#000080" />Remember Me : </td> <td> <input type="CHECKBOX" name="checkbox" /> </td> </tr> <tr align="right"> <td> <button name="reset" type="reset" style="background-color:lightseagreen">RESET</button> </td> <td> <button name="login" style="background-color:lightseagreen">LOGIN</button> </td> </tr> </table> </td> </tr> </table> </div> <div id="footer"><br /> <%@ include file="footer2.jsp" %> </div> </td> </tr> </table> </form> </body> </html>

Well, I'm sure you know that I'm going to tell you that putting Java code into a JSP, especially database access, is a really bad practice that causes lots of problems, including ones like this.

My advice: move the Java code into Java classes, and use the JSTL and EL on the page rather than obsolete and discredited scriptlets.

Do you intentionally drop the first element of rs?

Ivan is correct.

The first rs.next() advances the rs pointer, so if only 1 result then the while rs.next() is false

leading to ... ?

WP