what's wrong with this code?

[midhuna peru]

hi guys!
I was experimenting with protected members. There seems to be silly mistake in my code but I can't figure out what's wrong. here's the code

class Test1
{
protected int no;
}

class Test2
{
Test1 t1 =new Test1();
t1.no=10;
protected String name;

void display()
{
System.out.println("the value of base class no is"+t1.no);
}
}

class ProtectedEx1
{
public static void main(String[] args)
{
Test1 t2 =new Test2();
t2.display();
t2.name="developer";
System.out.println(t2.name);
}
}  

now the error is "<identifier> expected" at line 12. What's the mistake here?

[Nikhil Sagar]

No, i am sure you are getting error on line 9 not on 12.
at this line..

t1.no=10;  

Now think about it, Why are you getting error here on this line .

[midhuna peru]

yah the same line. No m not getting it. must be silly mistake.

[midhuna peru]

no idea

[Nikhil Sagar]

midhuna peru wrote:yah the same line. No m not getting it. must be silly mistake.

Okay, to make it interesting and more understandable to you i am not giving you the correct answer but i am going to ask you some questions, answer me and you will find it out by your self okay.
Tell me the name of the place where you are getting this error ?

[midhuna peru]

line 11
t1.no=10;

[Nikhil Sagar]

midhuna peru wrote:line 11
t1.no=10;

No no no...
tell me in java what we call the place where line 9 is written in your source file ??

[midhuna peru]

class Test2

[Nikhil Sagar]

No, we call that place- is a place where we declare static or non-static variables.
Addition- If it is a non-static then it will go into the object of enclosing class. in your case it will go into the Test2 class's object.

[midhuna peru]

now it is instance variable of Test1. But I am not getting your question.

[midhuna peru]

tell what it is

[Nikhil Sagar]

okay, so if my last post is correct then

t1.no=10;

will go into the Test2 class's object which does not make any sense. that is why compiler is complaining.

[midhuna peru]

I din get you. An object for Test1 is created in Test2 class. Memory will be created for Test1 class's object right.

[midhuna peru]

got it. got it. i initialised object for wrong class! i was trying out inheritance and I did not edit properly.....thanks

[Nikhil Sagar]

midhuna peru wrote:I din get you. An object for Test1 is created in Test2 class. Memory will be created for Test1 class's object right.

have a look on this code...

class Peru
{
        int i;
        Object o=new Object();
        String str=new String("p");

        public static void main(String []args)
        {
               Peru p=new Peru();
        }
}

now at line 3,4 and 5 you are declaring instance variables for Peru class . Got it ??

[Nikhil Sagar]

midhuna peru wrote:got it. got it. i initialised object for wrong class! i was trying out inheritance and I did not edit properly.....thanks

No no no, you are doing a thing at wrong place. And there is one more wrong thing you are doing there in Test2 class but first thing first.

[gurpeet singh]

you cannot have executable code inside the class but outside any methods . you are assigning t1.no = 10; which must be put in method/initializer rather than writing it inside the class.

[midhuna peru]

i corrected line 24. it should be

Test1 t1 =new Test1(); 

still the same error.

[Nikhil Sagar]

gurpeet singh wrote:you cannot have executable code inside the class but outside any methods . you are assigning t1.no = 10; which must be put in method/initializer rather than writing it inside the class.

Gurpreet, you spoiled the suspense

[midhuna peru]

oh right right. Except declaration everything should be inside method. silly of me....i knew it will be stupid mistake. so much for changing a code. next time i should type code fresh if changes are major. Thanks so much.

[Nikhil Sagar]

midhuna peru wrote:oh right right. Except declaration everything should be inside method. silly of me....i knew it will be stupid mistake. so much for changing a code. next time i should type code fresh if changes are major. Thanks so much.

Ah i am glad you got it,

[midhuna peru]

Thanks Gurpreet and Nikhil. i din get it until i typed the code fresh. then i saw difference.

[Nikhil Sagar]

midhuna peru wrote:Thanks Gurpreet Nikhil. i din get it until i typed the code fresh. then i saw difference.

No need to say thanks, we are all here to share our knowledge.

[Nikhil Sagar]

midhuna, one more thing i noticed that can lead to trouble that always use protected members of the super class through inheritance instead of by using association.
for example.

package org.nick;
public class Test1
{
	protected int i;
}

package org.pari;
public class Test2 extends Test1
{
	public static void main(String []args)
	{
		Test1 t=new Test1();
		t.i=9;
	}
}

will not work.

[midhuna peru]

hey! this is what my code was first. Ofcourse Test1 was not public I just copied and edited in new file and ended up with trouble. When I Typed code fresh i did it right . only on comparing edited code and fresh code i understood the mistake.
Anyway whats wrong with Base Class being Public?