why my results can't pass the 999 limit?

[Or Ben-Moshe]

the problem of this code is that the result won't past the 999 limit.
for example if i put "800 * 5" the result given back is 40 instead of 4000.
what is the problem?
there is the code:

import java.util.Scanner;
public class Calculator
{
 static Scanner reader=new Scanner(System.in);
 public static void main (String []args)
	{
	 while (true){
	 String one,plus="$";
	System.out.println("Enter Your Equation:");
	one=reader.next();
	char one1 = one.charAt(0);
	char plus1=plus.charAt(0);
	if (one1==plus1)
	{
		int two;
		two=reader.nextInt();
		System.out.println("="+Math.sqrt(two));
	}
	else
	{
		 long realone,two,result=0;
		 double doubleresult;
		 realone = Character.getNumericValue(one1);
		 char sign;
		 sign=reader.next().charAt(0);
		 two=reader.nextLong();
		 switch (sign) {
		 	case '+': result=(realone+two);
		 		break;
		 	case '-': result=(realone-two);
	 			break;
		 	case '/': result=(realone/two);
	 			break;
		 	case '*': result=(realone*two);
	 			break;
		 	case '^': doubleresult=(Math.pow(realone,two)); result = (long) doubleresult;
	 			break;
		 	default: System.out.println("Error try again");
            break;
		 }
            System.out.println("="+result);
		 }
		 
		 
		 
	}
	}
}

[Kemal Sokolovic]

With

char one1 = one.charAt(0);

if you enter "800" you're just picking '8', so that's the value you are working with. Rather confusing calculator, I must say... And please UseCodeTags.

Edit: Now I see you edited your post and put your code inside code tags.

[Or Ben-Moshe]

thanks but i figured it out alone a few minutes ago

[Or Ben-Moshe]

but still i can't figure out how to do it without converting the string to char

[Or Ben-Moshe]

thats all i got this alone here is the working code

import java.util.Scanner;
public class Calculator
{
 static Scanner reader=new Scanner(System.in);
 public static void main (String []args)
	{
	 while (true){
	 String one,plus="$";
	System.out.println("Enter Your Equation:");
	one=reader.next();
	
	if (one==plus)
	{
		int two;
		two=reader.nextInt();
		System.out.println("="+Math.sqrt(two));
	}
	else
	{
		 long two,result=0;
		 double doubleresult;
		 long realone = Long.parseLong(one);
		
		 char sign;
		 sign=reader.next().charAt(0);
		 two=reader.nextLong();
		 switch (sign) {
		 	case '+': result=(realone+two);
		 		break;
		 	case '-': result=(realone-two);
	 			break;
		 	case '/': result=(realone/two);
	 			break;
		 	case '*': result=(realone*two);
	 			break;
		 	case '^': doubleresult=(Math.pow(realone,two)); result = (long) doubleresult;
	 			break;
		 	default: System.out.println("Error try again");
            break;
		 }
            System.out.println("="+result);
		 }
		 
		 
		 
	}
	}
}

[Kemal Sokolovic]

Why not extract value of desired type directly from String? Check the API for valueOf(String s) method (depending on type of the value you want to get from string it might be in Integer, Double, ..., class).

Edit: Avoid comparing Strings with '==' oparator. Use equals() instead.

[Campbell Ritchie]

And welcome to the Ranch

[Kemal Sokolovic]

Campbell Ritchie wrote:And welcome to the Ranch

Hm, I usually forget that part!