Test Results 4 failed tests JUnit

[Tom Mordon]

I have been stuck on these test failures and have narrowed it down to the Order.calHandlingCharge() method. When I run and compile the program it works but I have these last 4 of 21 tests that fail in JUnit. Any thoughts? The error given is "caused an ERROR: java.lang.NullPointerException"



Any thoughts on what I can do to get it to pass the tests? I think that its not creating and instance of something that it needs for testing?

Pasted below: OrderTest.java, Order.java, ProcessOrder.java, OrderDriver.java

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

import junit.framework.TestCase;




/**
 *
 * @author Bismarck
 */
public class OrderTest extends TestCase {
    
    public OrderTest(String testName) {
        super(testName);
    }
    
    @Override
    protected void setUp() throws Exception {
        super.setUp();
    }
    
    @Override
    protected void tearDown() throws Exception {
        super.tearDown();
    }

    public void testSetCustomerName() {
        System.out.println("setCustomerName");
        String s = "Dan";
        Order instance = new Order();
        instance.setCustomerName(s);
        String expResult = "Dan";
        
        if(s.equals(expResult)==false) {
            fail("The results are not equal.");
        }
       
    }

    public void testGetCustomerName() {
        System.out.println("getCustomerName");
        Order instance = new Order();
        String expResult = "Dan";
        String result = instance.getCustomerName();
        //assertEquals(expResult, result);
        if(result.equals(expResult)==false) {
            fail("The test case is a prototype.");
        }    
    }
    
    public void testSetCustomerNumber() {
        System.out.println("setCustomerNumber");
        int i = 0;
        Order instance = new Order();
        int expResult = 0;
        instance.setCustomerNumber(i);
        
        if(instance.getCustomerNumber() != expResult) {
            fail("The values are not equal.");
        }
    }
    
    
    public void testGetCustomerNumber() {
        System.out.println("getCustomerNumber");
        Order instance = new Order();
        
        int expResult = 0001;
        
        instance.getCustomerNumber();
        //assertEquals(expResult, result);
        if(instance.getCustomerNumber() != expResult) {
            fail("The test case is a prototype.");
        }
    }
    
    public void testSetExtendedPrice() {
        System.out.println("setExtendedPrice");
        double d = 0.0;
        Order instance = new Order();
        instance.setExtendedPrice(d);
        double expResult = 0.0;
        if(instance.getExtendedPrice() != expResult) {
            fail("The values are not equal.");
        }    
    }

    public void testGetExtendedPrice() {
        System.out.println("getExtendedPrice");
        Order instance = new Order();
        double expResult = 0.0;
        instance.getExtendedPrice();
        
        if( instance.getExtendedPrice() != expResult) {
            fail("The test case is a prototype.");
        }
    }

    public void testSetItem() {
        System.out.println("setItem");
        String s = "guns";
        String expResult = "guns";
        Order instance = new Order();
        instance.setItem(s);
        
        if(s.equals(expResult) == false ) {
            fail("The test case is a prototype.");
        }
        
    }

    public void testGetItem() {
        System.out.println("getItem");
        Order instance = new Order();
        String expResult = "guns";
        if(instance.getItem() != expResult) {
            fail("The test case is a prototype.");
        }
        
        
    }

    public void testSetQuantity() {
        System.out.println("setQuantity");
        int i = 0;
        Order instance = new Order();
        instance.setQuantity(i);
        int expResult = 0;
        if(instance.getQuantity() != expResult) {
            fail("The test case is a prototype.");
        }
    }

    public void testGetQuantity() {
        System.out.println("getQuantity");
        Order instance = new Order();
        int expResult = 0;
        int result = instance.getQuantity();
        if(result != expResult) {
            fail("The test case is a prototype.");
        }
        
    }

    public void testSetUnitPrice() {
        System.out.println("setUnitPrice");
        double d = 20.99;
        Order instance = new Order();
        instance.setUnitPrice(d);
        double expResult = 20.99;
        if(instance.getUnitPrice() != expResult) {
            fail("The test case is a prototype.");
        }
        
    }

    public void testGetUnitPrice() {
        System.out.println("getUnitPrice");
        Order instance = new Order();
        double expResult = 20.99;
        
        if(instance.getUnitPrice() != expResult) {
            fail("The test case is a prototype.");
        }
        
        //assertEquals(expResult, result, 0.0);
        
    }

    public void testSetHandlingCharge() {
        System.out.println("setHandlingCharge");
        double d = 7.99;
        Order instance = new Order();
        instance.setHandlingCharge(d);
        double expResult = 7.99;
        if(instance.getHandlingCharge() != expResult) {
            fail("Set Handling Not Working");
        }
        
    }

    public void testGetHandlingCharge() {
        System.out.println("getHandlingCharge");
        Order instance = new Order();
        double expResult = 7.99;
        //double result = instance.getHandlingCharge();
        //assertEquals(expResult, result, 0.0);
        if(instance.getHandlingCharge() != expResult) {
            fail("getHandlingCharge not working");
        }
    }

    public void testSetHChargeQuantity() {
        System.out.println("setHChargeQuantity");
        int[] i = null;
        Order instance = new Order();
        instance.setHChargeQuantity(i);
        int[] expResult = null;
        if(instance.getHChargeQuantity() != expResult) {
            fail("The test case is a prototype.");
        }
    }

    public void testGetHChargeQuantity() {
        System.out.println("getHChargeQuantity");
        Order instance = new Order();
        int[] expResult = null;
        //int[] result = instance.getHChargeQuantity();
        if(instance.getHChargeQuantity() != expResult) {
            fail("GetHChargeQuantity failed");
        }
        
        //assertEquals(expResult, result);
        
    }

    public void testSetHChargeAmount() {
        System.out.println("setHChargeAmount");
        double[] d = null;
        Order instance = new Order();
        instance.setHChargeAmount(d);
        double[] expResult = null;
        if(instance.getHChargeAmount() != expResult) {
            fail("SetHChargeAmount failed");
        }
        
    }

    public void testGetHChargeAmount() {
        System.out.println("getHChargeAmount");
        Order instance = new Order();
        double[] expResult = null;
        //double[] result = instance.getHChargeAmount();
        //assertEquals(expResult, result);
        if(instance.getHChargeAmount() != expResult) {
            fail("GetHChargeAmount");
        }
    }

    public void testCalExtendedPrice() {
        System.out.println("calExtendedPrice");
        Order instance = new Order();
        //instance.calExtendedPrice();
        if(instance.getExtendedPrice() != 0.0) {
            fail("CalExtendedPrice failed");
        }
    }

    public void testCalHandlingCharge() {
        System.out.println("calHandlingCharge");
        Order instance = new Order();
        instance.calHandlingCharge();
        double expResult = 0.0;
        if(instance.getHandlingCharge() != expResult) {
            fail("testCalHandlingCharge failed");
        }
    }

    public void testDisplay() {
        System.out.println("display");
        Order instance = new Order();
        String expResult = "";
        //String result = instance.display();
        if(instance.display() != expResult) {
            fail("testDisplay failed");
        }
        //assertEquals(expResult, result);
        
    }
}



public class Order {


    private String customerName = "Dan";
    private int customerNumber = 0001;
    private double extendedPrice = 0.0;
    private String item = "guns";
    private int quantity = 0;
    private double unitPrice = 20.99;
    private double handlingCharge = 7.99;

    private int[] hChargeQuantity;
    private double[] hChargeAmount;


    public void setCustomerName(String s) {
        this.customerName = s;
    }


    public String getCustomerName() {
        return this.customerName;
    }


    public void setCustomerNumber(int i) {
        this.customerNumber = i;
    }


    public int getCustomerNumber() {
        return this.customerNumber;
    }


    public void setExtendedPrice(double d) {
        this.extendedPrice = d;
    }


    public double getExtendedPrice() {
        calExtendedPrice();
        return this.extendedPrice;
    }


    public void setItem(String s) {
        this.item = s;
    }


    public String getItem() {
        return this.item;
    }


    public void setQuantity(int i) {
        this.quantity = i;
    }


    public int getQuantity() {
        return this.quantity;
    }


    public void setUnitPrice(double d) {
        this.unitPrice = d;
    }


    public double getUnitPrice() {
        return this.unitPrice;
    }


    public void setHandlingCharge(double d) {
        this.handlingCharge = d;
    }


    public double getHandlingCharge() {
        calHandlingCharge();
        return this.handlingCharge;
    }


    public void setHChargeQuantity(int[] i) {
        this.hChargeQuantity = i;
    }


    public int[] getHChargeQuantity() {
        return this.hChargeQuantity;
    }


    public void setHChargeAmount(double[] d) {
        this.hChargeAmount = d;
    }


    public double[] getHChargeAmount() {
        return this.hChargeAmount;
    }


    public void calExtendedPrice() {
        setExtendedPrice(this.quantity * this.unitPrice);
    }


    public void calHandlingCharge() {
        double  d  = 0;
        for (int i = 0; i < this.hChargeQuantity.length; i++) {
            if (this.quantity < this.hChargeQuantity[i]) {
                if (this.quantity>0) {   
                    setHandlingCharge(this.hChargeAmount[i - 1]);
                } else { 
                    setHandlingCharge(this.hChargeAmount[0]);
                }    
                return;
            }
            d = this.hChargeAmount[i];
        }
        setHandlingCharge(d);
    }

    public String display() {
        return "\n" + "\nCustomer :" + getCustomerName() +
                "\nItem Ordered: " + getItem() +
                "\nUnit Price: $" + getUnitPrice() +
                "\nTotal: $" + getExtendedPrice() +
                "\n" +
                "\nPlus a $" + getHandlingCharge() + " processing charge" +
                "\nGrand Total: " + (getExtendedPrice() + getHandlingCharge());
    }

 }

import java.io.*;
import java.util.*;

public class ProcessOrder {


    private List<String> orderInfo = new ArrayList<String>();
    private Map orders = new Hashtable();

    //test Exception for file not found
    private void readOrder() {
        try {
            BufferedReader  br  = new BufferedReader(new FileReader("d:\\Dropbox\\JavaEE\\Project1\\orderin.txt"));
            while (br.ready())  orderInfo.add(br.readLine());             
            br.close();
        }
        catch (Exception e) {
            e.printStackTrace();
        }
    }


    private void readCharges(Order d) {
        int[]     itemRange   = new int[4];
        double[]  itemCharge  = new double[4];
        String[]  sarray      = new String[2];
        int       counter     = 0;
        try {
            BufferedReader  br  = new BufferedReader(new FileReader("d:\\Dropbox\\JavaEE\\Project1\\readCharges.txt"));
            while (br.ready()) {
                String  s  = br.readLine();
                sarray = s.split(" ");
                itemRange[counter] = Integer.parseInt(sarray[0]);
                itemCharge[counter] = Double.parseDouble(sarray[1]);
                counter++;
            }
        }
        catch (Exception e) {
            e.printStackTrace();
        }
        d.setHChargeQuantity(itemRange);
        d.setHChargeAmount(itemCharge);
    }


    private void createOrder() {
        for (int i = 0; i < orderInfo.size(); i++) {
            Order     d       = new Order();
            String[]  sorder  = ((String) orderInfo.get(i)).split("\\s");
            d.setCustomerName(sorder[0]);
            System.out.println(sorder[0]);
            d.setCustomerNumber(Integer.parseInt(sorder[1]));
            System.out.println(sorder[1]);
            d.setQuantity(Integer.parseInt(sorder[2]));
            System.out.println(sorder[2]);
            d.setUnitPrice(Double.parseDouble(sorder[3]));
            System.out.println(sorder[3]);
            d.setItem(sorder[4]);
            System.out.println(sorder[4]);
            readCharges(d);
            orders.put((String) sorder[0], d);
        }
    }


    private void writeOutput() {
        Iterator  i  = orders.entrySet().iterator();
        try {
            PrintWriter  pr  = new PrintWriter("d:\\Dropbox\\JavaEE\\Project1\\orderout.txt");
            while (i.hasNext()) {
                Map.Entry  me  = (Map.Entry) i.next();
                Order      d   = (Order) me.getValue();
                pr.println(d.display());
            }
            pr.close();
        }
        catch (Exception e) {
            e.printStackTrace();
        }
    }

    /*
     * add toString()
     * 
     */
    

    public void run() {
        readOrder();
        createOrder();
        writeOutput();
    }

}


public class OrderDriver {


    public static void main(String[] args) {
        ProcessOrder  p  = new ProcessOrder();
        p.run();
    }
}

[Jeanne Boyarsky]

Yes. hChargeQuantity is null. I found this out by running the code and looking at the stack trace of the failure. Try tracking the code that calls setHChargeQuantity() to see why this is the case.

[Junilu Lacar]

Where in your code do the fields defined on lines 289 and 290 get assigned valid references to arrays? By default, these will be set to null when an object is instantiated.

[Tom Mordon]

Good point they do not get created/instantiated or assigned a value by anything. I thought this was ok because I'm only comparing them to another null value, but maybe they are not a null value. I will assign them a value and compare to that value.