Data in java please somebody help.

[baran yildirim]

I am trying to add comparison and swap, I am freak out, what am I supposed to do? I really dont have any idea, please someone help, I need missing part.

 public class BubbleSort{
public static void main(String a[]){
int i;

int array[] = {21,33,7,25};

bubblesort(array, array.length);
for(i = 0; i <array.length; i++){
System.out.print(array[i]+" ");

}}

public static void bubblesort( int a[], int N ){
int i, j, t=0;
for(i = 0; i < N; i++){
for(j = 1; j < (N-i); j++){
if(a[j-1] > a[j]){
SWAP(a[j-1],a[j]);
t = a[j-1];
a[j-1]=a[j];
a[j]=t;
}
}
}}

private static void SWAP(int i, int j) {
// TODO Auto-generated method stub

}}

[Greg Charles]

Hi and welcome to JavaRanch!

What you're trying to do is swap values at the j-1 and j positions of the array a. So, if a holds the values: 8 2 1 7 3, and you are comparing the 2 and the 1, then you swap them to get 8 1 2 7 3. Eventually, after enough swapping, the whole array will be sorted (if the rest of your logic is right).

Unfortunately, the way you've written SWAP() there's no way it will work, no matter how the "missing piece" is filled in. That is, whatever you do in the method, the array will be unchanged after you finish. Now, if you defined it like:

private static void swap(int [] a, int i, int j)

then it would be possible to make it work. Give that a try and see if you can figure it out.