JTree up not working properly

[Krithika Beri]

I have a JTree and a button in the UI called up. When i select a node and say up, it is supposed to move that node up. The problem is that the first time it works fine but the second time that node disappears completely from the tree.

if (e.getSource() == down) {
			DefaultTreeModel model = (DefaultTreeModel) tree.getModel();
			TreePath tp = tree.getSelectionPath();

			if (tp == null) {
				JOptionPane.showMessageDialog(null, "No node selected",
						"Error", JOptionPane.ERROR_MESSAGE);
				return;
			}

			int indexmoved = tp.getPathCount();
			String nodemoved = tp.getLastPathComponent().toString();
			String nodemovedparent = tp.getPathComponent(indexmoved - 2)
					.toString();
			DefaultMutableTreeNode select = (DefaultMutableTreeNode) tp
					.getLastPathComponent();

			int index = select.getParent().getIndex(select);
			TreeNode parent = select.getParent();
			int child_no = parent.getChildCount() - 1;
			if (index != child_no) {

				DefaultMutableTreeNode[] children = null;
				if (select.getAllowsChildren() && select.getChildCount() > 0) {
					children = new DefaultMutableTreeNode[select
							.getChildCount()];
					int i = 0;
					Enumeration enumeration = select.children();
					while (enumeration.hasMoreElements()) {
						// Downcast needed
						DefaultMutableTreeNode child = (DefaultMutableTreeNode) enumeration
								.nextElement();
						children[i] = child;
						++i;
					}
				}

				model.removeNodeFromParent(select);

				DefaultMutableTreeNode newNode = new DefaultMutableTreeNode(
						select);
				// Add picked child nodes after moving up
				if (children != null) {
					for (DefaultMutableTreeNode childNode : children) {
						newNode.add(childNode);
					}
				}

				model.insertNodeInto(newNode, (MutableTreeNode) parent,
						index + 1);

				DefaultXMLTreeNode lastPathComponent = (DefaultXMLTreeNode) tp
						.getLastPathComponent();
				Node selectedNode = lastPathComponent.getNode();
				Node nodeParent = selectedNode.getParentNode();
				Node nodebelow = selectedNode.getNextSibling();
				Node nodebelowbelow = nodebelow.getNextSibling();

				int playorder_sel = 0, playorder_below = 0;
				NamedNodeMap elementAtt_selnode = selectedNode.getAttributes();

				NamedNodeMap elementAtt_selabove = nodebelow.getAttributes();

				playorder_sel = Integer.parseInt(elementAtt_selnode
						.getNamedItem("playOrder").getNodeValue());
				playorder_below = Integer.parseInt(elementAtt_selabove
						.getNamedItem("playOrder").getNodeValue());

				if (playorder_below != playorder_sel) {
					playorder_sel = playorder_sel + 1;
					elementAtt_selnode.getNamedItem("playOrder").setNodeValue(
							playorder_sel + "");

					playorder_below = playorder_sel - 1;
					elementAtt_selabove.getNamedItem("playOrder").setNodeValue(
							playorder_below + "");

				}
				nodeParent.insertBefore(selectedNode, nodebelowbelow);

				TreeNode[] nodes = model.getPathToRoot(newNode);
				tree.setSelectionPath(new TreePath(nodes));

			} else {
				JOptionPane.showMessageDialog(null,
						"Selected node is last node.", "Error",
						JOptionPane.ERROR_MESSAGE);
			}
		}

	}

[Kemal Sokolovic]

You started this topic about a month ago, and as I recall you got the solution for your "moving node up" problem (though the point was to select the node moved up, but still the code was working fine for what you want).