Transfer File from Android to server via socket

[Tan Kok Lim]

Currently, I've created one android apps to enables to send/transfer file from internal storage to remote server via WAN when I stayed in outside.

All files is success transfer but at the end my server is ended up with this message, ( the picture/music files will be success rendered when I quit out this programs )

Exception in thread "main" java.lang.IllegalArgumentException: Illegal Capacity: -1
at java.util.ArrayList.<init>(Unknown Source)
at ServerSocket.com.ServerRun.main(ServerRun.java:60)

Here is my server side code,

Server :

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.DataInputStream;
import java.io.DataOutputStream;
import java.io.EOFException;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.ArrayList;

public class ServerRun {

	/**
	 * @param args
	 */
	public static void main(String[] args) throws IOException,EOFException {
		// TODO Auto-generated method stub
	 FileOutputStream fos;
	 BufferedOutputStream bos;
   	 OutputStream output;
   	 DataOutputStream dos;
   	 int len;
   	 int smblen; 
   	 InputStream in;
   	 DataInputStream clientData;
   	 BufferedInputStream clientBuff;
 
   	 
   	ServerSocket serverSocket = new ServerSocket(5991);
    Socket clientSocket = null;
    clientSocket = serverSocket.accept();
  
   
        in = clientSocket.getInputStream(); //used  
    
       clientData = new DataInputStream(in); //use	
       clientBuff = new BufferedInputStream(in); //use	
    
		 while(true){  
		   	
		    System.out.println("Starting...");  
		       
	    	    int fileSize = clientData.read();
	    	       
	    	    ArrayList<File>files=new ArrayList<File>(fileSize); //store list of filename from client directory
	    	    ArrayList<Integer>sizes = new ArrayList<Integer>(fileSize); //store file size from client
	    	    //Start to accept those filename from server
	    	    for (int count=0;count < fileSize;count ++){
	    	    	    File ff=new File(clientData.readUTF());
	    	    	    files.add(ff);
	    	    }
	    	    
	    	    for (int count=0;count < fileSize;count ++){
	    	    	
	    	    	    sizes.add(clientData.readInt());
	    	    }
	    	    
	           for (int count =0;count < fileSize ;count ++){   
	
	        	  len=sizes.get(count);
	                   	   
	            System.out.println("File Size ="+len);
	            
	            //output = new FileOutputStream("C:/share/" + fileName);
	            output = new FileOutputStream("C:/share/" + files.get(count));
	            dos=new DataOutputStream(output);
	            bos=new BufferedOutputStream(output);
	            
	            byte[] buffer = new byte[1024];  
	            
	            bos.write(buffer, 0, buffer.length); //This line is important
	    
	            while (len > 0 && (smblen = clientData.read(buffer)) > 0) { 
	            	dos.write(buffer, 0, smblen); 
	                  len = len - smblen;
	                  dos.flush();
	                }  
	           }   
	   }
	    
	  } //end loop 

}

Android Side

import java.io.BufferedInputStream;
import java.io.DataOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.OutputStream;
import java.net.InetAddress;
import java.net.Socket;

import jcifs.smb.NtlmPasswordAuthentication;
import jcifs.smb.SmbFile;
import jcifs.smb.SmbFileOutputStream;
import android.app.Activity;
import android.content.Context;
import android.media.MediaScannerConnection;
import android.net.Uri;
import android.os.Bundle;
import android.os.Environment;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.Toast;

public class FileTransferLite extends Activity {
    private Button send;
    private Button sendWan;
    private Socket socket;
	private File f,fdst;
	private FileInputStream fin,fises;
	private static Context context;
	
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_file_transfer_lite);
        send=(Button)findViewById(R.id.send);
        sendWan=(Button)findViewById(R.id.sendWan);
        FileTransferLite.context = getApplicationContext();
           
        sendWan.setOnClickListener(new OnClickListener(){
            
        	public void onClick(View view){
        		
        		try {
        			socket = new Socket(InetAddress.getByName("192.168.9.6"), 5991);
        			
        			System.out.println("Connecting...");
        			
        			
        			File fil=new File(Environment.getExternalStorageDirectory() + "/DCIM/Camera/");
        			
        			File[] Files=fil.listFiles();
        			
        			for (int count=0;count < Files.length;count ++){
        				System.out.println(Files[count].getName());
        				
        			}
        			
        		    OutputStream os = socket.getOutputStream();  
        		    DataOutputStream dos = new DataOutputStream(os); 
        		    
        		    dos.writeInt(Files.length);
        		    
        		    for (int count=0;count<Files.length;count ++){
        		    	  dos.writeUTF(Files[count].getName());
        		    	  
        		    }
        		    for (int count=0;count<Files.length;count ++){
        		    	  
        		    	  int filesize = (int) Files[count].length();
        		    	  dos.writeInt(filesize);
        		    }
        		    
        	        for (int count=0;count<Files.length;count ++){
        			
        	        int filesize = (int) Files[count].length();
        			byte [] buffer = new byte [filesize];
        	        	
        	        FileInputStream fis = new FileInputStream(Files[count].toString());  
        	        BufferedInputStream bis = new BufferedInputStream(fis);  
        	             
        	        //Sending file name and file size to the server  
        	        bis.read(buffer, 0, buffer.length); //This line is important
        	        dos.write(buffer, 0, buffer.length);   
        	        dos.flush(); 
        	 			    		   
        		    //close socket connection
        		    //socket.close();
        		           	    
        		}

                             Toast.makeText(getApplicationContext(),"Transfer file is completed!!", Toast.LENGTH_LONG).show(); 
        		     socket.close();
        		}
        		catch(Exception e){
        			System.out.println("Error::"+e);
        			//System.out.println(e.getMessage());
        			//e.printStackTrace();
        			//Log.i("******* :( ", "UnknownHostException");
        		}
        		
        	}
        	
    });
       
    }
}

My problem is here how can I modify to server side code to avoid this problems on future. Appreciate to any helps and thanks.

[Deepak Bala]

The stack trace line number and the one from your code do not match. Line number 60 on ServerRun.java is '{'

at ServerSocket.com.ServerRun.main(ServerRun.java:60) 

Are you sure the information is accurate ?