Can we have nested finally block ?

[raj chopra]

Hi All,

few parts of my code have too many open connections. so i plan to close them where necessary .

my dialama was that shall i go ahead with nested finally block at each try block respectively or to go with single finally block to close all the connections ?

please guide me to right steps in doing so .

below i present sample code for closing the connections

*-----------------------------------------------------------------------------------------------------
 * Classname / Interfacename: SBAdminAlertStatusDAOHibernate
 *
 * Description: E-mail template showing last 24 hours status.
 *
 * Version:
 *
 * Date: 06/06/2006
 *
 * Author: Ganesh_rd
 *
 * Copyright (c) Syntel Ltd. All Rights Reserved.
 * -----------------------------------------------------------------------------------------------------
 *      	User	Date	Changes/ Description
 * -----------------------------------------------------------------------------------------------------
 * 		Ravi P		6-Nov-2006	Commenting of Sop's(print statements on console)
 *	Ganesh Reddy	13-DEC-2006	Added loginIdGlobal to set E_mail_Status of 1 for right user-id
 *    Vimal			12-Jun-2007			changes done for removing null value displayed in mail.  
 * -----------------------------------------------------------------------------------------------------
 */

package com.syntel.sb.arch.batch.dao.hibernate;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.List;

import oracle.jdbc.driver.OracleCallableStatement;
import oracle.jdbc.driver.OracleTypes;
import oracle.sql.ARRAY;

import org.hibernate.Session;

import com.syntel.sb.appl.action.client.DBConnectionManager;
import com.syntel.sb.arch.batch.common.SBAutoGen;
import com.syntel.sb.arch.batch.common.SBBatEndLog;
import com.syntel.sb.arch.batch.common.SBBatStartLog;
import com.syntel.sb.arch.batch.common.SBBatchQueries;
import com.syntel.sb.arch.batch.common.SBErrorBat;
import com.syntel.sb.arch.batch.common.SBFilePath;
import com.syntel.sb.arch.batch.dao.SBAdminAlertStatusDAO;
import com.syntel.sb.arch.batch.vo.SBAdminAlertStatusVO;
import com.syntel.sb.arch.batch.vo.SBBatEndVO;
import com.syntel.sb.arch.batch.vo.SBBatStartVO;
import com.syntel.sb.arch.batch.vo.SBErrorBatVO;
import com.syntel.sb.arch.dao.hibernate.SBBaseDAOHibernate;

public class SBAdminAlertStatusDAOHibernate extends SBBaseDAOHibernate implements SBAdminAlertStatusDAO,SBFilePath, SBBatchQueries {
	String loginIdGlobal=null;
public SBAdminAlertStatusVO adminAlertStatus(SBAdminAlertStatusVO sbAdminAlertStatusVO) {

		SBBatEndVO sbBatEndVO=new SBBatEndVO();
		sbBatEndVO.setErrFileName("AdminBatendlog");
		SBBatEndLog sbBatEndLog =new SBBatEndLog();


		SBErrorBatVO sbErrorBatVO=new SBErrorBatVO();
		sbErrorBatVO.setPgmID("Admin_Alert_Status");
		SBErrorBat sbErrorBat=new SBErrorBat();

		Session session =getSession();
		Connection con =session.connection();

		ResultSet QryEmailType=null;
		ResultSet qryFrom=null;
		ResultSet QryASysparm=null;

		try{
			//System.out.println("*********In DAOHibernate of Admin Alert Status*********");

		   	Statement stmt1 = con.createStatement() ;
		   	//<!---- To retrieve userid------------>
	   		ResultSet qryUserID = stmt1.executeQuery(SBAdminAlertStatus001);

	   		if(qryUserID.next())
	   		{
				 String logInID=qryUserID.getString("LOG_IN_ID");
				 loginIdGlobal=logInID;
				 sbAdminAlertStatusVO.setpLogInID(logInID);

	   		}
	   		else
	   		{
	   			String errMessage="No Record Found For The Administrator In The Userid Table";

	   			sbAdminAlertStatusVO.setErrorMessage(errMessage);
		    }
		  }	catch (SQLException e)
			{

				sbErrorBat.logError(sbErrorBatVO);
			}
		catch (Exception e) {

		sbErrorBatVO.setPgmID(sbAdminAlertStatusVO.getPgmID());
		sbErrorBatVO.setErrMessage(sbAdminAlertStatusVO.getErrorMessage());
		sbErrorBat.logError(sbErrorBatVO);

		}
		try{
		   	Statement stmt2 = con.createStatement();
		   	//<!----- To retrieve from address--------->
			qryFrom = stmt2.executeQuery(SBAdminAlertStatus002);

			if(qryFrom.next())
	   		{
				sbAdminAlertStatusVO.setlclFrom(qryFrom.getString("parameter_value"));

	   		}
            }
		catch(Exception e)
		   {
			e.printStackTrace();
			releaseSession(session);
		   }
		try{
			Statement stmt3 = con.createStatement() ;
			//<!--------To retrieve To address--------->
		    QryASysparm = stmt3.executeQuery(SBAdminAlertStatus003);

			if(QryASysparm.next()){
				sbAdminAlertStatusVO.setToAddr1(QryASysparm.getString(1));
				sbAdminAlertStatusVO.setToAddr2(QryASysparm.getString(2));
		    }
			}
		catch(SQLException e){ e.printStackTrace();
			int   pErrorcode  		= 1560;
			String  errMessage		= "Error Occurred in QRY_a_sys_parm ";
			sbAdminAlertStatusVO.setPgmID(errMessage);
			sbErrorBatVO.setPgmID(sbAdminAlertStatusVO.getPgmID());
			sbErrorBatVO.setErrMessage(sbAdminAlertStatusVO.getErrorMessage());
			sbErrorBat.logError(sbErrorBatVO);
			releaseSession(session);
		    }


		try{
			Statement stmt4 = con.createStatement();
			//<!--------To retrieve mail subject--------->
			 QryEmailType = stmt4.executeQuery(SBAdminAlertStatus004);

			if(QryEmailType.next()){
				sbAdminAlertStatusVO.setmailSubject(QryEmailType.getString(1));

			}
			else{
				String errMessage="No Record Found For The E-mail Type In The E_Mail_Type Table";
				sbAdminAlertStatusVO.setErrorMessage(errMessage);

			}
		    }
		catch(SQLException e){
					sbErrorBat.logError(sbErrorBatVO);
					releaseSession(session);
				}
		catch (Exception e) {

		sbErrorBatVO.setPgmID(sbAdminAlertStatusVO.getPgmID());
		sbErrorBatVO.setErrMessage(sbAdminAlertStatusVO.getErrorMessage());
		sbErrorBat.logError(sbErrorBatVO);
		}


		try{
			Statement stmt5 = con.createStatement() ;
			//<!--------To retrieve Standard signature--------->
			ResultSet QryStdsign = stmt5.executeQuery(SBAdminAlertStatus005);

		    if(QryStdsign.next()){
		    	sbAdminAlertStatusVO.setlclSig(QryStdsign.getString(1));

		    }
		    else{
		    	sbAdminAlertStatusVO.setlclSig("SkillBay");

		    }
		}
		catch(SQLException e){
			sbErrorBat.logError(sbErrorBatVO);
			releaseSession(session);
		}






		int clientId=12;
		try{
		List adminStatistics=new ArrayList();

				DBConnectionManager connMgr = DBConnectionManager.getInstance();
  				Connection conn  = connMgr.getConnection("oracle");


		OracleCallableStatement stmt = (OracleCallableStatement)conn.prepareCall( "begin ? := ADMINGETSTATISTICS(?,?); end;" );

		stmt.registerOutParameter(1,OracleTypes.ARRAY,"SIMPLEARRAY");
		stmt.setString(2,sbAdminAlertStatusVO.getpLogInID());
	 	stmt.setInt(3,clientId);
		stmt.executeUpdate();

		ARRAY simpleArray = stmt.getARRAY(1);
		String[] values = (String[])simpleArray.getArray();
		for( int i = 0; i < values.length; i++ ) {
			adminStatistics.add(values[i]);
		}

		if(adminStatistics.size()>0)
	     {
	    	 sbAdminAlertStatusVO.setAppliedVendors((String) adminStatistics.get(0));
	    	 sbAdminAlertStatusVO.setAppliedVendors24((String) adminStatistics.get(1));
		     sbAdminAlertStatusVO.setAppliedClients((String) adminStatistics.get(2));
		     sbAdminAlertStatusVO.setAppliedClients24((String) adminStatistics.get(3));
		     sbAdminAlertStatusVO.setAppliedAgents((String) adminStatistics.get(4));
		     sbAdminAlertStatusVO.setAppliedAgents24((String) adminStatistics.get(5));

		         sbAdminAlertStatusVO.setRejectedVendors((String) adminStatistics.get(6));
		    	 sbAdminAlertStatusVO.setRejectedVendors24((String) adminStatistics.get(7));
		    	 sbAdminAlertStatusVO.setRejectedClients((String) adminStatistics.get(8));
		    	 sbAdminAlertStatusVO.setRejectedClients24((String) adminStatistics.get(9));
		    	 sbAdminAlertStatusVO.setRejectedAgents((String) adminStatistics.get(10));
		    	 sbAdminAlertStatusVO.setRejectedAgents24((String) adminStatistics.get(11));

		    	 sbAdminAlertStatusVO.setApprovedVendors((String) adminStatistics.get(12));
		    	 sbAdminAlertStatusVO.setApprovedVendors24((String) adminStatistics.get(13));
		    	 sbAdminAlertStatusVO.setApprovedClients((String) adminStatistics.get(14));
		    	 sbAdminAlertStatusVO.setApprovedClients24((String) adminStatistics.get(15));
		    	 sbAdminAlertStatusVO.setApprovedAgents((String) adminStatistics.get(16));
		    	 sbAdminAlertStatusVO.setApprovedAgents24((String) adminStatistics.get(17));


		    	 sbAdminAlertStatusVO.setActiveVendors((String) adminStatistics.get(18));
		    	 sbAdminAlertStatusVO.setActiveVendors24((String) adminStatistics.get(19));
		    	 sbAdminAlertStatusVO.setActiveClients((String) adminStatistics.get(20));
		    	 sbAdminAlertStatusVO.setActiveClients24((String) adminStatistics.get(21));
		    	 sbAdminAlertStatusVO.setActiveAgents((String) adminStatistics.get(22));
		    	 sbAdminAlertStatusVO.setActiveAgents24((String) adminStatistics.get(23));


		    	 List adminStatus=new ArrayList();
					OracleCallableStatement stmt1 = (OracleCallableStatement)conn.prepareCall("{? = call ADMINGETSTATUS(?,?)}");
		 			stmt1.registerOutParameter(1,OracleTypes.ARRAY,"SIMPLEARRAY");
		 			stmt1.setString(2,sbAdminAlertStatusVO.getpLogInID());
		 			stmt1.setInt(3,clientId);
		 			stmt1.execute();
		 			ARRAY simpleArray1 = stmt1.getARRAY(1);
		 			String[] values1 = (String[])simpleArray1.getArray();
						 for( int i = 0; i < values1.length; i++ )
							 adminStatus.add(values1[i]);



						  if(adminStatus.size()>0)
						     {

						    	 sbAdminAlertStatusVO.setClosedBids((String) adminStatus.get(0));
						    	 sbAdminAlertStatusVO.setClosedBids24((String) adminStatus.get(1));
						    	 sbAdminAlertStatusVO.setLiveBids((String) adminStatus.get(2));
						    	 sbAdminAlertStatusVO.setLiveBids24((String) adminStatus.get(3));
						    	 sbAdminAlertStatusVO.setCancelledBids((String) adminStatus.get(4));
						    	 sbAdminAlertStatusVO.setCancelledBids24((String) adminStatus.get(5));

						    	 sbAdminAlertStatusVO.setOpenReq((String) adminStatus.get(6));
						    	 sbAdminAlertStatusVO.setOpenPositions((String) adminStatus.get(7));
						    	 sbAdminAlertStatusVO.setOpenReq24((String) adminStatus.get(8));
						    	 sbAdminAlertStatusVO.setOpenPositions24((String) adminStatus.get(9));
						    	 sbAdminAlertStatusVO.setNotStartedReq((String) adminStatus.get(10));
						    	 sbAdminAlertStatusVO.setNotStartedReq24((String) adminStatus.get(11));
						    	 sbAdminAlertStatusVO.setIncompleteReq((String) adminStatus.get(12));
						    	 sbAdminAlertStatusVO.setIncompleteReq24((String) adminStatus.get(13));
						    	 sbAdminAlertStatusVO.setClosedReq((String) adminStatus.get(14));
						    	 sbAdminAlertStatusVO.setClosedPositions((String) adminStatus.get(15));
						    	 sbAdminAlertStatusVO.setClosedReq24((String) adminStatus.get(16));
						    	 sbAdminAlertStatusVO.setClosedPositions24((String) adminStatus.get(17));
						    	 sbAdminAlertStatusVO.setCancelledReq((String) adminStatus.get(18));
						    	 sbAdminAlertStatusVO.setCancelledReq24((String) adminStatus.get(19));
						    	 sbAdminAlertStatusVO.setInProcessReq((String) adminStatus.get(20));
						    	 sbAdminAlertStatusVO.setInProcessPositions((String) adminStatus.get(21));
						    	 sbAdminAlertStatusVO.setInProcessReq24((String) adminStatus.get(22));
						    	 sbAdminAlertStatusVO.setInProcessPositions24((String) adminStatus.get(23));

						    	 sbAdminAlertStatusVO.setInterviewsWaiting((String) adminStatus.get(24));
						    	 sbAdminAlertStatusVO.setInterviewsWaiting24((String) adminStatus.get(25));
						    	 sbAdminAlertStatusVO.setInterviewsScheduled((String) adminStatus.get(26));
						    	 sbAdminAlertStatusVO.setInterviewsScheduled24((String) adminStatus.get(27));

						    	 sbAdminAlertStatusVO.setContractFinalUnScheduled((String) adminStatus.get(28));
						    	 sbAdminAlertStatusVO.setContractFinalUnScheduled24((String) adminStatus.get(29));
						    	 sbAdminAlertStatusVO.setContractFinalScheduled((String) adminStatus.get(30));
						    	 sbAdminAlertStatusVO.setContractFinalScheduled24((String) adminStatus.get(31));

						    	 sbAdminAlertStatusVO.setProfessionalsPlaced((String) adminStatus.get(32));
						    	 sbAdminAlertStatusVO.setProfessionalsPlaced24((String) adminStatus.get(33));
						    	 sbAdminAlertStatusVO.setTimesheets((String) adminStatus.get(34));
						    	 sbAdminAlertStatusVO.setTimesheets24((String) adminStatus.get(35));

						    	 sbAdminAlertStatusVO.setInvoices((String) adminStatus.get(36));
						    	 if(((String) adminStatus.get(37))==null)
						    		 sbAdminAlertStatusVO.setAmount("0");
						    	 else
						    		 sbAdminAlertStatusVO.setAmount((String) adminStatus.get(37));
						    	 sbAdminAlertStatusVO.setInvoices24((String) adminStatus.get(38));
						    	 if(((String) adminStatus.get(39))==null)
						    		 sbAdminAlertStatusVO.setAmount24("0");
						    	 else
						    		 sbAdminAlertStatusVO.setAmount24((String) adminStatus.get(39));


						     }

						  List adminRemainders=new ArrayList();
							 OracleCallableStatement stmt2 = (OracleCallableStatement)conn.prepareCall("{? = call ADMINGETREMAINDERS(?,?)}");
				 			 //Sabarish modified on 21-SEP-2010 for Mantis id 477 Start 
				 			 stmt2.registerOutParameter(1,OracleTypes.ARRAY,"SIMPLEARRAY");
				 			 stmt2.setString(2,sbAdminAlertStatusVO.getpLogInID());
				 			 stmt2.setInt(3,clientId);
				 			 stmt2.execute();
				 			 ARRAY simpleArray2 = stmt2.getARRAY(1);
				 			 String[] values2 = (String[])simpleArray2.getArray();
				 			 for( int i = 0; i < values2.length; i++ )
				 				adminRemainders.add(values2[i]);

				 			  if(adminRemainders.size()>0)
				 		     {
				 		    	 sbAdminAlertStatusVO.setVendorsWaitingForApproval(adminRemainders.get(0).toString());
				 		    	 sbAdminAlertStatusVO.setVendorsWaitingForApproval24(adminRemainders.get(1).toString());
				 		    	 sbAdminAlertStatusVO.setClientsWaitingForApproval( adminRemainders.get(2).toString());
				 		    	 sbAdminAlertStatusVO.setClientsWaitingForApproval24( adminRemainders.get(3).toString());
				 		    	 /*
				 		    	 sbAdminAlertStatusVO.setAgentsWaitingForApproval(adminRemainders.get(4).toString());
				 		    	 sbAdminAlertStatusVO.setAgentsWaitingForApproval24(adminRemainders.get(5).toString());
				 		    	 */
				 		      }
					 			 //Sabarish modified on 21-SEP-2010 for Mantis id 477 end 


	     }
		 connMgr.freeConnection("oracle", conn);
	  	 connMgr.release();
	  	 releaseSession(session);
		}catch(SQLException e){
			e.printStackTrace();
			releaseSession(session);
		}



        sbBatEndLog.endLog(sbBatEndVO);

		return sbAdminAlertStatusVO;


}

public SBAdminAlertStatusVO adminEmailInsert(SBAdminAlertStatusVO sbAdminAlertStatusVO) {


	Session session =getSession();
	Connection con =session.connection();


	SBAutoGen sbAutoGen=new SBAutoGen();
	String login=null;;
	int newkeyGenerated;
	newkeyGenerated = sbAutoGen.getSequenceNumber(session,"E_Mail");

	try{
	PreparedStatement pse1 =con.prepareStatement(adminEMailTableInsert001);

	pse1.setString(1,loginIdGlobal);

	ResultSet qryUseridCheck=pse1.executeQuery();

	if(qryUseridCheck.next()){
		login=qryUseridCheck.getString(1);

	}
	PreparedStatement pse2 =con.prepareStatement(SBAdminEMailTableInsert002);
	pse2.setInt(1,newkeyGenerated);



	pse2.setString(2,sbAdminAlertStatusVO.getmailSubject());
	
	pse2.setInt(3,sbAdminAlertStatusVO.getEMailStatus());
	pse2.setString(4,login);
	pse2.setInt(5,413);


	int i;

	i=pse2.executeUpdate();

	releaseSession(session);
    }
	catch (Exception e) {
		e.printStackTrace();
		releaseSession(session);
	}

	return null;
}


}

/

[Campbell Ritchie]

Yes and no.
You cannot nest a finally inside another finally. You can however nest a try-finally inside a finally. In Java7, they introduced try with resources so as to obviate the need for such strange syntax.

[raj chopra]

Thanks for your reply .

Campbell Ritchie wrote:Yes and no.
You cannot nest a finally inside another finally. You can however nest a try-finally inside a finally. In Java7, they introduced try with resources so as to obviate the need for such strange syntax.

[Campbell Ritchie]

You’re welcome

Please only use the quote button if you are commenting about a particular part of the previous post; in that instance you are simply duplicating it.