Another instanceof type question.

[Mark Spritzler]

OK, I still need that other thread answered for one of my validations.

But for this other one here, It is different I am actually putting in String with instance of so (fieldValue instanceof String)

But what is odd, I have this if statement that is always returning as true, even when it should be false.

def validate(fieldName, fieldValue, max) {
    if ( ! (fieldValue instanceof String) && fieldValue <= max) {
  

So that if is evaluating as true even when fieldValue is of type String. That part should be false.

Can't figure out what I am missing here.

Thanks

Mark

[Gregg Bolinger]

This works for me with Groovy 2.0.5

def validate(fieldName, fieldValue, max) {
    if ( !(fieldValue instanceof String) && fieldValue <= max) {
	  println "W00t"
	}
}

validate("age", 38, 50)

[Mark Spritzler]

Gregg Bolinger wrote:This works for me with Groovy 2.0.5

def validate(fieldName, fieldValue, max) {
    if ( !(fieldValue instanceof String) && fieldValue <= max) {
	  println "W00t"
	}
}

validate("age", 38, 50)

So that wouldn't print W00t because it is of type String. Which is what I want.

To get around this I have to break the if statement into two separate ones.

  def validate(fieldName, fieldValue, max) {
    if (fieldValue instanceof String) {
      if (fieldValue.length() > max) {
        return "${fieldName} length must be less than or equal to ${max}"
      }
    } else {
      if (fieldValue > max) {
        return "${fieldName} must be less than or equal to ${max}"
      }
    }
    return null
  }

And then it works the way I wanted and expected. Thanks for the replies.

Mark