This week's book giveaway is in the Mac OS forum.
We're giving away four copies of a choice of "Take Control of Upgrading to Yosemite" or "Take Control of Automating Your Mac" and have Joe Kissell on-line!
See this thread for details.
The moose likes Java in General and the fly likes Refactor Question Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login


JavaRanch » Java Forums » Java » Java in General
Bookmark "Refactor Question" Watch "Refactor Question" New topic
Author

Refactor Question

Cata Alex
Greenhorn

Joined: Nov 03, 2012
Posts: 1
Hi!
Can anyone help me redesign this part of code or give me some tips? I want it to work the same but to be much easier to read.


Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39100
    
  23
Welcome to the Ranch

How do you ensure that method is called only once? Are you recording when it is called? Are you throwing an Exception if it is called twice?
Why are you not using the clone() method of the array passed? Why not add the array elements to a List, ignoring nulls?
You ought to declare those loop variables in the loop header.
Winston Gutkowski
Bartender

Joined: Mar 17, 2011
Posts: 7896
    
  21

Cata Alex wrote:Can anyone help me redesign this part of code or give me some tips? I want it to work the same but to be much easier to read.

Well the best piece of advice I can give you is to use Lists (java.util.List) instead of arrays. You're writing a lot of code to do things (eg, replace null requirements by empty requirements) that is done automatically by a List class (eg, ArrayList).

Winston


Isn't it funny how there's always time and money enough to do it WRONG?
Articles by Winston can be found here
 
Consider Paul's rocket mass heater.
 
subject: Refactor Question