File APIs for Java Developers
Manipulate DOC, XLS, PPT, PDF and many others from your application.
http://aspose.com/file-tools
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Refactor Question

 
Cata Alex
Greenhorn
Posts: 1
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi!
Can anyone help me redesign this part of code or give me some tips? I want it to work the same but to be much easier to read.


 
Campbell Ritchie
Sheriff
Pie
Posts: 47229
52
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Welcome to the Ranch

How do you ensure that method is called only once? Are you recording when it is called? Are you throwing an Exception if it is called twice?
Why are you not using the clone() method of the array passed? Why not add the array elements to a List, ignoring nulls?
You ought to declare those loop variables in the loop header.
 
Winston Gutkowski
Bartender
Pie
Posts: 9458
49
Eclipse IDE Hibernate Ubuntu
  • 0
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Cata Alex wrote:Can anyone help me redesign this part of code or give me some tips? I want it to work the same but to be much easier to read.

Well the best piece of advice I can give you is to use Lists (java.util.List) instead of arrays. You're writing a lot of code to do things (eg, replace null requirements by empty requirements) that is done automatically by a List class (eg, ArrayList).

Winston
 
It is sorta covered in the JavaRanch Style Guide.
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic