Elevator problem (Statics)

[Alex Munoz]

import java.util.Scanner;

public class Elevator
{
	private int floor;
	private int direction;
	private int elevatorNumber;

	private static int still = 1;
	private static int up = 2;
	private static int down = 3;

	public Elevator()
	{
		floor = 1;
		direction = 1;
		elevatorNumber = 1;
	}

	public void setTargetFloor(int floor)
	{
		Scanner in = new Scanner(System.in);
		System.out.print("Which floor would you like to go to?: ");
		int targetFloor = in.nextInt();

		int direction = Elevator.setDirection();
	}

	private void setDirection()
		{
			if(targetFloor > floor)
			{
				direction = 2;
			}
			else if (targetFloor < floor)
			{
				direction = 3;
			}
			else
			{
				direction = 1;
			}
		}

	public int getDirection()
	{
		return direction;
	}

	public int getCurrentFloor()
	{
		return floor;
	}

	public int getElevatorNum()
	{
		return elevatorNumber;
	}

	public void move()
	{

	}

}

How could I make my code compatible with static context?

I am also getting errors about being unable to find the symbol targetFloor. How could I address that?

I haven't gotten around to setting how the elevator moves, so ignore the last method.

[Maneesh Godbole]

Alex Munoz wrote:
How could I make my code compatible with static context?
I am also getting errors about being unable to find the symbol targetFloor. How could I address that?

Check out http://www.coderanch.com/t/597438/java/java/non-static-variable-totals-cannot, especially the link provided by Jesper in his reply
You have declared targetFloor inside the method setTargetFloor. Because of this, the scope is limited only to that method.

[Jesper de Jong]

Alex Munoz wrote:How could I make my code compatible with static context?

What do you mean by that? Do you get an error message when you try to compile this that has something to do with static?

Alex Munoz wrote:I am also getting errors about being unable to find the symbol targetFloor. How could I address that?

Inside the method setTargetFloor(), on line 24, you declare a local variable named targetFloor. This variable only exists inside the method - it's a local variable.

Inside the method setDirection(), on lines 31 and 35, you're referring to a variable named targetFloor. That variable doesn't exist there.

[Alex Munoz]

Jesper de Jong wrote:

Alex Munoz wrote:How could I make my code compatible with static context?

What do you mean by that? Do you get an error message when you try to compile this that has something to do with static?


Yes, the error says, "non-static method setDirection() cannot be referenced from a static context"

I fixed the error concerning targetFloor

[Campbell Ritchie]

General rule of thumb about things static. If you have a good explanation why something should be static, then it probably should be static. If you haven’t got a good explanation, then making anything static is a serious design error. “It compiles like that,” is a very bad explanation.
Using ints instead of enumerated types, eg direction, is a bad move. It might be permissible in C, but it is not at all good design in Java.

[Winston Gutkowski]

Alex Munoz wrote:How could I make my code compatible with static context?

Easiest is usually to create a object, and then call methods on that object.

I'll bet dollars to doughnuts that the reason you're getting these error messages about 'static context' is because you're trying to call your class methods directly from main(); and that's NOT how you should do things.

As Campbell said, making things static is usually a BAD idea. In the case of main() you have no choice; but you should generally avoid using it anywhere else unless you have a good reason for doing so.

Winston

[Alex Munoz]

I guess I'm confused as to how I implement this. What needs to change?