GUI buttons visible but not functional?

[Rachel Barnes]

Everything appears to be in place and with no errors while open in Eclipse. When I run the program though, it will only let me select ONE of the options on the checkbox buttons, and also the calculate and exit buttons are not working. Where exactly have I gone wrong with this? My instructor mentioned something about making the calculate/exit buttons NOT static, but if I do that, it won't even run and errors pop up everywhere, so I'm pretty confused. The following is the last point where I had no errors, yet had the button issue. All of my other attempts at trying different fixes kind of broke everything, so this is the functional version.

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import java.text.DecimalFormat;



public class svcMaintCalcLaunch {

	/**
	 * Program by Rachel B.
	 */
	public static void main(String[] args) {
		new serviceCalculatorGUI();
	}
}

import java.awt.GridLayout;
import java.awt.LayoutManager;

import javax.swing.BorderFactory;
import javax.swing.ButtonGroup;
import javax.swing.JButton;
import javax.swing.JCheckBox;
import javax.swing.JPanel;
import javax.swing.JToggleButton;


public class autoMaintenanceSvcCalc  extends JPanel {
		public final double OIL_CHANGE = 26.00;
		public final double LUBE_JOB = 18.00;
		public final double RAD_FLUSH = 30.00;
		public final double TRAN_FLUSH = 80.00;
		public final double INSPECTION = 15.00;
		public final double MUFF_REPLACE = 100.00;
		public final double TIRE_ROTATION = 20.00;
		
		private JCheckBox oilChange;
		private JCheckBox lubeJob;
		private JCheckBox radFlush;
		private JCheckBox tranFlush;
		private JCheckBox inspection;
		private JCheckBox muffReplace;
		private JCheckBox tireRotation;
		private ButtonGroup bg;		
		
		public autoMaintenanceSvcCalc() {
			// Constructor!!!!

			//Columns and rows.
			
			setLayout(new GridLayout(5, 2));
			
			//Create panels.
			
			JPanel panel1 = new JPanel();
			JPanel panel2 = new JPanel();
			JPanel panel3 = new JPanel();
			JPanel panel4 = new JPanel();
			JPanel panel5 = new JPanel();
			JPanel panel6 = new JPanel();
			JPanel panel7 = new JPanel();
			JPanel panel8 = new JPanel();
			JPanel panel9 = new JPanel();
			JPanel panel10 = new JPanel();
			
			//Create buttons.
			
			oilChange = new JCheckBox("Oil Change");
			lubeJob = new JCheckBox("Lube Job");
			radFlush = new JCheckBox("Radiator Flush");
			tranFlush = new JCheckBox("Transmission Flush");
			inspection = new JCheckBox("Inspection");
			muffReplace = new JCheckBox("Muffler Replacement");
			tireRotation = new JCheckBox("Tire Rotation");
			serviceCalculatorGUI.calcButton = new JButton("Calculate");
			serviceCalculatorGUI.exitButton = new JButton("Exit");
		
			
			//Border around the panel.
			
			setBorder(BorderFactory.createTitledBorder("Services"));
			
			//Add buttons to panels.
			
			panel1.add(oilChange);
			panel2.add(lubeJob);
			panel3.add(radFlush);
			panel4.add(inspection);
			panel5.add(muffReplace);
			panel6.add(tireRotation);
			panel9.add(serviceCalculatorGUI.calcButton);
			panel10.add(serviceCalculatorGUI.exitButton);
			
			//Add panels to pane.
			
			add(panel1);
			add(panel2);
			add(panel3);
			add(panel4);
			add(panel5);
			add(panel6);
			add(panel7);
			add(panel8);
			add(panel9);
			add(panel10);			
		}

		public double getAutoCost()
		{
			double autoCost = 0.0;
			
			if (oilChange.isSelected())
			    {autoCost = + OIL_CHANGE;}
			else if (lubeJob.isSelected())
				{autoCost = + LUBE_JOB;}
			else if (radFlush.isSelected())
				{autoCost = + RAD_FLUSH;}
			else if (tranFlush.isSelected())
				{autoCost = + TRAN_FLUSH;}
			else if (inspection.isSelected())
				{autoCost = + INSPECTION;}
			else if (muffReplace.isSelected())
				{autoCost = + MUFF_REPLACE;}
			else if (tireRotation.isSelected())
				{autoCost = + TIRE_ROTATION;}
				
				return autoCost;
			
		}
    }

import java.awt.BorderLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;
import java.text.DecimalFormat;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JOptionPane;
import javax.swing.JPanel;

	//GUI.
	
		public class serviceCalculatorGUI extends JFrame
		{

			private JPanel buttonPanel;
			public static JButton calcButton;
			public static JButton exitButton;
			private autoMaintenanceSvcCalc mainPanel;
			
			public serviceCalculatorGUI()
			{
				//Title.
			
			setTitle("Barnes Automotive Calculator");
			
			//Specify an action for the close button.
			
			setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
			
			//Create custom panel.
			
			mainPanel = new autoMaintenanceSvcCalc();
			
			//Create button panel.
			
			buildButtonPanel();
			
			//Add the components to the content pane.
			
			add(mainPanel, BorderLayout.CENTER);
			
			//Pack the contents of the window and display it.
			
			pack();
			setVisible(true);
			}
		
		private void buildButtonPanel()
		{
			buttonPanel = new JPanel();
			
			calcButton = new JButton("Calculate");
			exitButton = new JButton("Exit");
			
			//Register the action listeners.
			
			calcButton.addItemListener(new CalcButtonListener());
			exitButton.addItemListener(new ExitButtonListener());
			
			//Add the buttons to the button panel.
			
			buttonPanel.add(calcButton);
			buttonPanel.add(exitButton);
			
		}
		
	
		//Private class that controls what happens when the 'Calculate' button is clicked.
		
		private class CalcButtonListener implements ItemListener
		{
			public void itemStateChanged(ItemEvent e){
			
				double total;
				mainPanel.getAutoCost();
				total = mainPanel.getAutoCost();
						
			DecimalFormat dollar = new DecimalFormat("0.00");
		
			JOptionPane.showMessageDialog(null, "Total: $" + dollar.format(total));
			}
		}

		//Private class that controls what happens when the 'Exit' button is clicked.
		private class ExitButtonListener implements ItemListener
		{
			public void itemStateChanged(ItemEvent e)
			{
				System.exit(0);
			}			
		}
}

[Jesper de Jong]

Your CalcButtonListener and ExitButtonListener are ItemListeners. Make these ActionListeners instead, if you want to do something when the buttons are clicked.

In lines 235 and 236, use addActionListener instead of addItemListener to add the listeners to the buttons.

[Rachel Barnes]

Jesper de Jong wrote:Your CalcButtonListener and ExitButtonListener are ItemListeners. Make these ActionListeners instead, if you want to do something when the buttons are clicked.

In lines 235 and 236, use addActionListener instead of addItemListener to add the listeners to the buttons.

I changed those and it's still performing no action when I try to click them.

[Campbell Ritchie]

Also I have removed some of the blank space from your code; too much blank space makes it difficult to read. Don’t use tabs. Have a look at our suggestions about indentation.

[Michael Dunn]

you create your buttons in buildButtonPanel
calcButton = new JButton("Calculate");
exitButton = new JButton("Exit");
and add (now) actionListeners to them.

but then in the constructor of autoMaintenanceSvcCalc() you re-create the buttons
serviceCalculatorGUI.calcButton = new JButton("Calculate");
serviceCalculatorGUI.exitButton = new JButton("Exit");

these buttons do not have a listener added to them

comment out the lines
//serviceCalculatorGUI.calcButton = new JButton("Calculate");
//serviceCalculatorGUI.exitButton = new JButton("Exit");
and in the constructor of serviceCalculatorGUI() move
buildButtonPanel();
to before
mainPanel = new autoMaintenanceSvcCalc();

should work now.