How to get row number selected when fireTableDataChanged has occured?

[Jacky Luk]

public class MyTableModel extends DefaultTableModel {

    @Override
    public void setColumnIdentifiers(Vector columnIdentifiers) {
        super.setColumnIdentifiers(columnIdentifiers);
    }

    @Override
    public void setColumnIdentifiers(Object[] newIdentifiers) {
        super.setColumnIdentifiers(newIdentifiers);
    }

    @Override
    public String getColumnName(int column) {
        return super.getColumnName(column);
    }

    @Override
    public void fireTableDataChanged() {
        super.fireTableDataChanged();
        
        // How to get row number and column no here?
        
        
        
    }

    @Override
    public void fireTableStructureChanged() {
        super.fireTableStructureChanged();
    }

    @Override
    public void fireTableRowsInserted(int firstRow, int lastRow) {
        super.fireTableRowsInserted(firstRow, lastRow);
    }

    @Override
    public void fireTableRowsUpdated(int firstRow, int lastRow) {
        super.fireTableRowsUpdated(firstRow, lastRow);
    }

    @Override
    public void fireTableRowsDeleted(int firstRow, int lastRow) {
        super.fireTableRowsDeleted(firstRow, lastRow);
    }

    @Override
    public void fireTableCellUpdated(int row, int column) {
        super.fireTableCellUpdated(row, column);
    }

    @Override
    public void fireTableChanged(TableModelEvent e) {
        super.fireTableChanged(e);
    }

    @Override
    public void addRow(Vector rowData) {
        super.addRow(rowData);
    }

    @Override
    public void addRow(Object[] rowData) {
        super.addRow(rowData);
    }
    
}

[Maneesh Godbole]

I am not sure I understand your question. How is the data change related to selection? Can you please rephrase?

[Jacky Luk]

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package boksspatientanalysis;

import java.util.Vector;
import javax.swing.JComboBox;
import javax.swing.JTextField;
import javax.swing.event.TableModelEvent;
import javax.swing.table.DefaultTableModel;

/**
 *
 * @author Garfield
 */
public class MyTableModel extends DefaultTableModel {

    MyTableModel(Database _db, Object[] _fields)
    {
        db = _db;
        id = (JTextField) _fields[0];
      FirstName = (JTextField) _fields[1];
     LastName = (JTextField) _fields[2];
      HospName = (JComboBox) _fields[3];
        
        
         
    }

    
    @Override
    public void setColumnIdentifiers(Vector columnIdentifiers) {
        super.setColumnIdentifiers(columnIdentifiers);
    }

    @Override
    public void setColumnIdentifiers(Object[] newIdentifiers) {
        super.setColumnIdentifiers(newIdentifiers);
    }

    @Override
    public String getColumnName(int column) {
        return super.getColumnName(column);
    }

    @Override
    public void fireTableDataChanged() {
        super.fireTableDataChanged();
        
        
        
    }

    @Override
    public boolean isCellEditable(int row, int column) {
        //return super.isCellEditable(row, column);
        return true;
    }

    @Override
    public void fireTableStructureChanged() {
        super.fireTableStructureChanged();
    }

    @Override
    public void fireTableRowsInserted(int firstRow, int lastRow) {
        super.fireTableRowsInserted(firstRow, lastRow);
    }

    @Override
    public void fireTableRowsUpdated(int firstRow, int lastRow) {
        super.fireTableRowsUpdated(firstRow, lastRow);
        
         
        
    }

    @Override
    public void fireTableRowsDeleted(int firstRow, int lastRow) {
        super.fireTableRowsDeleted(firstRow, lastRow);
    }

    @Override
    public void fireTableCellUpdated(int row, int column) {
        super.fireTableCellUpdated(row, column);
        // Update TextFields
        
        
        // Update Database
        Object[] savedValues = new Object[4];
        // Patient ID
        savedValues[0] = this.getValueAt(row, 0);
        // First Name
        savedValues[1] = this.getValueAt(row, 1).toString();
        
        // Last Name
        savedValues[2] = this.getValueAt(row, 2).toString();
        // Hosptial Name
        savedValues[3] = db.getHospitalID(this.getValueAt(row,  3).toString());
        
        id.setText(savedValues[0].toString());
        FirstName.setText(savedValues[1].toString());
        LastName.setText(savedValues[2].toString());
        HospName.setSelectedIndex((int)savedValues[3]);
        
        db.updatePatientData(savedValues);
        
    }

    @Override
    public void fireTableChanged(TableModelEvent e) {
        super.fireTableChanged(e);
    }

    @Override
    public void addRow(Vector rowData) {
        super.addRow(rowData);
    }

    @Override
    public void addRow(Object[] rowData) {
        super.addRow(rowData);
    }
    
    
    private static Database db;
    private static JTextField id;
    private static JTextField FirstName;
    private static JTextField LastName;
    private static JComboBox HospName;
    
     
    
}

 Object[] textFields = new Object[4];
         
         textFields[0] = jTextPatientID;
         textFields[1] = jTextFirstName;
         textFields[2] = jTextLastName;
         textFields[3] = jComboHospName;
         
         model = new MyTableModel(db, textFields);
         
         jTable1.setModel(model);

public void fireTableCellUpdated(int row, int column) wasn't called when an update is initiated.

[Jacky Luk]

Maneesh Godbole wrote:I am not sure I understand your question. How is the data change related to selection? Can you please rephrase?

Hi Maneesh,
I believe I am using the wrong "fire" method, I should be using fireTableCellUpdated, however, it isn't called when an update event occurs

[Maneesh Godbole]

Jack Luk wrote:

Maneesh Godbole wrote:I am not sure I understand your question. How is the data change related to selection? Can you please rephrase?

Hi Maneesh,
I believe I am using the wrong "fire" method, I should be using fireTableCellUpdated, however, it isn't called when an update event occurs

I still don't understand where the selection comes into the picture.

[Jacky Luk]

Maneesh Godbole wrote:

Jack Luk wrote:

Maneesh Godbole wrote:I am not sure I understand your question. How is the data change related to selection? Can you please rephrase?

Hi Maneesh,
I believe I am using the wrong "fire" method, I should be using fireTableCellUpdated, however, it isn't called when an update event occurs

I still don't understand where the selection comes into the picture.

Hi Maneeh,
Actually, There are 3 JTextFields, Patient ID, Patient First Name, Patient Last Name and one combo box called Hospital Name that displays individual patient's details
And there is a table that displays the whole table information
When a user selects a row on the table, the JTextfields will be updated.
Thanks
Jack

[Maneesh Godbole]

Jack Luk wrote:
When a user selects a row on the table, the JTextfields will be updated.

So why are you firing the table change? You should be listening to the table selection.
Recommended reading http://docs.oracle.com/javase/tutorial/uiswing/components/table.html#selection

If this is not what you meant, please post your SSCCE code which clearly demonstrates your problem.

[Jacky Luk]

 private class RowListener implements ListSelectionListener {
        
        // Any CRUD will call
        public void valueChanged(ListSelectionEvent event) {
            if (event.getValueIsAdjusting()) {
                return;
            }
           
            outputSelection();
        }
    }
 private void outputSelection() {
    
        int row = jTable1.getSelectedRow();
        int column = jTable1.getSelectedColumn();
        DefaultTableModel model = (DefaultTableModel) jTable1.getModel(); 
        jTextPatientID.setText(model.getValueAt(row, 0).toString());
        jTextFirstName.setText(model.getValueAt(row, 1).toString());
        jTextLastName.setText(model.getValueAt(row,2).toString());
        jComboHospName.setSelectedIndex(db.getHospitalID((String)model.getValueAt(row,3)));
        
        Object[] savedValues = new Object[4];
        
        savedValues[0] = String.valueOf(jTextPatientID.getText());
        savedValues[1] = jTextFirstName.getText();
        savedValues[2] = jTextLastName.getText();
        savedValues[3] = db.getHospitalID(jComboHospName.getSelectedItem().toString());
        
        db.updatePatientData(savedValues);
    }   

Hello, I am getting there. But 2 mistakes I have made, since there is a "delete" button available, when I click on it, the row will be deleted instantly, afterwards, this rowlistener will be invoked.
Since all CRUDs is a valueChanged activity, outputSelection will be called each time a CRUD starts, 2 problems, first is the row is deleted, it is no longer available in the table, there will be a arrayindexoutofbounds
Exception thrown, also, not all activities are update activities, db.updatePatientData(savedValues) should not be there too.
Any insights?
Thanks
Jack

[m Korbel]

- all your posts here about to create DefaultTableModel is wrong, all these methods are implemented and correctly, no idea, no reason to override that

- never to call fireXxxXxx for DefaultTableModel, these methods are implemented and correctly

- for why reason you override public void addRow(Vector rowData) { and public void addRow(Object[] rowData) { inside one XxxTableModel

- you are using these Object wrong

- (even model is created before) you called DefaultTableModel model = (DefaultTableModel) jTable1.getModel(); in outputSelection() { then you have to lost reference betweens GUI and model

- even valueChanged() from ListSelectionListener fired the proper event, Id be to test if (row> -1)

- have to change ListSelectionModel to SINGLE_Xxx, then isnt possible to select more than one row

- database whatever (db.updatePatientData(savedValues);) must be based on PrepareStatement

- be sure that PrepareStatement.close() (in finally block), otherwise these Object never gone from JVM memory, nor GC'ed

[Jacky Luk]

Hello I am back, when I press the delete button, the following things happen
1) RowListener invoked
2) Delete actionListener invoked
3) removeRow invoked
4) RowListener invoked again

    public bokss_patient_frame(Database _db) {
        initComponents();
          this.setExtendedState(getExtendedState()|this.MAXIMIZED_BOTH);

         db = _db;
         
         jTable1.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
        jTable1.getSelectionModel().addListSelectionListener(new RowListener());
  
         
        header = jTable1.getTableHeader();
        header.setUpdateTableInRealTime(true);
        //header.addMouseListener(jTable1Model.new ColumnListener(jTable1));
        header.setReorderingAllowed(true);
        
        jTable1.setAutoCreateRowSorter(true);
        jTable1.putClientProperty("terminateEditOnFocusLost", true);
        
        timer = new Timer(FAST, new ActionListener() {

            Object[] newData = new Object[3];

            @Override
            public void actionPerformed(ActionEvent e) {
                   db.uploadData();
            }
        });
        
        timer.start();
        
        db.displayData(this);
        
        model = (DefaultTableModel) jTable1.getModel();
  }

 private class RowListener implements ListSelectionListener {
        
        // Any CRUD will call
        public void valueChanged(ListSelectionEvent event) {
            if (event.getValueIsAdjusting()) {
                return;
            }
           
            outputSelection();
        }
    }
    
    
      
    private void outputSelection() {
    
        int row = jTable1.getSelectedRow();
        int column = jTable1.getSelectedColumn();
        
        System.out.println ("Updating row  "+row);
         
        jTextPatientID.setText(model.getValueAt(row, 0).toString());
        jTextFirstName.setText(model.getValueAt(row, 1).toString());
        jTextLastName.setText(model.getValueAt(row,2).toString());
        jComboHospName.setSelectedItem(model.getValueAt(row,3).toString());
        
      /*  Object[] savedValues = new Object[4];
        
        savedValues[0] = String.valueOf(jTextPatientID.getText());
        savedValues[1] = jTextFirstName.getText();
        savedValues[2] = jTextLastName.getText();
        savedValues[3] = db.getHospitalID(jComboHospName.getSelectedItem().toString());
        
        db.updatePatientData(savedValues);*/
    }   
 

    private void jButtonDeleteActionPerformed(java.awt.event.ActionEvent evt) {                                              
        // TODO add your handling code here:
     
        int id = (int) model.getValueAt(jTable1.getSelectedRow(), 0);
        
        int row = jTable1.getSelectedRow();
       
        Vector dataToDelete = model.getDataVector();
        
        System.out.println("deleting row " + row);        
       
        
        model.removeRow(row);
        
        db.deletePatient(id);
        jTable1.repaint();
        
         
    }                                             

Result:
Connected!
Updating row 4
deleting row 4
Updating row -1
Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: -1
at java.util.Vector.elementData(Vector.java:730)
at java.util.Vector.elementAt(Vector.java:473)

I found the program has an execution sequence problem. Any insights? The updating process has been done twice
However, I'd like to keep the RowListener as I want to update the table interactively.
Thanks
Jack

[Ranganathan Kaliyur Mannar]

First of all, when you want to delete a row, you should update the 'model' by removing the row and then fire the appropriate method to notify the table rather than repaint it.
Since you are extending DefaultTableModel, you can call the removeRow() method of the model to do this (the removeRow automatically calls the fireXXX method to notify the table).

Secondly, you should also consider the functional aspect when you delete a row. A row is selected and you click the delete button. Now, after the row is deleted, what should happen with the selection? should the next row get selected? should the previous row get selected? what happens in case the deleted row is first/last in the table?

I think when a row is deleted, the selection is lost. So, the getSelectedRow() returns -1 which is what is happening in your case. So, you should simply add an if condition in your outputSelection() method to handle this.