oracle connection

[haritha hari]

My Action class code is :

package action;

import ActionForm.RadioTagActionForm;
import newpack.dbconn;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionForward;

public class RadioTagAction extends Action {
 
 private final static String SUCCESS = "success";
  
 public ActionForward execute(ActionMapping mapping, ActionForm  form,
  HttpServletRequest request, HttpServletResponse response)
  throws Exception {
  
  if(form!=null){
  
 RadioTagActionForm radiaTagActionForm=(RadioTagActionForm)form;

 dbconn con=new dbconn();
 con.cone();


 System.out.println("User Name : "+radiaTagActionForm.getname());

 System.out.println("Password : "+radiaTagActionForm.getpwd());

  }  
  return mapping.findForward(SUCCESS);
  
  }
}

And databse connection code is :

package newpack;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.sql.*;

import action.RadioTagAction;
import java.sql.DriverManager;

public class dbconn {
   public void cone()
   {
	try
    {
    Connection Conn;	 
    Statement stmt;
   
	
  	  Class.forName("Oracle.jdbc.driver.OracleDriver");
  	  Conn = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:XE","SYSTEM","abcd");
  	  stmt = Conn.createStatement();     
      ResultSet rs = stmt.executeQuery("insert into reg values('name','pwd')");	
  	  System.out.println("ROW INSERTED.......");
  	  rs.next();	 
  	  rs.close();
    }
    catch(Exception e)
    {
  	  
    }
   } 
}

Is there Any wrong in code for oracle dabtabse connection using struts...

Thanq

[Joe Ess]

Welcome to the JavaRanch.
I added code tags to your post. Code tags make your code easier to read so please use them in the future.
As for your code, never ever Ever EVER do this:

    catch(Exception e)  
    {  
        
    }  

If something were wrong with your code, you would never know. At a bare minimum, invoke e.printStackTrace().

[haritha hari]

Sorry for not using code tags...
Thanq for your reply.....

[haritha hari]

ResultSet rs = stmt.executeQuery("insert into reg values('name','pwd')");

In above code oracle database takes name and pwd as column vallues

but i want to insert values in that name and pwd


For this problem what should i do..?

please tell me...

Thanq

[Joe Ess]

What error are you getting?

[haritha hari]

I am not getting error..

And output is in correct....

[jatan bhavsar]

Hi Haritha,

How will you get the name and pwd filed ?? you need to pass name pwd value from somewhere.

Regards
Jatan

[Joe Ess]

Are you printing out the exception? If there were an error, that is where it would be reported.

[haritha hari]

Yes i am printing the statement in catch block.

It does not show any error..

The Output where i am getting wrong is

ResultSet rs = stmt.executeQuery("insert into reg values('name','pwd')");  

After this line execution the row will be inserted in reg.

The row that was inserted is incorrect.

Insted of inserting values in name and pwd in reg table.

It takes name and pwd it self as row values..

This is the problem
please tell me the solution..
please

Thanq

[haritha hari]

I am getting name and pwd fields using the code... from action class

var name=radiaTagActionForm.getname();
var pwd=radiaTagActionForm.getpwd();

[Joe Ess]

haritha hari wrote:

Insted of inserting values in name and pwd in reg table.

It takes name and pwd it self as row values..

That's exactly what you are telling it to do. How would you create a string that contains the values of name and pwd?

[haritha hari]

The lines i wrote in action class

for name and pwd is as follows

var name=radiaTagActionForm.getname();  
var pwd=radiaTagActionForm.getpwd(); 
 

[Joe Ess]

That's great. Now how do you create a string that contains those values?

[haritha hari]

Sorry i didnt get u...?

[Joe Ess]

Perhaps you should spend some time reading the Java Tutorial. You are going to find it very difficult to use Struts unless you know the basics of how to use Java.

[haritha hari]

I am having minimum knowledge on java

Mean while the problem is solved and the action code is as follows...

package action;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.Statement;

import ActionForm.RadioTagActionForm;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionForward;

import com.sun.org.apache.regexp.internal.RE;

public class RadioTagAction extends Action {
 
 private final static String SUCCESS = "success";
  
 public ActionForward execute(ActionMapping mapping, ActionForm  form,
  HttpServletRequest request, HttpServletResponse response)
  throws Exception {
	 int cnt=0;
  if(form!=null){
  
 RadioTagActionForm radiaTagActionForm=(RadioTagActionForm)form;
 System.out.println("User Name : "+radiaTagActionForm.getname());

 System.out.println("Password : "+radiaTagActionForm.getpwd());
 
 
  try
  {
  Connection Conn;	 
	
	  Class.forName("oracle.jdbc.driver.OracleDriver");
	  Conn = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:XE","ki2","ki2");
      String str="insert into reg values(?,?)";
	  PreparedStatement rs = Conn.prepareStatement(str);
      rs.setString(1,radiaTagActionForm.getname());
	 
      rs.setString(2,radiaTagActionForm.getpwd());
      ResultSet rs1= rs.executeQuery();
      System.out.println("ROW INSERTED.......");
   
  }
  catch(Exception e)
  {
  	e.printStackTrace();
    System.out.println(e);
  } 

 }  
 return mapping.findForward(SUCCESS);
  
 }
}

Ok

thanq....