I Just Want One Method

[Gary Lineker]

Greetings all. Beginner here struggling with a school project. The problem areas I have highlighted in red within the Java program. For the modules that I am struggling with, you will notice I have created four four calling statements each referring to a separate module:

verbalSum = calcVerbalSum (verbalSum, verbalScore);
scienceSum = calcScienceSum (scienceSum, scienceScore);
mathSum = calcMathSum (mathSum, mathScore);
logicSum = calcLogicSum (logicSum, logicScore);

The modules look like this:

public static int calcVerbalSum (int verbalSum, int verbalScore)
		{
			verbalSum += verbalScore;
			return verbalSum;		
		}
public static int calcScienceSum (int scienceSum, int scienceScore)
		{
			scienceSum += scienceScore;
			return scienceSum;		
		}
		public static int calcMathSum (int mathSum, int mathScore)
		{
			mathSum += mathScore;
			return mathSum;		
		}
		public static int calcLogicSum (int logicSum, int logicScore)
		{
			logicSum += logicScore;
			return logicSum;		
		}

Essentially I need to calculate the sums for each of these but I need to do it within one module called calculateSubjectSum. My brain has really shut down and although I'm convinced it's something really glaring, for the life of me I'm stumped. Thank you!

import java.util.Scanner;
public class ProgramThree
{
	public static void main(String[]args) // this is the executable method; they are all part of the same class.
	{
		Scanner input = new Scanner (System.in);
		int count = 0, verbalScore, scienceScore, mathScore,
                 logicScore, verbalSum=0, scienceSum=0, mathSum=0, logicSum=0;
		String stuID;
		boolean dataValid;
		double stuAvg, verbalAvg, scienceAvg, mathAvg, logicAvg;
		
		while (count < 5)
		{
			System.out.println("Enter Student ID then press ENTER.");
			stuID = input.next();
			
			System.out.println("Enter verbal test score between 0-100 then press ENTER.");
			verbalScore = input.nextInt();
			
			System.out.println("Enter science test score between 0-100 then press ENTER.");
			scienceScore = input.nextInt();
			
			System.out.println("Enter math test score between 0-100 then press ENTER.");
			mathScore = input.nextInt();
			
			System.out.println("Enter logic test score between 0-100 then press ENTER.");
			logicScore = input.nextInt();
			count ++;
			
// Send to validateData module now. The values are what the method needs (the "in" versus the "out)...
			
			dataValid = validateData (verbalScore, scienceScore, mathScore, logicScore);
			if (dataValid == true)
			{
				stuAvg = CalcIndAvg (verbalScore, scienceScore, mathScore, logicScore);
                      // Send to calcIndAvg module now...
				verbalSum = calcVerbalSum (verbalSum, verbalScore);
				scienceSum = calcScienceSum (scienceSum, scienceScore);
				mathSum = calcMathSum (mathSum, mathScore);
				logicSum = calcLogicSum (logicSum, logicScore);
				writeStudentInformation (stuID, stuAvg);
                             // Remember, no values being returned
			}
			
		} // end while loop
		verbalAvg = verbalSum / count;
		scienceAvg = scienceSum / count;
		mathAvg = mathSum / count;
		logicAvg = logicSum / count;
		System.out.println("Verbal test score average:" + verbalAvg);
		System.out.println("Science test score average:" + scienceAvg);
		System.out.println("Math test score average:" + mathAvg);
		System.out.println("Logic test score average:" + logicAvg);
	} // end main
	
	public static boolean validateData (
                  int verbalScore, int scienceScore, int mathScore, int logicScore)
		{
			boolean isValid = true; // local variable; call it what you want
			if (verbalScore < 0 || verbalScore > 100)
			{
			System.out.println("Verbal score is not in range 0-100.");
			isValid = false;
			}
			if (scienceScore < 0 || scienceScore > 100)
			{
				System.out.println("Science score is not in range 0-100.");
				isValid = false;
			}
			if (mathScore < 0 || mathScore > 100)
			{
				System.out.println("Math score is not in range 0-100.");
				isValid = false;
			}
			if (logicScore < 0 || logicScore > 100)
			{
				System.out.println("Logic score is not in range 0-100.");
				isValid = false;
			} 
			return isValid;
		}
	
		public static double CalcIndAvg (
                           int verbalScore, int scienceScore, int mathScore, int logicScore)
		{ // every method has a double brace, even if only one statement
			double stuAvg;
                       // average has only been assigned in Main; we need LOCAL VARIABLE here too
			stuAvg = (verbalScore + scienceScore + mathScore + logicScore) / 4.0;
			return stuAvg; // value that goes back to main		
		} // end CalcIndAvg
		
		public static int calcVerbalSum (int verbalSum, int verbalScore)
		{
			verbalSum += verbalScore;
			return verbalSum;		
		}
		
		public static int calcScienceSum (int scienceSum, int scienceScore)
		{
			scienceSum += scienceScore;
			return scienceSum;		
		}
		
		public static int calcMathSum (int mathSum, int mathScore)
		{
			mathSum += mathScore;
			return mathSum;		
		}
		
		public static int calcLogicSum (int logicSum, int logicScore)
		{
			logicSum += logicScore;
			return logicSum;		
		}
		
		
		public static void writeStudentInformation (String stuID, double stuAvg)
               // if it's not returning any values it's void
		{
			System.out.println ("Student ID: " + stuID +
                                      "\nStudent individual average: " + stuAvg + "\n");
		}
		
} // end class

[Greg Charles]

First, please use code tags. The make code much easier to read. Second, when posting code, less is more. Try to narrow the code sample down as much as you can and still have a complete example that demonstrates the problem.

I'm not clear on what you mean by module in this example. I do notice that your four methods all do exactly the same thing. They just have different names and different parameters names. So maybe what you mean by only one module is that you want only one method. Something like

int calculateSubjectSum(int sum, int score) {...}

You can call that method four times, passing in the same parameters you pass into the four differently-named methods now, and you'll get the same results. If that's not it, then what problem are you having exactly?

[Rajdeep Biswas]

Greg Charles wrote:Something like

int calculateSubjectSum(int sum, int score) {...}

You can call that method four times, passing in the same parameters you pass into the four differently-named methods now, and you'll get the same results. If that's not it, then what problem are you having exactly?

Ponder Mr. Linekar. I think this is the solution considering your module means a method.

[Campbell Ritchie]

Gary Lineker wrote: . . . . The problem areas I have highlighted in red within the Java program. . . .

No, you haven’t. Colour tags don’t work inside code tags, so I shall delete them.

[Winston Gutkowski]

Greg Charles wrote:Something like

int calculateSubjectSum(int sum, int score) {...}

Actually, my suggestion would be:

int calculateSum(int... values) { ... // Note the 'int...'

What that does is to take an array of (or several individual) values and calculate their sum; and it's properly decoupled.

@Gary: What your method is doing is not summing, it's accumulating; and that's very difficult to do in a loosely coupled way.

And, whatever you do decide on, don't forget that an int that is the sum of several other int's might overflow.

Winston