file delete mistake

[thejwal pavithran]

case 3:
BufferedReader removalReader = new BufferedReader(new FileReader(contactBookName)); // opening a stream 
String name2 = "";
String line2 = "";
String nameRemoved = "";
String finalString = "";
      			
System.out.println("\nENTER THE NAME TO BE REMOVED");
nameRemoved = stringReader.nextLine();
       			
while(((line2=removalReader.readLine())!=null))	 // read till end of file
{
    String s = line2.substring(0,line2.indexOf('='));	// add each name that exists in the file
    if(!nameList.contains(s))
    {
        nameList.add(s);
    }
}
if(!nameList.contains(nameRemoved))
{
    System.out.println("\nA CONTACT WITH NAME "+nameRemoved+" DOES NOT EXIST\n");
}
else
{
    removalReader = new BufferedReader(new FileReader(contactBookName)); //make buffered reader point back to beginning of file.
       				
    while((line2=removalReader.readLine())!=null)
    {
        name2 = line2.substring(0,line2.indexOf("="));
       	if(!name2.equals(nameRemoved))
       	{
       	    finalString = finalString+line2+System.getProperty("line.separator");
       	}
     }
       				
     BufferedWriter removalWriter = new BufferedWriter(new FileWriter(contactBookName)); //used to write into file
     removalWriter.write(finalString);
     removalWriter.close();   // close writer
     System.out.println("CONTACT "+nameRemoved+" REMOVED ");
     removalReader.close();  //close reader
}
removalReader.close(); //close reader
break;

hi guys the above snippet is only a relevant part of the program..if a user presses 3 then some contents of a file are removed based on some conditions.

This portion works fine .
But the problem arises when an attempt is made to delete the same file in another function. The files which are made to go through the operations in case 3 dont get deleted in another function..is the closing of the streams not done properly? please help..

To make the same BufferedReader point to the beginning of a file, re initialization is done as below:

removalReader = new BufferedReader(new FileReader(contactBookName));

is this proper?

[Paul Clapham]

thejwal pavithran wrote:
To make the same BufferedReader point to the beginning of a file, re initialization is done as below:

removalReader = new BufferedReader(new FileReader(contactBookName));

is this proper?

But that isn't the same BufferedReader. It's a new one (that's what the "new" keyword means). And no, creating a new BufferedReader and a new FileReader on a file won't close any other BufferedReaders and FileReaders which also use that file.

[thejwal pavithran]

Paul Clapham wrote:

thejwal pavithran wrote:
To make the same BufferedReader point to the beginning of a file, re initialization is done as below:

removalReader = new BufferedReader(new FileReader(contactBookName));

is this proper?

But that isn't the same BufferedReader. It's a new one (that's what the "new" keyword means). And no, creating a new BufferedReader and a new FileReader on a file won't close any other BufferedReaders and FileReaders which also use that file.

thank you for pointing that out...i forgot the basic concept of object reference here..sorted it out....so now i know that all streams related to a file have to be closed before file deletion...is there any such any other such conditions that have to be taken care of?