Passing Value from Scanner Class to Class Constructor

[Nigel Foley]

Hi All,

I am new to this forum/java programming so I apologise in advance if I explain this incorrectly

I have a main method that takes values from the scanner and passes them to the customer object

public static void main(String[] args) {

		Scanner stdin = new Scanner(System.in);

		System.out
				.println("Welcome to ACME Login Application\n\n ");
		System.out.println("Please enter the Customers Name\n");
		String s1 = stdin.next();
		System.out.println("Please enter a password for the customer\n");
		String s2 = stdin.next();
		System.out.println("Please enter in a loginID for the user\n");
		String s3 = stdin.next();

		Customer cust = new Customer(s1, s2, s3, false);

		System.out.println(cust.toString());

	}

}

When I run this code the customer object is instantiated but it is set to default field values and not to the values that are picked up by the scanner.
I have found a similar thread http://www.coderanch.com/t/408970/java/java/passing-arguments-constructor
but don't quite understand what is going on.

I would really appreciate it, if somebody could spare time to have a look and help me out

Thanks
Nigel

I have attached the associated Customer code below in case it is needed.

public class Customer extends User {

	// Class variable used to create a unique customer number
	// Initial seed value set to 1024,
	private static int customerCounter = 1024;

	private int customerID = 0;
	
	public Customer() {
		super();
	}

	public Customer(String userName, String userPassword, String userLoginID,
			boolean userAccoutLocked) {
		super(userPassword, userPassword, userLoginID, userAccoutLocked);
		customerID = ++customerCounter;
	}

	public void setCustomerID(int customerID){
		this.customerID = customerID;
	}
	
	public int getCustomerID(){
		return customerID;
	}

	@Override
	public String toString() {
		return "Customer [customerID=" + customerID + ", toString()="
				+ super.toString() + "]";
	}
	

}

public class User {

	private String name;
	private String password;
	private String loginID;
	private boolean accountLocked;

	public User() {
	}

	public User(String userName, String userPassword, String userLoginID,
			boolean userAccountLocked) {
		userName = name;
		userPassword = password;
		userLoginID = loginID;
		userAccountLocked = accountLocked;
	}

	public void setName(String userName) {
		userName = name;
	}

	public String setName() {
		return name;
	}

	public void setPassword(String userPassword) {
		userPassword = password;
	}

	public String getPassword() {
		return password;
	}

	public void setLoginID(String userLoginID) {
		userLoginID = loginID;
	}

	public String setLoginID() {
		return loginID;
	}

	public void setAccountLocked(boolean userAccountLocked) {
		userAccountLocked = accountLocked;
	}

	@Override
	public String toString() {
		return "User [name=" + name + ", password=" + password + ", loginID="
				+ loginID + ", accountLocked=" + accountLocked + "]";
	}
}

[Henry Wong]

First, it will help if you added some code tags... like so...

Nigel Foley wrote:

public static void main(String[] args) {

		Scanner stdin = new Scanner(System.in);

		System.out
				.println("Welcome to ACME Login Application\n\n ");
		System.out.println("Please enter the Customers Name\n");
		String s1 = stdin.next();
		System.out.println("Please enter a password for the customer\n");
		String s2 = stdin.next();
		System.out.println("Please enter in a loginID for the user\n");
		String s3 = stdin.next();

		Customer cust = new Customer(s1, s2, s3, false);

		System.out.println(cust.toString());

	}
}

public class Customer extends User {

	// Class variable used to create a unique customer number
	// Initial seed value set to 1024,
	private static int customerCounter = 1024;

	private int customerID = 0;
	
	public Customer() {
		super();
	}

	public Customer(String userName, String userPassword, String userLoginID,
			boolean userAccoutLocked) {
		super(userPassword, userPassword, userLoginID, userAccoutLocked);
		customerID = ++customerCounter;
	}

	public void setCustomerID(int customerID){
		this.customerID = customerID;
	}
	
	public int getCustomerID(){
		return customerID;
	}

	@Override
	public String toString() {
		return "Customer [customerID=" + customerID + ", toString()="
				+ super.toString() + "]";
	}
	

}

public class User {

	private String name;
	private String password;
	private String loginID;
	private boolean accountLocked;

	public User() {
	}

	public User(String userName, String userPassword, String userLoginID,
			boolean userAccountLocked) {
		userName = name;
		userPassword = password;
		userLoginID = loginID;
		userAccountLocked = accountLocked;
	}

	public void setName(String userName) {
		userName = name;
	}

	public String setName() {
		return name;
	}

	public void setPassword(String userPassword) {
		userPassword = password;
	}

	public String getPassword() {
		return password;
	}

	public void setLoginID(String userLoginID) {
		userLoginID = loginID;
	}

	public String setLoginID() {
		return loginID;
	}

	public void setAccountLocked(boolean userAccountLocked) {
		userAccountLocked = accountLocked;
	}

	@Override
	public String toString() {
		return "User [name=" + name + ", password=" + password + ", loginID="
				+ loginID + ", accountLocked=" + accountLocked + "]";
	}
}

[Henry Wong]

Nigel Foley wrote:Hi All,

I am new to this forum/java programming so I apologise in advance if I explain this incorrectly

I have a main method that takes values from the scanner and passes them to the customer object

...

When I run this code the customer object is instantiated but it is set to default field values and not to the values that are picked up by the scanner.
I have found a similar thread http://www.coderanch.com/t/408970/java/java/passing-arguments-constructor
but don't quite understand what is going on.

I would really appreciate it, if somebody could spare time to have a look and help me out

Thanks
Nigel

Hint: take a look at the constructor of your user class...

public class User {

	private String name;
	private String password;
	private String loginID;
	private boolean accountLocked;

	public User(String userName, String userPassword, String userLoginID,
			boolean userAccountLocked) {
		userName = name;
		userPassword = password;
		userLoginID = loginID;
		userAccountLocked = accountLocked;
	}
}

What is it that you are attempting to do?? (hint: it is not what you think it is)


And BTW, welcome to the ranch.

Henry

[Nigel Foley]

Hi Henry,

Thanks for pointing me in the right direction, I changed up the constructor to use the 'this' keyword(now I reference the current object) and everything work fine.

Nigel