unable to send an email and update Database at a time

[Rakesh Keerthi]

Hi,

I've the below code in my servlet for updating database.

try{
        String a=request.getParameter("abc");   
        PreparedStatement ps=con.prepareStatement("Update Scope_Demo SET WL_Verif='"+t+"' where DBID='"+a+"'");
        int i=ps.executeUpdate();
        if(i==1)
                       {

            System.out.print("Done");
        }
        else
                                  {
            System.out.println("Err");
        }
        }
        catch(Exception e)
                               {
            System.out.println(e);
        }

and the below for sending E-Mail

package Mail_M;

import java.io.IOException;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.util.Properties;
import javax.mail.*;
import javax.mail.internet.AddressException;
import javax.mail.internet.InternetAddress;
import javax.mail.internet.MimeMessage;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

public class WlVerif extends HttpServlet {

        java.util.Date today = new java.util.Date();
        java.sql.Timestamp t= new java.sql.Timestamp(today.getTime());
        Connection con=null;
    protected void processRequest(HttpServletRequest request, 
                                  HttpServletResponse response)
                   throws IOException, ServletException {

        final String err = "/error.jsp";
        final String succ = "/success.jsp";
String a=request.getParameter("abc");
        String from = "[e-mail]";
        String to = "[e-mail]";
        String subject = request.getParameter("subject");
        String message = request.getParameter("message");
        String login = request.getParameter("login");
        String password = request.getParameter("password");

        try {
            Properties props = new Properties();
            props.setProperty("mail.host", "relay.westlan.com");
            props.setProperty("mail.smtp.port", "25");
            props.setProperty("mail.smtp.auth", "true");
            props.setProperty("mail.smtp.starttls.enable", "true");

            Authenticator auth = new WlVerif.SMTPAuthenticator(login, password);

            Session session = Session.getInstance(props, auth);

            MimeMessage msg = new MimeMessage(session);
            msg.setText(message);
            msg.setSubject(subject);
            msg.setFrom(new InternetAddress(from));
            msg.addRecipient(Message.RecipientType.TO, new InternetAddress(to));
            Transport.send(msg);

        } catch (AuthenticationFailedException ex) {
            request.setAttribute("ErrorMessage", "Authentication failed");

            RequestDispatcher dispatcher = request.getRequestDispatcher(err);
            dispatcher.forward(request, response);

        } catch (AddressException ex) {
            request.setAttribute("ErrorMessage", "Wrong email address");

            RequestDispatcher dispatcher = request.getRequestDispatcher(err);
            dispatcher.forward(request, response);

        } catch (MessagingException ex) {
            request.setAttribute("ErrorMessage", ex.getMessage());

            RequestDispatcher dispatcher = request.getRequestDispatcher(err);
            dispatcher.forward(request, response);
        }
            RequestDispatcher dispatcher = request.getRequestDispatcher(succ);
            dispatcher.forward(request, response);

    }

    private class SMTPAuthenticator extends Authenticator {

        private PasswordAuthentication authentication;

        public SMTPAuthenticator(String login, String password) {
            authentication = new PasswordAuthentication(login, password);
        }

        @Override
        protected PasswordAuthentication getPasswordAuthentication() {
            return authentication;
        }
    }

    @Override
    protected void doGet(HttpServletRequest request, 
                         HttpServletResponse response)
                   throws ServletException, IOException {
        processRequest(request, response);
    }

these servlets are working fine when i use them separately, but when i use them combined by putting the first one in post and the second one in get methods it is giving me output as "Err"(the one i defined for updating the data).

could you please help me how do i get these things work.

the jsp i used is as below.

<%@include file="DBCon.jsp"%>
<html>
    <body>
        <table>
        <%try{
            String a=(String)session.getAttribute("myusername");
            ps=con.prepareStatement("Select DBID from Scope1 where Count1=1 AND WL_VERIF IS NULL");
            rs=ps.executeQuery();
            while(rs.next())
    {       %> <tr><td><b>Pending for Westlaw Verification </b></td><td></td></tr>  <%
    %>

        <tr>
                <form action="WestLaw_Verif.jsp" method="post">
                    <td><input type="text" id="abc" name="abc" value="<%=rs.getString("DBID")%>" size="100"></td>
                    <td><input type="Submit" value="WL VErification Done"></td>
                </form>
         </tr>
        <%}
                       }
        catch(Exception e)
        {
            out.println("e");
        }%>
    </table>
    </body>
</html>

[Paul Clapham]

The <form> element in your HTML sends a request to the server. That's "a" request -- one single request. This request should be directed to a servlet which validates and handles the form parameters, not to a JSP.

If the <form> element has type="post" then the doPost() method of the servlet will be called, and if it has type="get" then the doGet() method will be called. Your design should choose the type parameter appropriately.

So that means that the servlet which the <form> element requests should have code in either doPost() or doGet() to handle the request, but not in both of them.

[Rakesh Keerthi]

Hi Paul,
thanks for the suggestion, based on it i've updated the code as below but now i'm getting some other error.

Jsp is:

<%@include file="DBCon.jsp"%>
<html>
    <body>
        <table><tr><td><b>Pending for Westlaw Verification </b></td><td></td></tr> 
        <%try{
            Class.forName("oracle.jdbc.driver.OracleDriver").newInstance();
	Connection con=DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:XE","system","tiger");
        PreparedStatement ps=con.prepareStatement("Select DBID from Scope_Demo 
where Count1 is not null AND WL_VERIF IS NULL");
         ResultSet rs=ps.executeQuery();
            while(rs.next())
    {       %>  <%
    %>
          
        <tr>
                <form action="Mail" method="post">
                    <td><input type="text" id="abc" name="abc" value="<%=rs.getString("DBID")%>" size="100"></td>
                    <td><input type="Submit" value="WL VErification Done"></td>
                </form>
         </tr>
        <%}
                       }
        catch(Exception e)
        {
            out.println(e);
        }%>
    </table>
    </body>
</html>

The servlet is as below.

package Mail_M;

import java.io.IOException;
import java.io.PrintWriter;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.util.Properties;
import javax.mail.Message;
import javax.mail.Session;
import javax.mail.Transport;
import javax.mail.internet.InternetAddress;
import javax.mail.internet.MimeMessage;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
 
public class WlVerif extends HttpServlet{
    
    @Override
  public void doPost(HttpServletRequest request,
                    HttpServletResponse response)
            throws ServletException, IOException
  {
      PrintWriter out = response.getWriter();
  
      
       
        try{    
        String a=request.getParameter("abc");
        out.print(a);
        java.util.Date today = new java.util.Date();
        java.sql.Timestamp t= new java.sql.Timestamp(today.getTime());
        Class.forName("oracle.jdbc.driver.OracleDriver").newInstance();
	Connection con=DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:XE","system","tiger");
        PreparedStatement ps=con.prepareStatement("Update Scope_Demo SET WL_Verif='"+t+"' where DBID='"+a+"'");
        
        int i=ps.executeUpdate();
        
        if(i==1)
                       {
         
       String to = "[e-mail]";// Recipient's email ID needs to be mentioned.
       String from = "[e-mail]";// Sender's email ID needs to be mentioned
       String host = "localhost";  // Assuming you are sending email from localhost
     
      Properties properties = System.getProperties(); // Get system properties
      properties.setProperty("mail.smtp.host", host);// Setup mail server
 
      
      Session session = Session.getDefaultInstance(properties);// Get the default Session object.
      
      response.setContentType("text/html"); // Set response content type
      

      
         
         MimeMessage message = new MimeMessage(session);// Create a default MimeMessage object.
         
         message.setFrom(new InternetAddress(from));// Set From: header field of the header.
         
         message.addRecipient(Message.RecipientType.TO,
                                  new InternetAddress(to));// Set To: header field of the header.
         
         message.setSubject(a);// Set Subject: header field
         
         message.setText(a);// Now set the actual message
         
         Transport.send(message);// Send message
         String title = "Send Email";
         String res = "Sent message successfully....";
         String docType =
         "<!doctype html public \"-//w3c//dtd html 4.0 " +
         "transitional//en\">\n";
         out.println(docType +
         "<html>\n" +
         "<head><title>" + title + "</title></head>\n" +
         "<body bgcolor=\"#f0f0f0\">\n" +
         "<h1 align=\"center\">" + title + "</h1>\n" +
         "<p align=\"center\">" + res + "</p>\n" +
         "</body></html>");
                       }
      }
        catch (Exception e) {
          out.println(e);
      }
   }
} 

web.xml:

<?xml version="1.0" encoding="UTF-8"?>
<web-app version="3.0" xmlns="http://java.sun.com/xml/ns/javaee" 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd">
    <servlet>
        <servlet-name>Mail</servlet-name>
        <servlet-class>Mail_M.WlVerif</servlet-class>
    </servlet>
    <servlet-mapping>
        <servlet-name>Mail</servlet-name>
        <url-pattern>/WlVerif</url-pattern>
    </servlet-mapping>
    <session-config>
        <session-timeout>
            30
        </session-timeout>
    </session-config>
 
 </web-app>

when i run this program i'm getting the below error.

type Exception report

message 

description The server encountered an internal error () that prevented it from fulfilling this request.

exception 

java.lang.NullPointerException
	javax.mail.internet.MimeUtility.checkAscii(MimeUtility.java:915)
	javax.mail.internet.MimeUtility.encodeWord(MimeUtility.java:539)
	javax.mail.internet.MimeUtility.encodeText(MimeUtility.java:373)
	javax.mail.internet.MimeMessage.setSubject(MimeMessage.java:694)
	javax.mail.internet.MimeMessage.setSubject(MimeMessage.java:660)
	Mail.doPost(Mail.java:46)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
	org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:393)


note The full stack trace of the root cause is available in the Apache Tomcat/7.0.22 logs.

Also could you please suggest me how to see how the servlet workflow goes. I use Netbeans IDE.
Thanks

[Bear Bibeault]

Rakesh Keerthi wrote:based on it i've updated the code as below but now i'm getting some other error.

Keeping the nature of the error a secret is not a good way to get help on it.