table element repeats for multiple rows in JSP

[Poonam Dhatavkar]

I am implementing 'Search' operation on database using jsp and displaying results in html table.
On jsp page, user 1st enter Column value like id/name and the entire row related to that input should display for further queries like update/delete.
All working fine when displaying one search result/row, bt when there are more than 2 rows to display, it repeats the table display with table head like
--------------
| id |name|
---------------
| 2 | abc |
--------------
| id |name|
--------------
| 3 | xyz |
--------------

How to avoid it ?

Code is sumthing like this

 while(rst.next())
		  
	  { 
		  String str=rst.getString("DesignationID");
		 
		  System.out.println("Designation ID is "+str);
		 
		  i=i+1;
	  
%>   
<table id ="SearchDesignation"  bgcolor="#FFFFFF" bordercolor="#000000" border="1" width=60% height="58" >
	   	<tr><td>.</td>
		 	<td align="center" style="background-color:#87CEEB"><b>Designation</b></td>	
		    <td align="center" style="background-color:#87CEEB"><b>Designation ID</b></td></tr>
 
   
    <td><input type="checkbox" name="select" value="<%=rst.getString(2)%>"/></td>
       
    <td align="center"><%out.println(rst.getString("Designation")); %></td>
    <td align="center"><%out.println(rst.getString("DesignationID")); %></td>
    </tr> 	</form>
  <% }%>
 <tr>
    <td>.</td>
	<td align="center"><form name="SerchDesignation" method="POST" action="DesignationDeleteController">
		<input type="Submit"  value="Delete Record" ></form>
	</td>

[Bear Bibeault]

Java code and results sets in a JSP?

Bad bad practice. The database code should be in the model and you should be using the JSTL and EL in the JSP. See this JspFaq entry for more information.

That said, the table element is inside the loop, so of course it's going to be repeated.

[Poonam Dhatavkar]

ohh..Thank you.
I will surely try improving. Any more suggestions ?

[Bear Bibeault]

Once you have switched to using JSTL, it's easier to see the loops using the <c:forEach> tags and less likely to have these kinds of problems.

If you need some background on how to structure modern web apps, please read this article.

[Poonam Dhatavkar]

Thank you very much Bear Bibeault :)