Win a copy of Re-engineering Legacy Software this week in the Refactoring forum
or Docker in Action in the Cloud/Virtualization forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Craps game

 
Miles Yiengst
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
its simple, but i mean it works... right now i only have the pass line bet available, but i'll be adding in other bets later on. its still a fun little game, and i'm just trying to expand it to the full game before the summer.

 
Miles Yiengst
Greenhorn
Posts: 2
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
if someone could help me out with the continue... it would be much appreciated... right now i just have a big long if statement, and im trying to get it to use less code... thanks
 
fred rosenberger
lowercase baba
Bartender
Posts: 12086
29
Chrome Java Linux
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
ugghh...no offense, but that is kind of a mess. For starters, you need to learn how to create methods. Most folks around here will tell you your main method should only be a few lines long. For example, you could create a method that computes the next roll. Inside that method, you would get the two random numbers from 1-6, total them, and just return the value. (Granted, this might not work if you want to allow hop bets)

Also, you should check out the java API. Specifically, if you look at the String class and the methods it has pre-built, you can simplify things like your line 93 (equalsIgnoreCase).

You should never write

it is unnecessary, and is prone to mistakes (think about what may happen if you accidentally type (stop = false)...)

just do this:

 
Junilu Lacar
Bartender
Pie
Posts: 7319
45
Android Eclipse IDE IntelliJ IDE Java Linux Mac Scala Spring Ubuntu
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
fred rosenberger wrote:
just do this:

or better yet:

Fred is right, learn how to use methods to break up the Big Ball of Mud that you currently have.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic