Craps game

[Miles Yiengst]

its simple, but i mean it works... right now i only have the pass line bet available, but i'll be adding in other bets later on. its still a fun little game, and i'm just trying to expand it to the full game before the summer.

/*
 * Craps - PASS LINE BET
 */

import java.util.Random;
import java.util.Scanner;

public class Gamble1 {

    public static void main(String args[]) {
        System.out.print("How much money do you have total? ");
        Scanner keyboard4 = new Scanner(System.in);
        double total = keyboard4.nextDouble();
        
        
        boolean stop = false;
        while (stop == false) {
            int n = 0; //simple counter
            System.out.print("Place your bets! $");
            Scanner keyboard = new Scanner(System.in);
            double bet = keyboard.nextDouble();
            double bet1 = 0; //bet after odds
            Random generator = new Random();
            int dies = generator.nextInt(6) + 1;
            int dies2 = generator.nextInt(6) + 1;
            int dietotal = dies + dies2;
            System.out.println("Press 'Enter' to roll");
            Scanner keyboard3 = new Scanner(System.in);
            String q2 = keyboard3.nextLine();
            System.out.println("Your first roll was " + dietotal);
            if (dietotal == 7 || dietotal == 11) {
                System.out.println("You win!");
                System.out.println("Amount won: $" + bet);
                total = total + bet;
                System.out.println("Your new total is: " + total);
                System.out.print("\nDo you want to play again?: ");
                Scanner keyboard2 = new Scanner(System.in);
                String cont = keyboard2.nextLine();
                if (cont.equals("") || cont.equals("Y") || cont.equals("y") || cont.equals("yes") || cont.equals("YES") || cont.equals("Yes")) {
                    stop = false;
                } else {
                    stop = true;
                }
            } else if (dietotal == 2 || dietotal == 3 || dietotal == 12) {
                System.out.println("You Crapped out!");
                System.out.println("Amount lost: $" + bet);
                total = total - bet;
                System.out.println("Your new total is: " + total);
                System.out.print("\nDo you want to play again?: ");
                Scanner keyboard2 = new Scanner(System.in);
                String cont = keyboard2.nextLine();
                if (cont.equals("Y") || cont.equals("y") || cont.equals("yes") || cont.equals("YES") || cont.equals("Yes")) {
                    stop = false;
                } else {
                    stop = true;
                }
            } else {
                if (dietotal == 4 || dietotal == 10) {
                    bet1 = bet * 2;
                }
                if (dietotal == 5 || dietotal == 9) {
                    bet1 = bet / 2 * 3;
                }
                if (dietotal == 6 || dietotal == 8) {
                    bet1 = bet / 5 * 6;
                }
                int diet = 0;
                while (!(diet == 7 || diet == dietotal)) {
                    int die = generator.nextInt(6) + 1;
                    int die2 = generator.nextInt(6) + 1;
                    diet = die + die2;
                    n = n + 1;
                    System.out.println("Press 'Enter' to roll again");
                    Scanner keyboard2 = new Scanner(System.in);
                    String q = keyboard2.nextLine();
                    System.out.println("Roll " + n + ": " + diet);
                }
                if (diet == 7) {
                    System.out.println("You lose");
                    System.out.println("You lost your bet of: $" + bet);
                    total = total - bet;
                }
                if (diet == dietotal) {
                    System.out.println("You win!");
                    System.out.println("Amount won: $" + bet1);
                    total = total + bet1;
                }
                System.out.println("Your new total is: " + total);

                System.out.print("\nDo you want to play again?: ");
                Scanner keyboard2 = new Scanner(System.in);
                String cont = keyboard2.nextLine();
                if (cont.equals("Y") || cont.equals("y") || cont.equals("yes") || cont.equals("YES") || cont.equals("Yes")) {
                    stop = false;
                } else {
                    stop = true;
                }
            }
        }
    }
}

[Miles Yiengst]

if someone could help me out with the continue... it would be much appreciated... right now i just have a big long if statement, and im trying to get it to use less code... thanks

[fred rosenberger]

ugghh...no offense, but that is kind of a mess. For starters, you need to learn how to create methods. Most folks around here will tell you your main method should only be a few lines long. For example, you could create a method that computes the next roll. Inside that method, you would get the two random numbers from 1-6, total them, and just return the value. (Granted, this might not work if you want to allow hop bets)

Also, you should check out the java API. Specifically, if you look at the String class and the methods it has pre-built, you can simplify things like your line 93 (equalsIgnoreCase).

You should never write

while (stop == false)

it is unnecessary, and is prone to mistakes (think about what may happen if you accidentally type (stop = false)...)

just do this:

while (!stop)

[Junilu Lacar]

fred rosenberger wrote:
just do this:

while (!stop)

or better yet:

while (keepPlaying)

Fred is right, learn how to use methods to break up the Big Ball of Mud that you currently have.