Trying to populate JTable with resultSet

[tom davies]

I am using an example and trying to make it work with my own program. I have a JComboBox with the names of my database tables in. I am able to display them by printing the result set but i now want to add them to a JTable. Below is what i currently have, but it doesn't return anything, the scren stays blank.

    public void displayTable(String table)
    {
        try
        {
            SimpleDataSource.init("database.properties");
            Connection con = SimpleDataSource.getConnection();
            Statement stat = con.createStatement();
            String query = "SELECT * FROM " + table;
            ResultSet rs = stat.executeQuery(query);
            model = new ResultSetTableModel1(rs);
            
            dTable = new JTable(model);
            displayTable = new JScrollPane(dTable);
        } catch(SQLException e) {
            System.out.println(e);
        } catch(IOException e) {
            System.out.println(e);
        } catch(ClassNotFoundException e) {
            System.out.println(e);
        }
                
    }

class ResultSetTableModel1 extends AbstractTableModel
{  
   /**
      Constructs the table model.
      @param aResultSet the result set to display.
   */
   public ResultSetTableModel1(ResultSet aResultSet)
   {  
      rs = aResultSet;
      try
      {  
         rsmd = rs.getMetaData();
      }
      catch (SQLException e)
      {  
         e.printStackTrace();
      }
   }

   public String getColumnName(int c)
   {  
      try
      {  
         return rsmd.getColumnName(c + 1);
      }
      catch (SQLException e)
      {  
         e.printStackTrace();
         return "";
      }
   }

   public int getColumnCount()
   {  
      try
      {  
         return rsmd.getColumnCount();
      }
      catch (SQLException e)
      {  
         e.printStackTrace();
         return 0;
      }
   }

   public Object getValueAt(int r, int c)
   {  
      try
      {  
         rs.absolute(r + 1);
         return rs.getObject(c + 1);
      }
      catch(SQLException e)
      {  
         e.printStackTrace();
         return null;
      }
   }

   public int getRowCount()
   {  
      try
      {  
         rs.last();
         return rs.getRow();
      }
      catch(SQLException e)
      {  
         e.printStackTrace();
         return 0;
      }
   }

   private ResultSet rs;
   private ResultSetMetaData rsmd;
}

[Rob Spoor]

How many records does your table have? If the number is quite high, then the calls to last() and absolute(...) will take quite long, effectively blocking the event dispatcher thread.

[tom davies]

Rob Spoor wrote:How many records does your table have? If the number is quite high, then the calls to last() and absolute(...) will take quite long, effectively blocking the event dispatcher thread.

Maximum of 6 at the moment, so not enough to cause a problem.

[Paul Clapham]

            dTable = new JTable(model);

As far as I can see you aren't adding this JTable to your GUI. Did you perhaps already create a JTable object, assign it to that dTable variable, and put it into your GUI in some initialization code? If so, then assigning another JTable object to the variable won't have any effect on that. Remember, the components you add into your GUI are objects, not variables.

So (again, if I guessed right) don't create a new JTable. Use the one you already have instead:

dTable.setModel(model);

[tom davies]

Paul Clapham wrote:

            dTable = new JTable(model);

As far as I can see you aren't adding this JTable to your GUI. Did you perhaps already create a JTable object, assign it to that dTable variable, and put it into your GUI in some initialization code? If so, then assigning another JTable object to the variable won't have any effect on that. Remember, the components you add into your GUI are objects, not variables.

So (again, if I guessed right) don't create a new JTable. Use the one you already have instead:

dTable.setModel(model);

Ahh yes, you did guess right. It is working now i am using dTable.setModel().

Thank You!