Struts2.1.8 Spring3.2.1 anootated app with autowired, gives Service as NULL

[Kevin P Smith]

Hi guys,

Spent the past day or so trying to set up a little Struts2, Spring3 (eventually Hibernate4) app with Annotations eg @autowired
but am having a little trouble.

For some reason my Action is always dropping to teh error.jsp, because my TestService is NULL.
Just wondering if anyone can see an obvioius reason why this is the case. I think I have included everything I need to below...

import org.apache.struts2.convention.annotation.Action;
import org.apache.struts2.convention.annotation.Result;
import org.springframework.beans.factory.annotation.Autowired;

import com.opensymphony.xwork2.ActionSupport;
import com.test.services.TestService;

public class TestAction extends ActionSupport {

	@Autowired 
	private TestService testService;
	
	@Action(value = "/welcome", results = {
	@Result(name = "success", location = "/successPage.jsp"),
	@Result(name = "error", location = "/error.jsp") })
	public String execute() {
		if (testService != null) {
			System.out.println("Injection worked!");
			return SUCCESS;
		} else {
			System.out.println("Injection failed!");
			return ERROR;
		}
	}

	public void setTestService(TestService testService) {
		this.testService = testService;
	}
}

@Service
public interface TestService {
	...
}

public class TestServiceImpl implements TestService {
	...
}

<beans xmlns="http://www.springframework.org/schema/beans"
		xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
		xmlns:tx="http://www.springframework.org/schema/tx"
		xmlns:context="http://www.springframework.org/schema/context"
		xsi:schemaLocation="http://www.springframework.org/schema/beans
							http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
							http://www.springframework.org/schema/tx 
					        http://www.springframework.org/schema/tx/spring-tx-3.0.xsd
					        http://www.springframework.org/schema/context 
					        http://www.springframework.org/schema/context/spring-context-3.0.xsd">

	<!-- tx:annotation-driven transaction-manager="txManager"/ -->
	
	<!-- context:component-scan base-package="com.test" / -->
	
	<context:annotation-config />
	
	<bean class="org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor"/>
			
	<bean id="testService" class="com.test.services.impl.TestServiceImpl" />
	
</beans>  

<?xml version="1.0" encoding="UTF-8"?>
<web-app id="WebApp_ID" version="2.4" xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd">
	<display-name>Struts2 First Example </display-name>

	<context-param>
		<param-name>contextConfigLocation</param-name>
		<param-value>
			/WEB-INF/application-context.xml
		</param-value>
	</context-param>
	
	<listener>
		<listener-class>
			org.springframework.web.context.ContextLoaderListener
		</listener-class>
	</listener> 

	<filter>
		<filter-name>struts2</filter-name>
		<filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter</filter-class>
	</filter>

	<filter-mapping>
		<filter-name>struts2</filter-name>
		<url-pattern>/*</url-pattern>
	</filter-mapping>

	<welcome-file-list>
		<welcome-file>index.jsp</welcome-file>
	</welcome-file-list>

</web-app>

commons-fileupload-1.2.1.jar
commons-io-1.3.2.jar
commons-logging-1.1.1.jar
freemarker-2.3.15.jar
ognl-2.7.3.jar
spring-aspects-3.2.1.RELEASE.jar
spring-beans-3.2.1.RELEASE.jar
spring-context-3.2.1.RELEASE.jar
spring-core-3.2.1.RELEASE.jar
spring-expression-3.2.1.RELEASE.jar
spring-struts-3.2.1.RELEASE.jar
spring-web-3.2.1.RELEASE.jar
struts2-convention-plugin-2.1.8.1.jar
struts2-core-2.1.8.1.jar
struts2tutorial.jar
xwork-core-2.1.6.jar

I'm sure it's going to turn out to be something stupid...

Thanks in advance

KS

[Bill Gorder]

TestAction where you are Autowiring in your service is not a spring bean. Autowiring can only occur in Spring managed beans.

If you plan to use Struts 2 with Spring then I suggest you take a look at using the Struts 2 plugin for Spring.
http://struts.apache.org/development/2.x/docs/spring-plugin.html

[Kevin P Smith]

Interesting.

I have the spring-struts-plugin.jar but guess I'm not using it properly.

Another interesting read I just found is this, not tried any of it yet though.

http://www.ibm.com/developerworks/library/j-sr2/index.html

Cheers for the input.

[Bill Gorder]

That is a really old thread and probably pertains to Struts 1. Struts 1 support is built into Spring. If you want to use Struts 2 then you should use the plugin I referred to earlier.


I don't see the plugin in your listed dependencies.

<dependency>
<groupId>org.apache.struts</groupId>
<artifactId>struts2-spring-plugin</artifactId>
<version>2.3.8</version>
</dependency>


Have a look at this tutorial
http://www.dzone.com/tutorials/java/struts-2/struts-2-example/struts-2-spring-plugin-integration-1.html

Note you don't need to wire your bean up in XML you are fine with the component scan like you have your bean name by convention will be "testService". However you can override this by giving a different name to the annotation @Service("myService")

Here was how someone else did it
http://stackoverflow.com/questions/9446176/struts2-spring-plugin-dependency-injection-with-annotated-actions-does-not-work

I think you should carefully read over the fist link I gave you again. I think you are missing something in the configuration. I don't use Struts 2 and Spring so I can provide much more assistance with this. I did add this to our Struts forum in case someone there has more experience integrating these 2 technologies.

[Kevin P Smith]

Arh yes it works with the struts2-spring.2.3.8.jar I had the 'reverse' jar spring-struts2.jar

Cheers!