an app to upload the file to ftp server

[Chen Jeff]

hi sir:

I just designed the apps which function is to upload the file to ftp server.
But it doesn't work.. I don't know where the problems is.I post the code in the following.
Who can help me figure out the problems and fix it.Thanks~

package com.example.caring;

import android.os.Bundle;
import android.app.Activity;
import android.view.View;
import android.widget.Button;
import android.widget.Toast;

public class caring extends Activity {
	private HelloToast test;

	@Override
	protected void onCreate(Bundle savedInstanceState) {
		super.onCreate(savedInstanceState);
		setContentView(R.layout.activity_main);
		
		test = new HelloToast();
		
		Button btn1 = (Button) findViewById(R.id.button1);
		btn1.setOnClickListener(new View.OnClickListener() {
			public void onClick(View v) {
				test.ftpConnect("140.124.73.28","lab205-2","jeff123",4000);
				String text = ((Button)v).getText().toString();
				Toast.makeText(caring.this, text, Toast.LENGTH_SHORT).show();
			}
		});
		Button btn2 = (Button) findViewById(R.id.button2);
		btn2.setOnClickListener(new View.OnClickListener() {
			public void onClick(View v) {
				test.ftpDisconnect();
				String text = ((Button)v).getText().toString();
				Toast.makeText(caring.this, text, Toast.LENGTH_SHORT).show();
			}
		});		
		Button btn4 = (Button) findViewById(R.id.button4);
		btn4.setOnClickListener(new View.OnClickListener() {
			public void onClick(View v) {
				test.ftpUpload("123","123456789.exe","789");
				String text = ((Button)v).getText().toString();
				Toast.makeText(caring.this, text, Toast.LENGTH_SHORT).show();
			}
		});	
	}

package com.example.caring;

import org.apache.commons.net.ftp.FTP;
import org.apache.commons.net.ftp.FTPClient;
import org.apache.commons.net.ftp.FTPReply;
import java.io.FileInputStream;
import android.content.Context;
import android.util.Log;
import android.widget.Toast;
public class HelloToast {
	private FTPClient mFTPClient = null;
	private String TAG5 = "MainActivity";
	private String TAG4 = "MainActivity";
	private String TAG3 = "MainActivity";
	private String TAG2 = "MainActivity";
	private String TAG1 = "MainActivity";
	private String TAG = "MainActivity";
public boolean ftpConnect(String host, String username,
	        String password, int port)
	{
		try {
		mFTPClient = new FTPClient();
		mFTPClient.connect(host, port);
		if (FTPReply.isPositiveCompletion(mFTPClient.getReplyCode())) {
		boolean status = mFTPClient.login(username, password);
                mFTPClient.setFileType(FTP.BINARY_FILE_TYPE);
		mFTPClient.enterLocalPassiveMode();
	
		return status;
		}
		} catch(Exception e) {
		Log.e(TAG1, "Error: could not connect to host " + host );
		Log.e(TAG1, e.toString());
		}
	
		return false;
	}

        public boolean ftpDisconnect()
	{
	    try {
	        mFTPClient.logout();
	        mFTPClient.disconnect();
	        return true;
	    } 
	    catch (Exception e) 
	    {
	        Log.e(TAG, "Error occurred while disconnecting from ftp server.");
	        Log.e(TAG, e.toString());
	    }
	    return false;
	}

         public boolean ftpUpload(String srcFilePath, String desFileName,
			                         String desDirectory)
			{
			    boolean status = false;
			    try {
			        FileInputStream srcFileStream = new FileInputStream(srcFilePath);

			        // change working directory to the destination directory
			        if (ftpChangeDirectory(desDirectory)) {
			            status = mFTPClient.storeFile(desFileName, srcFileStream);
			        }

			        srcFileStream.close();
			        return status;
			    } catch (Exception e) {
			        Log.d(TAG4, "upload failed");
			        Log.e(TAG4, e.toString());
			    }

			    return status;
			}     

[Ulf Dittmer]

What does "it doesn't work" mean? What is or is not working according to your expectations? What have tried so far to debug the issue?

[Chen Jeff]

It means that couldn't upload the files,
and I don't know where the problem is.
I'm not sure about making mistake on upload code or file path
the button can work only...
thanks for your opinion.

[Ulf Dittmer]

So:

Ulf Dittmer wrote: What have tried so far to debug the issue?

Which of the code you wrote does or does not run? You can find out by putting lots of Log.i(...) statements in the code and observing the logcat output, or by running it in a debugger, or by putting up lots of Toasts.