JSF and Mysql connectivity giving error

Hello Experts i am new to JSF, and i am creating a simple database access which just simply prints the database table on the page ... but i cannot access my manged bean class in my jsf page... everytime i run the code the error it shows is {/index.xhtml @12,71 value="#{cityController.allCity}": Target Unreachable, identifier 'cityController' resolved to null} i am attaching my code please have a look at it
CityBean.java

Dbase.java

CityController.java

index.xhtml

<?xml version='1.0' encoding='UTF-8' ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:p="http://primefaces.org/ui">
    <h:head>
        <title>Cities in the World</title>
    </h:head>
    <h:body>
        
        <h:form>
            <p:dataTable var="item" value="#{cityController.allCity}">
                <p:column headerText="City">
                    <h:outputText value="#{item.cityName}"/>
                </p:column>              
                <p:column headerText="District">
                    <h:outputText value="#{item.cityName}"/>
                </p:column>              
                <p:column headerText="Population">            
                    <h:outputText value="#{item.cityName}"/>
                </p:column>              
            </p:dataTable>
        </h:form>
    </h:body>
</html>

Welcome to the JavaRanch, Waqar!

In JSF, you do not normally code Controllers. The Controller part of JSF is the FacesServlet and the support code that implements the various View Template Language elements.

Your NullPointerException comes from naming your CityController (which is actually a Model) with the name "CityController". If you must call it a Controller, call it "cityController" as required by both POJO coding conventions and because that's what your View Template is calling it.

You'll still fail, however, because you have no property access methods. So the EL reference to property "allCity" will not resolve.

Tim Holloway wrote:Welcome to the JavaRanch, Waqar!

In JSF, you do not normally code Controllers. The Controller part of JSF is the FacesServlet and the support code that implements the various View Template Language elements.

Your NullPointerException comes from naming your CityController (which is actually a Model) with the name "CityController". If you must call it a Controller, call it "cityController" as required by both POJO coding conventions and because that's what your View Template is calling it.

You'll still fail, however, because you have no property access methods. So the EL reference to property "allCity" will not resolve.

Thanks Tim for giving your time... but i very new to JSF .. would you like elaborate your answer further.... should i rename my "CityController" or what??

You should study up on JavaBeans and POJOs. JSF is based on them, as are many other popular Java technologies.

Until you understand how they work, you can't really understand how JSF works.

What you name the bean isn't really important to JSF, but, as I said, in JSF, you almost never write your own Controller code, so it's not really correct to name a bean "xxxxController". The software won't care, but it mis-informs people reading the code.

Tim Holloway wrote:You should study up on JavaBeans and POJOs. JSF is based on them, as are many other popular Java technologies.

Until you understand how they work, you can't really understand how JSF works.

What you name the bean isn't really important to JSF, but, as I said, in JSF, you almost never write your own Controller code, so it's not really correct to name a bean "xxxxController". The software won't care, but it mis-informs people reading the code.

thanks for the advise ... i will try to follow your advice....