Win a copy of Think Java: How to Think Like a Computer Scientist this week in the Java in General forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Collections- HashMap

 
Sarvarth Bhatnagar
Greenhorn
Posts: 9
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
What is the advantage of overriding hashcode in Gogx in code below. We can do the exact same thing with cat which does not override Hashcode


Result:
Gogx key
null
null
null
Cat key

Please explain the importance of overriding the Hashcode in Gogx.
 
Jesper de Jong
Java Cowboy
Saloon Keeper
Posts: 15274
38
Android IntelliJ IDE Java Scala Spring
  • Likes 1
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Note: There is a bug in line 10 of your code. The method should have been named hashCode(), not hashcode(). Because it has the wrong name, it's not overriding hashCode() of class Object, and it will not be called.

You should use the @Override annotation to catch such mistakes:

And there is another bug, in line 15. You are comparing strings with == there. That does not work; use .equals() instead to compare strings.
 
Sarvarth Bhatnagar
Greenhorn
Posts: 9
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
my bad, Thanks Jesper! for the annotation suggestion
 
Campbell Ritchie
Sheriff
Posts: 48921
58
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Apart from the inconcistent indentation and spacing, which makes your code very difficult to read, you have some bad style in that equals method.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic