One Jdialog class for multiple panel classes

[Charles Sexton]

I am having trouble adding and removing panels to JDialog based on abstract action used by the used. Here is an example: In this example the dialog class adds the jpanel on the first attempt of the action but whenever the dialog closes and the user repeats the same action the jpanel doesn't show in the jdialog. Just an FYI I am trying to do this through the MVC Architecture.

	public class TableMouseListener extends MouseAdapter {
		@Override
		public void mousePressed(MouseEvent evt) {
			if (evt.getButton() == MouseEvent.BUTTON3) {
				dialog.showDialog(new KeywordPanel().getKeywordPanel(), evt.getXOnScreen(),
						evt.getYOnScreen());
			}
		}
	}
	
	public class DialogWindowListener extends WindowAdapter {
		 @Override
		    public void windowClosing(final WindowEvent event) {
		        dialog.getDialog().dispose();
		        dialog.getDialog().removeAll();
		    }
	}

public class Dialog {
	private JDialog dialog = new JDialog();

	public Dialog() {
		dialog.setLayout(new MigLayout());
		dialog.setModalityType(ModalityType.APPLICATION_MODAL);
		dialog.setResizable(false);
	}

	public void showDialog(JPanel panel, int x, int y) {
		dialog.add(panel);
		dialog.pack();
		dialog.setLocation(x, y);
		dialog.setVisible(true);
	}

	public JDialog getDialog() {
		return dialog;
	}

}

public class KeywordPanel {
	private JPanel keywordPanel;
	private JTextField[] textFields;
	private JLabel searchLbl;
	private JButton close, remove;

	public KeywordPanel() {
		keywordPanel = new JPanel(new MigLayout());
		textFields = new JTextField[] { new JTextField("", 30),
				new JTextField("", 30), new JTextField("", 30),
				new JTextField("", 30), new JTextField("", 30) };
		remove = new JButton("Remove");
		close = new JButton("Save & Close");
		searchLbl = new JLabel("KeyWords");

		close.setBackground(MainControl.getButtonColor());
		close.setFont(MainControl.getFont());

		remove.setBackground(MainControl.getButtonColor());
		remove.setFont(MainControl.getFont());
		searchLbl.setFont(MainControl.getFont());

		keywordPanel.add(searchLbl, "wrap");
		for (JTextField textField : textFields) {
			keywordPanel.add(textField, "wrap");
		}
		keywordPanel.add(remove);
		keywordPanel.add(close, "cell 0 6, gapx 30px");
	}

	public void setTextFieldText(int index, String text) {
		textFields[index].setText(text);
	}

	public JPanel getKeywordPanel() {
		return keywordPanel;
	}

}

[Darryl Burke]

Can't see anything obviously wrong in the code you posted. To get better help sooner, post a SSCCE (Short, Self Contained, Correct (Compilable), Example) that demonstrates the problem.

[Charles Sexton]

SSCCE, I wasn't able to solve but did narrow down the problem. I tried every way possible that I know to add the jar file for miglayout. Miglayout

package view;

import java.awt.Dimension;

import javax.swing.JFrame;

public class CreateAndShowUI {
	public static void createUI() {
		JFrame frame = new JFrame();
		MainPanel mainPanel = new MainPanel();
		Dialog dialog = new Dialog();
		MainControl mainControl = new MainControl(frame, mainPanel,
				dialog);

		frame.getContentPane().add(mainPanel.getMainPanel());
		frame.setUndecorated(true);
		frame.setPreferredSize(new Dimension(1100, 550));
		frame.pack();
		frame.setLocationRelativeTo(null);
		frame.setVisible(true);
	
	}
	public static void main(String[] args) {
		createUI();
	}
}

package view;

import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;

import javax.swing.JFrame;

	public class MainControl {
		private JFrame frame;
		private MainPanel mainPanel;
		private Dialog dialog;

		public MainControl(JFrame frame, MainPanel panel, Dialog dialog) {
			this.frame = frame;
			this.mainPanel = panel;
			this.dialog = dialog;
			mainPanel.getTable().addMouseListener(new MouseListener());
			dialog.getDialog().addWindowListener(new DialogWindowListener());
		}

		public class MouseListener extends MouseAdapter {
			@Override
			public void mousePressed(MouseEvent evt) {
				if (evt.getButton() == MouseEvent.BUTTON3) {
					dialog.showDialog(new KeywordPanel().getKeywordPanel(),
							evt.getXOnScreen(), evt.getYOnScreen());
				}
			}
		}

		public class DialogWindowListener extends WindowAdapter {
			@Override
			public void windowClosing(final WindowEvent event) {
				dialog.getDialog().dispose();
				dialog.getDialog().removeAll();
			}
		}
	}

package view;

import java.awt.Dimension;

import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTable;

import model.ProductTableModel;
import net.miginfocom.swing.MigLayout;

public class MainPanel {
		private JPanel mainPanel;
		private JScrollPane listScrollPane;
		private JTable table;

		public MainPanel() {
			mainPanel = new JPanel(new MigLayout("", "", "[]13[]"));
			table = new JTable(new ProductTableModel());
			listScrollPane = new JScrollPane(table,
					JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
					JScrollPane.HORIZONTAL_SCROLLBAR_NEVER);
			listScrollPane.setPreferredSize(new Dimension(850, 990));
			mainPanel.add(listScrollPane, "cell 0 1");
		}

		public JPanel getMainPanel() {
			return mainPanel;
		}

		public JTable getTable() {
			return table;
		}
	
}

package view;

import javax.swing.JLabel;
import javax.swing.JPanel;

public class KeywordPanel {
	private JPanel keywordPanel;
	private JLabel searchLbl;

	public KeywordPanel() {
		searchLbl = new JLabel("KeyWords");
		keywordPanel = new JPanel();
		keywordPanel.add(searchLbl);
	}

	public JPanel getKeywordPanel() {
		return keywordPanel;
	}

}

package view;
import javax.swing.JDialog;
import javax.swing.JPanel;

import net.miginfocom.swing.MigLayout;

	public class Dialog {
		private JDialog dialog = new JDialog();

		public Dialog() {
			dialog.setLayout(new MigLayout());
		}

		public void showDialog(JPanel panel, int x, int y) {
			dialog.add(panel);
			dialog.pack();
			dialog.setVisible(true);
		}

		public JDialog getDialog() {
			return dialog;
		}

	}

package model;

import java.util.ArrayList;

import javax.swing.JTable;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableColumnModel;

import common.Product;

public class ProductTableModel extends AbstractTableModel {
	private ArrayList<Object> list = new ArrayList<Object>();
	private String[] columnNames = { "ID", "Description", "Inventory",
			"Minimum Quantity", "Cost", "Order Quantity" };

	public ProductTableModel() {
		list.add(new Product("Sup", "Sup", "Sup", 10, 20, "null"));
	}

	@Override
	public int getColumnCount() {
		return columnNames.length;
	}

	@Override
	public String getColumnName(int column) {
		switch (column) {
		case 0:
			return "<html>ID<br></html>";
		case 1:
			return "<html>Description<br></html>";
		case 2:
			return "<html>Inventory<br></html>";
		case 3:
			return "<html>Minimum<br>Quantity</html>";
		case 4:
			return "<html>Cost<br></html>";
		case 5:
			return "<html>Order<br>Quantity</html>";
		default:
			return null;
		}
	}

	@Override
	public int getRowCount() {
		return list.size();
	}

	@Override
	public boolean isCellEditable(int row, int column) {
		return true;
	}

	@Override
	public Object getValueAt(int row, int column) {

		if (list.get(row) instanceof Product) {

			Product product = (Product) list.get(row);
			switch (column) {
			case 0:
				return product.getId();
			case 1:
				return product.getProductDescription();
			case 2:
				return product.getQtyOnHand();
			case 3:
				return product.getMinQty();
			case 4:
				return product.getCost();
			case 5:
				return product.getOrderQty();
			default:
				throw new IndexOutOfBoundsException();
			}

		} else {
			return null;
		}
	}
}

package common;

public class Product {
	private int minQty;
	private double cost;
	private String productDescription, id, category, qtyOnHand, orderQty;

	public Product(String id, String productDescription, String qtyOnHand,
			int minQty, double cost, String orderQty) {

		this.setQtyOnHand(qtyOnHand);
		this.setOrderQty(orderQty);
		this.setId(id);
		this.setMinQty(minQty);
		this.setCost(cost);
		this.setProductDescription(productDescription);
	}

	public String getQtyOnHand() {
		return qtyOnHand;
	}

	public void setQtyOnHand(String qtyOnHand) {
		this.qtyOnHand = qtyOnHand;
	}

	public String getOrderQty() {
		return orderQty;
	}

	public void setOrderQty(String orderQty) {
		this.orderQty = orderQty;
	}

	public String getId() {
		return id;
	}

	public void setId(String id) {
		this.id = id;
	}

	public double getCost() {
		return cost;
	}

	public void setCost(double cost) {
		this.cost = cost;
	}

	public String getProductDescription() {
		return productDescription;
	}

	public void setProductDescription(String productDescription) {
		this.productDescription = productDescription;
	}

	public int getMinQty() {
		return minQty;
	}

	public void setMinQty(int minQty) {
		this.minQty = minQty;
	}

	public String getCategory() {
		return category;
	}

	public void setCategory(String category) {
		this.category = category;
	}
}

[Charles Sexton]

the problem was that I was disposing the dialog and using JDialog add() instead of getting the contentpane and using the add method.

dialog.getContentPane.removeAll();
dialog.getContentPane.add(panel);

dialog by default on window closing hides the dialog, so dispose or setVisible wasn't needed in the WindowAdapter