Creating Platform independent scripts(Solaris and Linux)

[Ramakanta Sahoo]

Hi all,

I'm not able to figure it out how i will make it UNIX platform independent.
Mainly(Solaris and Linux)
Below script runs smoothly in Linux but in Solaris its showing lots of syntax errors like its not able to reco. if statements even.
What i need to do so that the syntax will be platform independent

#!/bin/sh
#----------------------------------------------
# WAS ROOT PATH SET BELOW
#----------------------------------------------
WAS_ROOT=/opt/IBM/WebSphere/AppServer/
#----------------------------------------------
DATE=`/bin/date +date_%d-%m-%y_time_%H-%M-%S`
PLATFORM=`/bin/uname`
_Up1=`/usr/bin/logname`
_Up2=`/usr/bin/env`
_Up3=`set`
scriptname=`basename $0`
Script_Usage1() {
        echo -e "**********************************************"
        echo -e "----------------------------------------------"
        echo -e "--GET ENVIRONMENT DETAILS --\n"
        echo -e "----------------------------------------------"
        echo "Current Env : ${_Up2}"
        echo "Logged in as:${_Up1}"
        echo "Environment set as:${_Up3}"
        echo -e "-----------------------------------------------"
        echo -e "Env. details done."
        echo -e "------------------------------------------------"
        echo -e "closing logfile install_$DATE.log "
        echo -e "********** *************************************"
}
if [[ "${PLATFORM}" == "Linux" ]]
then
 _Up=`/bin/ps -eaf | grep -i profiles | grep -v grep | awk '{print $NF}' ;`
else
  _Up=`/usr/ucb/ps -auxww | grep -i profiles | grep -v grep ;`
fi
starton () {
 
        echo -e "Starting $scriptname ..."
        echo -e "------------------------------------------"
        echo -e "Starting Wsadmin tool for installation ..."
        echo -e "-------------------------------------------"
        if [[ ("${1}" != "") && ("${2}" != "") && ("${3}" == "express") ]]
        then
         "$WAS_ROOT/bin/wsadmin.sh" -user "${1}" -password "${2}" -f "expresscontrol.jacl"
        elif [[ ("${1}" == "express") ]]
        then
          "$WAS_ROOT/bin/wsadmin.sh" -f "expresscontrol.jacl"
        elif [[ ("${1}" = "webserver") ]]
        then
         "$WAS_ROOT/bin/wsadmin.sh" -f "configureWebserverDefinition.jacl"
        elif [[ ("${1}" != "") && ("${2}" != "") && ("${3}" == "webserver") ]]
        then
        "$WAS_ROOT/bin/wsadmin.sh" -user "${1}" -password "${2}" -f "configureWebserverDefinition.jacl"
        elif [[ ("${1}" != "") && ("${2}" != "") ]]
        then
        "$WAS_ROOT/bin/wsadmin.sh" -user "${1}" -password "${2}" -f "control.jacl"
        else
        "$WAS_ROOT/bin/wsadmin.sh" -f "control.jacl"
        fi
if [[ "${_Up}" != "" ]]
then
        starton | tee install_$DATE.log
        Script_Usage1 >> install_$DATE.log
else
        echo "WAS is not running"
fi
    

Can someone help me in getting this script working in both machines Linux and solaris.


Thanks.

[Charles Lyons]

Is this written for Bash or another shell? It looks very much like the former to me, so wouldn't it be better off with a shebang similar to (obviously depending on the actual paths on your system):

#!/bin/bash

rather than just /bin/sh? It may be that Solaris is using a different shell (either Bourne itself, or another one symlinked to /bin/sh) than your Linux install. That'd explain the syntax errors since different shells have different scripting languages. Check to see what the actual shells linked to /bin/sh are on each system.
[ October 03, 2008: Message edited by: Charles Lyons ]

[Ramakanta Sahoo]

Hi,

You are right.
Though I've limited access to My solaris machine which is at remote location.
I just did a smoke test and found that after changing to bash it not giving any syntax errors minimum.I think its ok now.
Once I will get full test on Solaris I'll let you know.
Thanks a lot for suggestions.

Ricky

[Ramakanta Sahoo]

Hi,

I back again.
I ran this script..and it ran well without syntax errors
but am facing a new problem.
I designed it to take input from command line like
./install.sh wsadmin wspassword express
where $1 will be wsadmin and $2 will be wspassword and $3 will be express
but i think its not able to compare it.
what ever i put in command line its directly taking me to last else statement.
I thought it will work like if no username and password is mentioned then it will go to last else stament..but here whether i put any argument with or not its directly taking me to last else statement.
Help me am not able to figure it out how it will able to check if there is any argument passed or not if passed then go to appropriate if stmt or elif stmt.

Thanks.
Ricky

[Andrew Monkhouse]

It's hard to tell if your script above is merely missing a brace to close off the starton() function, or whether there is more code missing. I am going with the idea that your script is complete, except for that syntax error, which means that the problem is not in the passing / parsing of parameters - it appears to me to be having troubles with determining whether WebSphere is running or not.

Basically, your last if/else block is only interested in whether "${_Up}" is blank or not. And _Up is defined by whether you were able to find the case insensitive word "profile" in the list of currently running processes.

Regards, Andrew

[Ramakanta Sahoo]

Ohh sorry I forgot to mention which if else stmts
Its starton if else stmts.
and websphere is running as its able to give me the last else stmt's output. else it would have told me that WAS is not running.
As it's going to

 starton | tee install_$DATE.log        Script_Usage1 >> install_$DATE.log   

Block so its mean that websphere is running.
But in that function its not able to check all the if else stmts its directly going to

else        "$WAS_ROOT/bin/wsadmin.sh" -f "control.jacl"    

stmt whether i pass any args with (./install.sh username passwd) or not. Its just acting like I have only given ./install.sh with out any arguments.
So i think there is some problem in function starton in comaparing the arguments as it going directly to the last control stmt in starton which is

   else
"$WAS_ROOT/bin/wsadmin.sh" -f "control.jacl"  

Thanks.

[Ramakanta Sahoo]

Hey seems I found the problem.
I added echo "1st param:$1 2nd param:$2" to check whether the command line args are available inside the starton function and ran the script as ./install.sh myID myPWD and i found that the echo stmt its showing as below:
1st param: 2nd param:
so i think all the arguments I'm passing is not available inside the starton function. Thats why its goin directly to the last else stmt in starton function as $1 and $2 all are null inside the function.
I have also checked the params outside the function and its showing all the params as 1st param:myID 2nd param:myPWD

So if anyone know how to avail all the parameters inside the starton function also.

Do I need to assign the arguments passed to some variable to make it available through out the script, something like
param1=$1
param2=$2
param3=$3

and if stmts inside starton function will be like

if [[ ("${param1}" != "") && ("${param2}" != "") && ("${param3}" == "express") ]]     

Correct me if I'm wrong.

Thanks.
Ricky

[Ramakanta Sahoo]

Hi Andrew Monkhouse

That last close brace i missed during posting my code.
Sorry for that.

[Andrew Monkhouse]

Originally posted by Ricky Rosan:
So if anyone know how to avail all the parameters inside the starton function also.

Doh! Missed that one.

Take a look at this:

andrews-computer:~ andrew$ cat example
#!/bin/bash
 
function doSomething() {
        echo "1 = $1"
        echo "2 = $2"
        echo "3 = $3"
}
 
doSomething $2 hello $1

And the results when I run it:

andrews-computer:~ andrew$ ./example world goodbye
1 = goodbye
2 = hello
3 = world

So, basically the $x parameters within the function refer to the parameters passed to the function itself - not to the entire script.

Does that make sense?

Andrew

[Ramakanta Sahoo]

Yes very true.
Its been fixed now.
I just did what i told before.I added the $1 $2 $3 with some variables.

 
#!/bin/bash
param1=$1
param2=$2
param3=$3
....
....
....   

So the problem is we need to assign it to some variable as parameters within the function refer to the parameters passed to the function itself - not to the entire script.

Now it's working absolutely fine.

Thanks,

Ricky

[Ramakanta Sahoo]

Hi all Ranchers,

I came back to get one more info.
This is what i want ..
bash$ export WAS_ROOT=/opt/IBM/WebSphere/AppServer/
bash$ ./install.sh
This is what i want to enable. If some one exports the WAS_ROOT value in command line then I need the exported value to be available inside script also. So that user need not vi install.sh and add the path manually.

I am nt able to figure it out how am gonna achieve this.

Thanks,
Ricky

[Charles Lyons]

The export will make the variable available to the child script process, unless the script overrides the value locally... so you could just remove the part in the script where it sets the WAS_ROOT variable, if that is also the name of the script-local variable. Otherwise you'll need to do a test like (in Java-style pseudo-code, I'll leave you to figure out how to do it in Bash):

SCRIPT_ROOT=...; // already there
if($WAS_ROOT is set) { // if environment variable set
  SCRIPT_ROOT=$WAS_ROOT; // override script-local value
}

where SCRIPT_ROOT is the variable set in the script, and WAS_ROOT is your environment variable which overrides it.

You can also override variables temporarily with env---something like:

env WAS_ROOT=/opt/IBM/WebSphere/AppServer/ ./install.sh

[Ramakanta Sahoo]

Ohhh ,
Right...

Then there is no way where i can enable both .
including a option inside and outside as a export.
any way your soluion is also a good alternative also.

Thanks Charles

Cheers!!
Ricky

[Andrew Monkhouse]

Are you trying to have a default value that a user could override? If so, you could always check whether the value has been set within your script:

#!/bin/bash
 
if [ -z "$WAS_ROOT" ];then
    export WAS_ROOT=/my/Location
fi
 
# at this point, WAS_ROOT is either equal to the value set prior to running
# this script, or if was not set, then it is equal to /my/Location

Regards, Andrew

[Tim Holloway]

A good set of examples on scripts with overridable values is the /etc/init.d/scripts directory on any Red Hat-style Linux distro. In order to ease maintenance, they designed their scripts to be immutable, taking their customizations from alternative locations such as the /etc/sysconfig directory.

[Ramakanta Sahoo]

hey Andrew Thanks mate.

I used your sugg. its working...

Cheers!!

Ricky