Win a copy of Svelte and Sapper in Action this week in the JavaScript forum!
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Ron McLeod
  • Paul Clapham
  • Bear Bibeault
  • Junilu Lacar
Sheriffs:
  • Jeanne Boyarsky
  • Tim Cooke
  • Henry Wong
Saloon Keepers:
  • Tim Moores
  • Stephan van Hulst
  • Tim Holloway
  • salvin francis
  • Frits Walraven
Bartenders:
  • Scott Selikoff
  • Piet Souris
  • Carey Brown

Please review my criteriaFind method

 
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi there
Please review and comment my criteriaFind method implementation.
fieldMap - HashMap contains field name as the Key and order number of it as the value.

[ December 20, 2002: Message edited by: Junilu Lacar ]
 
Ranch Hand
Posts: 194
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi Sergei,
if it works, it is ok.
However, I find your method somewhat long. I stuffed all this parsing and matching into a separate class, thus encapsulating it.
As a rule of thumb: your methods should be so long that you can view them on the screen without scrolling. If your methods are longer than that, consider refactoring them.
Besides, I used two tokenizers, one for separating the key-value pairs, and the other one for separating the key from the value. Instead of putting all possible delimiters into one string you could use the nextToken(String delim) method.
Hope this helps.
 
money grubbing section goes here:
the value of filler advertising in 2020
https://coderanch.com/t/730886/filler-advertising
    Bookmark Topic Watch Topic
  • New Topic