Deadlock question

[Ramses Tutoli]

Right now in my code, I think deadlock can occur in LocalDataClient/RemoteDataClientImpl after a record is locked but before a record is unlocked if an exception is thrown in one of the methods. For example, take the following code in my LocalDataClient class:

    public void delete(int recNo)
        throws RecordNotFoundException, SecurityException
    {
        long lockCookie = db.lock(recNo);
        db.delete(recNo, lockCookie);
        db.unlock(recNo, lockCookie);
    }

if an exception is thrown in my call to db.delete(), the record never has a chance to unlock. Would it be ok to put my db.unlock() method in a finally{} clause to fix this?

[Philippe Maquet]

Hi Ramses,
A db.unlock() call from a finally{} clause sounds good to me. Notice though that the security brought by your finally clause will be higher if your method is running server-side.
Best,
Phil.