FTP with sun.net.ftp.

[Avanish Raut]

I am using BufferedInputStream and BufferedOutputStream to transfer files in batches of 1024 bytes since the file size varies from 1024Byes to 500MB.
BufferedOutputStream is unable to write if buffer size is less than 1024 bytes. It transfers files with zero bytes.
It is working fine for file size > 1024 bytes
Any help will be appreciated.

[Carl Trusiak]

I'm not sure where your problem could be. I've used the same thing Sun's FtpClient, BufferOutputStream and successfully sent files as small as 64 bytes. Post a code example and we'll see if we can help.

[Avanish Raut]

Originally posted by Carl Trusiak:
I'm not sure where your problem could be. I've used the same thing Sun's FtpClient, BufferOutputStream and successfully sent files as small as 64 bytes. Post a code example and we'll see if we can help.

Here is the code, please let me know whats wrong with this code.

package com.eai.mm.builder;
import sun.net.ftp.*;
import sun.net.*;
import java.io.*;
import java.net.*;
import com.entergy.eai.mm.cismetermaint.VeritranFileFormat;
public class MMFtpClient extends FtpClient {

//************************************************************************************
// CONSTANTS
//************************************************************************************
// Output File extention
public static final String OUTPUT_FILE_EXT = ".TXT";
// Completion file extention
public static final String COMPLETION_FILE_EXT = ".st";

//************************************************************************************
// PUBLIC VERIABLES
//************************************************************************************
// FTP Client 
public FtpClient client;
public MMFtpClient()
{
}
public void FTPExecute(String sFilePath,String sFileName) throws Exception
{
try
{
File[] filelist = (new File(sFilePath)).listFiles();
System.out.println("Files Found");
VeritranFileFormat oVeritranFileFormat = (VeritranFileFormat)DataFormat.getInstance("OngoingVeritranFlatFile.props");
openServer(oVeritranFileFormat.getSVeritranServer().trim());
FtpClient client = new FtpClient(oVeritranFileFormat.getSVeritranServer().trim());
//FtpClient client = new FtpClient("cctudev");
System.out.println("Server Found");
client.login(oVeritranFileFormat.getSVeritranLogin().trim(),"mrbill2");
//client.login("veritran","mrbill2");
System.out.println("Login Verified");
//client.cd("dev/data/export_ready");
client.cd(oVeritranFileFormat.getSVeritranDirectory().trim());
System.out.println("Changed Directory");
client.binary();
System.out.println("Transfer Mode set to Bin" + client);
for (int i = 0;i < filelist.length; i++)
{
if (filelist[i].getName().trim().equals(sFileName))
{
System.out.println("File Path" +filelist[i].getAbsolutePath());
//filelist[i].renameTo()
upLoadFile(filelist[i].getAbsolutePath(), client);
//System.out.println("File FTPed");
filelist[i].delete();
}

}

System.out.println("Process Complete");
}
catch(Exception e)
{
System.out.println(e);
throw new Exception("Check the Login and Password["+ e.getMessage() + "]");
}
}
public void upLoadFile(String uploadFile, FtpClient client) throws Exception
{
try
{
File uplfil = new File(uploadFile);
BufferedInputStream bReader = null;
//InputStream in= new FileInputStream(uplfil);
InputStream in = new FileInputStream(uploadFile);

System.out.println("InputStream data length =" + in.available());
bReader = new BufferedInputStream(in);
System.out.println(uploadFile);

String sTargetFileName = uplfil.getName()+"_"+FormatData.getSystemDate()+"_"+FormatData.getSystemTime("HHMMSS");

System.out.println("Target File Name " + sTargetFileName);

OutputStream out = client.put(sTargetFileName + OUTPUT_FILE_EXT);

BufferedOutputStream bout = new BufferedOutputStream(out);

int total = 0;
int readcount = 0;

System.out.println(bReader.available());
if (bReader.available() >= 1024)
{
byte[] buffer = new byte[1024];
while((readcount = bReader.read(buffer)) > 0)
{
bout.write(buffer,0,readcount);
/*total = total + readcount;
System.out.println(total);*/
if (bReader.available() < 2048)
{
System.out.println("Reading last bytes" + bReader.available());
byte[] lastBuffer = new byte[bReader.available()];
int lastReadCount = bReader.read(lastBuffer);
bout.write(lastBuffer,0,lastReadCount);
total = total + lastReadCount;
System.out.println(total);
}
}
}
else
{
System.out.println("No of Bytes in file" + bReader.available());
byte[] buffer = new byte[bReader.available()];
int lastReadCount = bReader.read(buffer);
bout.write(buffer,0,lastReadCount);
total = total + lastReadCount;
System.out.println(total);
}
in.close();
bReader.close();
out.close();
bout.close();

String sTargetFileNameComplete = sTargetFileName + OUTPUT_FILE_EXT + COMPLETION_FILE_EXT;
OutputStream outComplete = client.put(sTargetFileNameComplete);
BufferedOutputStream boutComplete = new BufferedOutputStream(outComplete);
String comp = "Complete";
boutComplete.write(comp.getBytes());
outComplete.close();
boutComplete.close();
}
catch(Exception e)
{
System.out.println(e);
throw new Exception("Couldn't Ftp the File["+e.getMessage()+"]") ;
}
}
}

I added the UBB tags Code for easier reading. How to use UBB tags can be found Here
[This message has been edited by Carl Trusiak (edited February 22, 2001).]

[Carl Trusiak]

if (bReader.available() >= 1024)
{
byte[] buffer = new byte[1024];
while((readcount = bReader.read(buffer)) > 0)
{
bout.write(buffer,0,readcount);
/*total = total + readcount;
System.out.println(total);*/
if (bReader.available() < 2048)
{
System.out.println("Reading last bytes" + bReader.available());
byte[] lastBuffer = new byte[bReader.available()];
int lastReadCount = bReader.read(lastBuffer);
bout.write(lastBuffer,0,lastReadCount);
total = total + lastReadCount;
System.out.println(total);
}
}
}
else
{
System.out.println("No of Bytes in file" + bReader.available());
byte[] buffer = new byte[bReader.available()];
int lastReadCount = bReader.read(buffer);
bout.write(buffer,0,lastReadCount);
total = total + lastReadCount;
System.out.println(total);
}

Wow, try simplifing this to:

    byte[] buffer = new byte[1024];
    while((readcount = bReader.read(buffer)) != -1)
    {
        bout.write(buffer,0,readcount);
        total = total + readcount;
        System.out.println(total);
    }
    bout.flush();

That's about all I used and it worked fine.

[This message has been edited by Carl Trusiak (edited February 22, 2001).]

[Avanish Raut]

When I started, my code was like that way only. After that I observed that last 1024 bytes were not transfered properly. Thats the reason I changed my code like the way it is now.

[Carl Trusiak]

Like I said, I used the exact code I posted and had no problems. I have to caution on using Sun's FtpClient, it's an unsupported package and it could just be the version you are using. Try refactoring you code and include the Socket based FTPClient Jeff Holmes contributed. It's not fully complete but, should have enough for your task http://www.javaranch.com/ubb/Forum38/HTML/000066.html

------------------
Hope This Helps:)
Carl Trusiak

[Jon House]

Try adding the bout.flush to the portion of the code when there's less than 1024 bytes. See code below. I was having the same problem until I used the bout.flush(); to flush the buffer.

System.out.println("No of Bytes in file" + bReader.available());
byte[] buffer = new byte[bReader.available()];
int lastReadCount = bReader.read(buffer);
bout.write(buffer,0,lastReadCount);
total = total + lastReadCount;
bout.flush();
System.out.println(total);