Hibernate Criteria Query not working properly

[Saravanan Vijayappan]

Hi,

Criteria query restrictions are not applied in the items of the collections. I have a persistence entity (POJO) Menugroup and it has a collection called catgroups (HashSet, one to many). Catgroup persistence entity (POJO) has another one-to-many collection "dealitems" (HashSet). My criteria query is below:


code:

          List menuGroups = session.createCriteria(Menugroup.class)
          .add( Restrictions.eq("published", true)).addOrder( Property.forName("name").asc()).setResultTransformer(Criteria.DISTINCT_ROOT_ENTITY).
          setFetchMode("catgroups", FetchMode.JOIN).
          createCriteria("catgroups").addOrder( Property.forName("name").asc()).
          add( Restrictions.eq("published", true) ).setFetchMode("dealitems", FetchMode.DEFAULT)
          .list();
 

Mapping file snippet of Menugroup.hbm.xml is below:-

code:

<set inverse="true" batch-size="10" lazy="false" name="catgroups">
<key>
<column name="MENUGROUP_ID">
<comment>Menu Group relationship</comment>
</column>
</key>
<one-to-many class="com.model.persistence.Catgroup"/>
</set>


When I run my Criteria query, hibernate generates the below 2 sqls and they are displayed in the console

Hibernate generated SQL query-1

code:

 select
            this_.MENUGROUP_ID as MENUGROUP1_0_1_,
            this_.NAME as NAME0_1_,
            this_.DESCRIPTION as DESCRIPT3_0_1_,
            this_.PUBLISHED as PUBLISHED0_1_,
            this_.LASTUPDATE as LASTUPDATE0_1_,
            catgroup1_.CATGROUP_ID as CATGROUP1_1_0_,
            catgroup1_.MENUGROUP_ID as MENUGROUP2_1_0_,
            catgroup1_.NAME as NAME1_0_,
            catgroup1_.DESCRIPTION as DESCRIPT4_1_0_,
            catgroup1_.IMGURL as IMGURL1_0_,
            catgroup1_.PUBLISHED as PUBLISHED1_0_,
            catgroup1_.SUGESSTION as SUGESSTION1_0_,
            catgroup1_.LASTUPDATE as LASTUPDATE1_0_
        from
            cyddev.MENUGROUP this_
        inner join
            cyddev.CATGROUP catgroup1_
                on this_.MENUGROUP_ID=catgroup1_.MENUGROUP_ID
        where
            this_.PUBLISHED=?
            and catgroup1_.PUBLISHED=?
        order by
            this_.NAME asc,
            catgroup1_.NAME asc
 

 

Hibernate generated SQL query-2:


code:

     select
            catgroups0_.MENUGROUP_ID as MENUGROUP2_1_,
            catgroups0_.CATGROUP_ID as CATGROUP1_1_,
            catgroups0_.CATGROUP_ID as CATGROUP1_1_0_,
            catgroups0_.MENUGROUP_ID as MENUGROUP2_1_0_,
            catgroups0_.NAME as NAME1_0_,
            catgroups0_.DESCRIPTION as DESCRIPT4_1_0_,
            catgroups0_.IMGURL as IMGURL1_0_,
            catgroups0_.PUBLISHED as PUBLISHED1_0_,
            catgroups0_.SUGESSTION as SUGESSTION1_0_,
            catgroups0_.LASTUPDATE as LASTUPDATE1_0_
        from
            cyddev.CATGROUP catgroups0_
        where
            catgroups0_.MENUGROUP_ID in (
                ?, ?
            )
 

The issue issue is, in the result, items in the catgroups collections are not in ascending order and the restriction "published=true" are also not applied on them. I meant to say that below condtions from my criteria query are not applied on catgroups collections.

createCriteria("catgroups").addOrder( Property.forName("name").asc()).
add( Restrictions.eq("published", true) )

The above critieria conditions should be applied on hibernate generated 2nd SQL query but it does not happen. Could any one help me to find out whether I have missed some thing in my criteria query to get the result as I expected or this is a bug in criteria query. ?

Expected result: Items in the catgroups collection should be in order and the condition "published"=true should applied.

I hope, the information i provided above would help to understand what is the problem I face.

Thanks
Sarav

[Mark Spritzler]

Well, not sure if I can help, but do you want them as two seperate Criteria objects, or just one?

Also, this is the type of query where I like using HQL instead of Criteria. I find that the more complex queries are easier for me to do in HQL then using the Criteria object.

This is just my opinion, and should not be thought of as the way you have to do it.

Mark

[Saravanan Vijayappan]

I would like to have a single object. My intention is to have everything in single object and navigating later whenever it is required. Like, a List should have Menugroup objects, navigating to Catgroups through from Menugroup object through Iteration later. I have found some difficulties in HQL that join HQL query does not return POJO objects and it returns java.lang.Object types. Please help me if you can give me corresponding HQL query for my criteria query. Thanks

[Mark Spritzler]

Originally posted by Saravanan Vijayappan:
I would like to have a single object. My intention is to have everything in single object and navigating later whenever it is required. Like, a List should have Menugroup objects, navigating to Catgroups through from Menugroup object through Iteration later. I have found some difficulties in HQL that join HQL query does not return POJO objects and it returns java.lang.Object types. Please help me if you can give me corresponding HQL query for my criteria query. Thanks

Yeah, an HQL will return that if you are specifying more in your select portion, but if you have the classes mapped and you don't specify the Select part, then it will create POJOs.

What HQL did you try?

Mark

[Saravanan Vijayappan]

Thanks for your reply Mark.

My HQL is below

Query query  = session.createQuery("from Menugroup m left join m.catgroups c where m.published=true and c.published=true");
List list = query.list();
System.out.println(list);

Output is below: all objects in the list are java.lang.Object and they are not type of Menugroup POJO.

[[Ljava.lang.Object;@502819, [Ljava.lang.Object;@78aa80, [Ljava.lang.Object;@1d98a, [Ljava.lang.Object;@1712651, [Ljava.lang.Object;@18aab40, [Ljava.lang.Object;@f102d3, [Ljava.lang.Object;@f07355, [Ljava.lang.Object;@23f1bb, [Ljava.lang.Object;@1d33a6b, [Ljava.lang.Object;@a0864f, [Ljava.lang.Object;@d1e233, [Ljava.lang.Object;@15983b7, [Ljava.lang.Object;@1d6747b, [Ljava.lang.Object;@7976c1]

One more issue what I'm seeing is, published=true condition is not applied in the 2nd SQLs while batch is running to fetch the child collection (Catgroups)

Hibernate session factory is created
Hibernate: 
    select
        menugroup0_.MENUGROUP_ID as MENUGROUP1_0_0_,
        catgroups1_.CATGROUP_ID as CATGROUP1_1_1_,
        menugroup0_.NAME as NAME0_0_,
        menugroup0_.DESCRIPTION as DESCRIPT3_0_0_,
        menugroup0_.PUBLISHED as PUBLISHED0_0_,
        menugroup0_.LASTUPDATE as LASTUPDATE0_0_,
        catgroups1_.MENUGROUP_ID as MENUGROUP2_1_1_,
        catgroups1_.NAME as NAME1_1_,
        catgroups1_.DESCRIPTION as DESCRIPT4_1_1_,
        catgroups1_.IMGURL as IMGURL1_1_,
        catgroups1_.PUBLISHED as PUBLISHED1_1_,
        catgroups1_.SUGESSTION as SUGESSTION1_1_,
        catgroups1_.LASTUPDATE as LASTUPDATE1_1_ 
    from
        cyddev.MENUGROUP menugroup0_ 
    left outer join
        cyddev.CATGROUP catgroups1_ 
            on menugroup0_.MENUGROUP_ID=catgroups1_.MENUGROUP_ID 
    where
        menugroup0_.PUBLISHED=1 
        and catgroups1_.PUBLISHED=1
 
 
 
Hibernate: 
    select
        catgroups0_.MENUGROUP_ID as MENUGROUP2_1_,
        catgroups0_.CATGROUP_ID as CATGROUP1_1_,
        catgroups0_.CATGROUP_ID as CATGROUP1_1_0_,
        catgroups0_.MENUGROUP_ID as MENUGROUP2_1_0_,
        catgroups0_.NAME as NAME1_0_,
        catgroups0_.DESCRIPTION as DESCRIPT4_1_0_,
        catgroups0_.IMGURL as IMGURL1_0_,
        catgroups0_.PUBLISHED as PUBLISHED1_0_,
        catgroups0_.SUGESSTION as SUGESSTION1_0_,
        catgroups0_.LASTUPDATE as LASTUPDATE1_0_ 
    from
        cyddev.CATGROUP catgroups0_ 
    where
        catgroups0_.MENUGROUP_ID in (
            ?, ?, ?
        )

I have been working since long to resolve this, but, I am not able to do, Please help me :-((

Many Thanks in advance!
Sarav
[ July 14, 2008: Message edited by: Saravanan Vijayappan ]

[Mark Spritzler]

OK, yes, that is true based on how you wrote your code.

so you have

Query query = session.createQuery("from Menugroup m left join m.catgroups c where m.published=true and c.published=true");
List list = query.list();

You can try changing
List list = query.list();

to

List<Menugroup> list = query.list();

or when you loop through the objects in the list, just cast them to Menugroup objects. They are Menugroup objects in the Collection.

Mark
Mark

[Saravanan Vijayappan]

Nope, it does not work. I am getting ClassCastException when I try cast it while looping. So, the objects in the List is java.lang.Object.

Query query  = session.createQuery("from Menugroup m left join m.catgroups c where m.published=true and c.published=true");
List list = query.list();
System.out.println(list);
Iterator it = list.iterator();
while(it.hasNext())
{
Menugroup menu = (Menugroup) it.next();
}

Exception in thread "main" java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to com.model.persistence.Menugroup

Any suggestion please!!!?

Many Thanks
Sarav

[Saravanan Vijayappan]

This is simple/powerful HQL solved my requirement.

select distinct m from Menugroup m left join fetch m.catgroups c where m.published=true and c.published=true order by m.name