Midi stop working

[Bernardo Costa]

Hi, It s my first time here in this great forum! Hope someone help me please. It is a simpple code that works fine. Take a look below. It plays a note when the button is clicked! The problem is: When I put the midi part of this code in a separeted Class the midi note sounds 15 times and stop working!? I do not know why.I tried many thinks. I would like to put the midi part in a different class just to take advantage of oriented language. Thanks if anyone could help!

 
public class Test_2008 extends JFrame implements ActionListener {
 

 
static JButton note;
String go = "go";
private MidiChannel channel;
 

Test_2008 ()  {
 

super (); 
 
this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
this.setSize(300, 300);
this.setLayout(new FlowLayout ());
note = new JButton (go); 
this.add(note);
note.addActionListener(this);
 
try {
Synthesizer synth = 
MidiSystem.getSynthesizer();
synth.open();
channel = synth.getChannels()[0];
//channel2=synth.getChannels()[1];
} catch (MidiUnavailableException e) {
e.printStackTrace();
}
 

}
 

 
public void playOneNote (int note) {
 
channel.noteOn(note, 70);
try {
Thread.sleep(500);
} catch (InterruptedException e) {
e.printStackTrace();
}
channel.noteOff(note, 70);
 
}
 
public void actionPerformed(ActionEvent arg0) {
 

playOneNote (60);
}
public static void main(String[] args) {
 

 
Test_2008  objeto = new Test_2008 ();
objeto.setVisible(true);
 

 
}
 

 

 
}
   

[Ulf Dittmer]

Welcome to JavaRanch.

I'm not familiar with how javax.sound works internally, but one thing that is definitely a problem with this code is that you're playing the sound from inside of the actionPerformed method. Event handlers should run (and terminate) quickly, lest they block other threads from running. So putting a Thread.sleep into an event handler is a big no-no. Start a new thread that plays the sound, and ses if that improves matters.

Since this is really not a beginner question, I'll move it to the Other Java APIs forum, where the Sound API is generally discussed.