File upload only handles .txt documents??

[Annemarie McKeown]

I am using the following code to handle file uploads using JSP.
The form which calls this upload.jsp is of type multipart.
However the upload only works for txt documents, word douments .doc and .pdf documents do not open once uploaded to server. They say error opening file when trying to open.
Can someone help me with the following code, what do I need to do to handle binary uploads, I think at the minute it only supports ascii.

  
<%@ page errorPage="error.jsp" %>
<jsp:useBean id="prop" scope="page" class="java.util.Properties" />
<%@ page language="java" import="java.io.*,java.util.*,javax.servlet.*" %>
<%!
public String getBoundary(HttpServletRequest request,Properties prop) throws ServletException,IOException{
String boundary = null;
Enumeration enum = request.getHeaderNames();
while(enum.hasMoreElements()){
String header = (String)enum.nextElement();
String hvalue = request.getHeader(header);
prop.setProperty((header).toLowerCase(),hvalue);
if( "content-type".equalsIgnoreCase(header) ){
int idx = hvalue.lastIndexOf("boundary=");
if( idx != -1 ){
boundary= hvalue.substring( idx+9 , hvalue.length());
}
}
}
return boundary;
}
public String getFileName(String secondline)
{
int len = secondline.length();
int idx = secondline.lastIndexOf("filename=");
if( idx == -1 ) return null;
String filename = secondline.substring( idx+10 , len-1);
filename = filename.replace('\\','/');
idx = filename.lastIndexOf("/");
idx = idx + 1;
filename = filename.substring( idx );
return filename;        
}
%>
<%
  //fetch dir path dynamically to upload files to server.

String DPATH = application.getRealPath("//uploads//");
int  ROUGHSIZE=1024;
int  MAXSIZE  =  10; // MB
String boundary = getBoundary(request,prop);
if( boundary == null ){
boundary = prop.getProperty("boundary");
}else{
boundary = "--"+boundary;
}
if( boundary == null ){
throw new Exception("BNF");
}
Long contentsize = new Long(prop.getProperty("content-length","0"));

int c;
StringWriter st = new StringWriter();
if( contentsize.longValue() < 1L ){
throw new Exception("ZERO");
} 
long l = contentsize.longValue() - ROUGHSIZE; 

int KB = 1024;
int MB = 1024 * KB;
int csize = (int)(l / MB);
if( csize > MAXSIZE ){
throw new Exception("EL");
}
ServletInputStream fin =  request.getInputStream();
//Getting Start Boundary Line
int cn;
int count=0;
while( (c=fin.read()) != -1 ){
if( c == '\r') break;
st.write(c);
count++;
    }
c=fin.read();  /*read new line*/
String tboundary = st.getBuffer().toString();
tboundary=tboundary.trim();
if( ! tboundary.equalsIgnoreCase( boundary) ){
throw new Exception("BBNF");
}
    st.close();
    st = null;
st = new StringWriter();

/*Getting File Information*/
while( (c=fin.read()) != -1 ){
        if( c == '\r' ) break;
        st.write(c);
    }
c=fin.read();  //read new line
String secondline = st.getBuffer().toString();
    String filename  =  getFileName(secondline);
    
st.close();
    st = null;
      st = new StringWriter();

/*Read Content Type of File*/
while( (c=fin.read()) != -1 ){
if( c == '\r' ) break;
st.write( c );
}
c=fin.read();  //read new line

fin.read(); 
    fin.read();  
File newfile = null;
FileOutputStream fout =null; 

/* Handle File Not Found Exception*/
try{
if( filename == null ) throw new FileNotFoundException("File Name not found");
newfile = new File(DPATH +"/"+ filename); 
fout = new FileOutputStream( newfile );
}catch(FileNotFoundException fnexp){
fin.close();
throw new Exception("FNF");
}

byte b[] = null;
while( l > 1024L ){
b = new byte[1024];
fin.read(b,0,1024);
fout.write(b);
b=null;
l -= 1024L;
        }
if( l > 0 ){
b = new byte[(int)l];
fin.read(b,0,(int)l);
fout.write(b);
}

ByteArrayOutputStream baos = new ByteArrayOutputStream();
while(  (c = fin.read()) != -1 ){
baos.write(c);
}
String laststring = baos.toString();
int idx = laststring.indexOf(boundary);
b = baos.toByteArray();
if( idx > 2 ){
fout.write(b,0,idx-2);
}else
{
fout.close();
newfile.delete();
throw new Exception("EBNF");
}
fout.flush();
fout.close();
fin.close();


String filenametmp = newfile.getName(); //Assign filenametmp to FileName
String dir_path = DPATH + "\\" + filenametmp; //Dir Path on Server e.g C:/jakarta-tomcat..
String parent_dir = ("/15324001/uploads/"); //Parent Dir of webapp/uploads
String url_path = parent_dir + filenametmp; //Concatenate to obtain url_path using http protocal


%>

The whole upload process is handled by this upload.jsp file.
Some help please.
[ March 08, 2004: Message edited by: Annemarie McKeown ]

[Bear Bibeault]

Please use UBB code tags when posting code. Many people will not take the time to try and decipher unformatted blobs of code.

[Annemarie McKeown]

What are UBB code tags and how do I use them?

[Bear Bibeault]

When you are at the page where you enter a topic or reply there are a bunch of buttons that will help enter UBB tags (similar to HTML markup, except using square brackets). There is also a link named "What is UBB Code?" that might be helpful.

[Annemarie McKeown]

Thank you, can you please help me, ive been stuck at this problem for days.
Annemarie.

[Bear Bibeault]

Without looking into it in any great detail, I'd take a look around your handling of "lines" and the '\r' character. Are you stripping these out? That makes no sense for binary files.
Is there a good reason that you are loathe to use one of the proven multi-part parsers and file uploaders such as the oreilly package and others that have been discussed in earlier topics?

[Annemarie McKeown]

Yes, because I wanted to try it for myself and also because I couldn't get the o'reilly package working.

[Bear Bibeault]

I can certainly respect the "try it myself" reasoning, but if this is something you are under a deadline for, you might have had better luck trying to get help getting oreilly to work.
That said, I still believe that your primary problem is that you seem to be treating the file content as text-oriented; e.g. lines terminated with a \r. You should just treat the file content as 'blocks of bytes" with no interpretation. That way, the interpretation, be it text or binary, is preserved.

[Annemarie McKeown]

thanks thats a big help.
Do you think I should use MultipartRequest as defined in the O'Reilly package?
Do you have any code for methods which handles with file uploads rather than reading it in by lines.
Annemarie

[Nicholas Cheung]

I am not sure whether pure JSP has such coding.
But I have worked with upload using Struts. We can define a Form which captures the upload parameters (defined in the Struts config file), then we need to define an ActionDispatcher to handle the request. When the container calls the ActionDispatcher's method, the files and the form parameters have already been uploaded to the Struct Form, and we can get all info, including the upload file, from the Form.
Before using Struts, I have also used JSP Smart upload, which is a free API for JSP to upload file. However, it has a serious security issue, and finally, this API is not recommended.
Nick.

[Jeroen Wenting]

Your problem (or at least one of them, I've not done exhaustive research) is that you're using a StringWriter to write out the uploaded data.
I think if you use some other mechanism (maybe a ByteArrayOutputStream) you should be able to write your data as binary without it getting corrupted.
The JavaDoc confirms this:

FileOutputStream is meant for writing streams of raw bytes such as image data. For writing streams of characters, consider using FileWriter.

in fact, all Writers work on character arrays only and can cause corruption in binary data.