Forum:

Servlet code in JSP page

Ranch Hand

Posts: 763

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I want to put my this servlet code in to jsp file. I'm already having this view to send mail like there is 3 textbox and 1 textarea. How do i do that. How do this controller's code will be called on clicking send button ?

package com.test;
import javax.servlet.http.HttpServlet;
import java.io.*;
import java.io.IOException;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
//Mail API
import java.util.Properties;
import javax.mail.*;
import javax.mail.internet.*;
 
/**
 * Servlet Class
 *
 * @web.servlet              name="sendMail"
 *                           display-name="Name for sendMail"
 *                           description="Description for sendMail"
 * @web.servlet-mapping      url-pattern="/sendMail"
 * @web.servlet-init-param   name="A parameter"
 *                           value="A value"
 */
public class sendMail extends HttpServlet {
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
throws ServletException,
IOException {
String smtpHost = "smtpout.travelguru.com";
    String from = req.getParameter("from");
    String to = req.getParameter("to");
    String sub = req.getParameter("sub");
    String message = req.getParameter("message");
    System.out.println(from + to + message);
    PrintWriter out = resp.getWriter();
    try{ 
    // Get system properties
    Properties props = System.getProperties();
 
    // Setup mail server
    props.put("mail.smtp.host", smtpHost);
    
    // Get session
    Session session = Session.getDefaultInstance(props, null);
 
    // Define message
    MimeMessage msg = new MimeMessage(session);
    
    msg.setFrom(new InternetAddress(from));
    msg.addRecipient(Message.RecipientType.TO,new InternetAddress(to));
    msg.setSubject(sub);
    msg.setText(message);
 
    // Send message
    Transport.send(msg);
   }catch(Exception e){
   e.printStackTrace(); 
  out.println(e.fillInStackTrace());   
   }
}
}

[ December 12, 2006: Message edited by: Bear Bibeault ]

[BSouther: Added UBB Code Tags]
[ December 13, 2006: Message edited by: Ben Souther ]

Jigar Naik

Bear Bibeault

Sheriff

Posts: 67750

173

I like...

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Originally posted by Jigar Naik:
I want to put my this servlet code in to jsp file.

Why on earth would you want to do something like that?

If your code is already properly factored into a servlet, why would you throw all best practices to the wind and put it into a JSP?

[Asking smart questions] [About Bear] [Books by Bear]

HTML 5 (verified skill)
Skill verified by Jeanne Boyarsky

CSS 3 (verified skill)
Skill verified by Jeanne Boyarsky

JavaScript (verified skill)
Skill verified by Jeanne Boyarsky

Jigar Naik

Ranch Hand

Posts: 763

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I know its not good but i have to do what my boss says.

Jigar Naik

Anu Pillai

Greenhorn

Posts: 28

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Maybe what you need to do is that, you want to call the servlet from the jsp on clicking a button of the jsp. Either you misunderstood what your boss said or you couldnt frame the question properly. In case you want to call the servlet from the jsp, change the form tag of your jsp to include the name of the servlet in the action attribute.

something like <form action='urlPatternOfServlet'>

Jigar Naik

Ranch Hand

Posts: 763

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

No the view is ready in jsp..see the code

SendMail.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
<title>Using Java Mail API</title>
</head>
<img src="/SendMail/images/Logo.gif" />
<hr>
<br><br><br><br><br>
<form action="/SendMail/sendMail" method="get">
<table align="center">
<tr>
<td align="right"> From : </td>
<td> <input type="text" name="from" value="jnaik@travelguru.com"size="65" >>
</tr>
<tr>
<td align="right"> To : </td>
<td> <input type="text" name="to" size="65" TABINDEX="1">
</tr>
<tr>
<td align="right"> Subject : </td>
<td> <input type="text" name="sub" size="65" TABINDEX="2">
</tr>
<tr>
<td valign="top" align="right"> Message : </td>
<td> <textarea cols="50" rows="15" name="message" TABINDEX="3"></textarea>
</tr>
</table>
<center>
<br>
<input type="submit" name="submit" value="Mail" TABINDEX="4">
<input type="reset" name="reset" value="Clear" TABINDEX="5">
</center>
</form>
</body>
</html>

and the logic is in the Servlet sendMail.java

I'm being told to put the whole code of servlet in to this sendMail.jsp page.

and i guess in jsp on clicking submit some code should be called but don't know how to do that. can you suggest me the same...

[BSouther: Added UBB code tags]
[ December 13, 2006: Message edited by: Ben Souther ]

Jigar Naik

Bear Bibeault

Sheriff

Posts: 67750

173

I like...

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

What your boss is asking you to do is nonsense.

You can't have the code that is supposed to react to the submission of a form in the same JSP that creates that form. The code in the JSP will execute on the server before the form is even sent to the user. Does that make sense?

[Asking smart questions] [About Bear] [Books by Bear]

Jigar Naik

Ranch Hand

Posts: 763

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

ya, i told my boss what you said and now he told me to create another jsp page which will be called from sendMail.jsp.

Jigar Naik

Ben Souther

Sheriff

Posts: 13411

I like...

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Does your boss have pointy hair?

Java API J2EE API Servlet Spec JSP Spec How to ask a question... Simple Servlet Examples jsonf

Manish Agarwal

Greenhorn

Posts: 20

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Jigar,

In my opinion you can create a method in the new jsp and call that method in the same jsp. This method will be executed when this jsp is called. This way you can add your code in jsp.
This is very bad practice to put java code in jsp but in your case you cant help it.

SCWCD1.4, SCJP1.4, OCA 9i

yu wang

Greenhorn

Posts: 4

posted 17 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

A jsp is just a servlet. But I think putting all codes into a servlet is a better chance.

Did you see how Paul cut 87% off of his electric heat bill with 82 watts of micro heaters?