Use Multiple Insert Statements in Prepared Statements

[vikram karne]

Hi Friends

i am stuck in a problem for which i need your help.i will brief you about the issue below.

I am having Multiple Insert Statements which i need to execute to put the data in the database.i have a doubt about the use of the executeUpdate() function in the statement interface. sample code is as below.

stmt = conn.prepareStatement("INSERT INTO Client ( clientPk, provincePk, countryPk, statusPk, branchPk, salutation, ) VALUES(PID, 2, '123123123', '123', '66', 1, 1 );");
int n =stmt.executeUpdate();

Now the problem is how do i insert multiple Insert statements using the conn.prepareStatement().should i do like
stmt = conn.prepareStatement("")
int n =stmt.executeUpdate();
stmt = conn.prepareStatement("")
int n =stmt.executeUpdate();
stmt = conn.prepareStatement("")
int n =stmt.executeUpdate(); ..................................

should i use the same steps to execute each individual query and then use executeUpdate().
Please let me know the correct procedure to be followed to execute these tasks.waiting for a positive reply from your side.

Thanks & Regards
Vikram K

[Shailesh Chandra]

Originally posted by vikram karne:

I am having Multiple Insert Statements which i need to execute to put the data in the database.

Are you inserting in same table every time? if yes, then you can use addBatch() method of PreparedStatement class, to inster multiple data.

Also use place holders when you create a prepared statment, the code you have posted here,is not suggested way of using prepared Statement

stmt = conn.prepareStatement("INSERT INTO Client ( clientPk, provincePk, countryPk, statusPk, branchPk, salutation, ) VALUES(PID, 2, '123123123', '123', '66', 1, 1 );");

rather you should make a prepared statment like

stmt = conn.prepareStatement("INSERT INTO Client ( clientPk, provincePk, countryPk, statusPk, branchPk, salutation ) VALUES(?,?,?,?,?,? )");
 

If you make perparestatement using place holders, then you can resue same.


Thanks,
Shailesh

[Scott Selikoff]

No, you do not need to call prepareStatement() every line. If the SQL code to perform the insert is not changing, you can call the same prepareStatement() object multiple times with different parameters such as:

// Create statement
stmt = conn.prepareStatement("INSERT INTO Client ( clientPk, provincePk, countryPk, statusPk, branchPk, salutation, ) VALUES(PID, 2, '123123123', '?, ?, ?, ? );");
 
// Perform updates
stmt.setString(1,value1);
stmt.setString(2,value2);
stmt.setInt(3,value3);
 

int n1 =stmt.executeUpdate();
stmt.setInt(4,"some info");
 
int n2 =stmt.executeUpdate();
stmt.setInt(4,"some info");

The trick is to replace the data with "?" with the stuff you need changed every line. This code is a lot safer (from SQL injection) and performance than what you had. For completeness, you should really replace every input parameter with ? and use setString/setDouble/etc to set it.