JComboBox not working properly on a GridBagLayout ??

[Fernando Sanz]

Hi guys, I've got a very simple class to enter data of a new Customer.
The user needs to select a branch from a drop down list (a JComboBox), but, the list of names is covered up by the labels that are in a lower position.
If you'd compile this short code, you'll see what I mean. I just don't understand it, because it works in other classes I've written (with different Layouts)

// Java core packages
import java.awt.*;
import java.awt.event.*;
// Java extension packages
import javax.swing.*;
public class GridBagBank extends JFrame { 
   private Container container;
   private GridBagLayout layout;
   private GridBagConstraints constraints; 
   
   private String[] branchStrings = { "Aberdeen", "Southampton", 
"Fife", "Inverness", "Westhill" };
private String[] employeeStrings = { "Helen Osler", "Fernando Sanz", 
"Richard Duncan", "Cameron Diaz", "Uma Thurman" };
    
   // set up GUI
   public GridBagBank()
   {
      super( "GridBagLayout" );
      container = getContentPane();
      layout = new GridBagLayout();
      container.setLayout( layout );   

      // instantiate gridbag constraints
      constraints = new GridBagConstraints();
  
  
      // create GUI components
  
Font logofont = new Font("Dialog", Font.BOLD, 36);
Font customerTitleLabelFont = new Font(null , Font.BOLD, 24) ;
  Label logoLabel = new Label("New Customer Input", Label.CENTER);
logoLabel.setFont(logofont);
logoLabel.setForeground(Color.cyan);
setFont(new Font("Dialog", Font.BOLD, 12)) ;

Label blankLabel = new Label("           ") ;
blankLabel.setForeground(Color.red);

Label branchLabel = new Label("Branch");
branchLabel.setForeground(Color.cyan);

Label employeeLabel = new Label("Employee");
employeeLabel.setForeground(Color.cyan);

Label customerTitleLabel = new Label("Customer") ;
customerTitleLabel.setForeground(Color.cyan) ;
customerTitleLabel.setFont(customerTitleLabelFont) ;

Label nameLabel = new Label("Name");
nameLabel.setForeground(Color.cyan);

Label addressLabel = new Label("Address");
addressLabel.setForeground(Color.cyan);

Label ageLabel = new Label("Age");
ageLabel.setForeground(Color.cyan);


JComboBox branchList = new JComboBox(branchStrings);
branchList.setSelectedIndex(0);
JComboBox employeeList = new JComboBox(employeeStrings);
employeeList.setSelectedIndex(0);

TextField nameText = new TextField("", 20) ;
TextField addressText = new TextField("", 20) ;
TextField ageText = new TextField("", 20) ;

Button addButton = new Button("Add to Database") ;
Button clearButton = new Button("Exit") ;
Button exitButton = new Button("Clear") ;
constraints.fill = GridBagConstraints.NONE ;
  addComponent( logoLabel, 0, 0, 3, 1 );    
  addComponent( branchLabel, 1, 0, 1, 1 );
  addComponent( employeeLabel, 2, 0, 1, 1 );
  
constraints.fill = GridBagConstraints.NONE ;
  addComponent( customerTitleLabel, 3, 0, 1, 1 );
  addComponent( nameLabel, 4, 1, 1, 1 );
  addComponent( nameText, 4, 2, 1, 1 );
  addComponent( addressLabel, 5, 1, 1, 1 );
  addComponent( addressText, 5, 2, 1, 1 );
  addComponent( ageLabel, 6, 1, 1, 1 );
  
  constraints.fill = GridBagConstraints.BOTH;
  addComponent( branchList, 1, 1, 1, 1 );
  addComponent( employeeList, 2, 1, 1, 1 );
  
  constraints.fill = GridBagConstraints.NONE ;
  
  Insets theInsets = new Insets(10, 5, 10, 5) ;
  constraints.insets = theInsets;
  addComponent( ageText, 6, 2, 1, 1 );
  
  addComponent( blankLabel, 7, 0, 3, 1 );
  
  constraints.anchor = GridBagConstraints.EAST ;
  addComponent( addButton, 8, 0, 1, 1 );
  constraints.anchor = GridBagConstraints.CENTER ;
  addComponent( clearButton, 8, 1, 1, 1 );
  constraints.anchor = GridBagConstraints.WEST ;
  addComponent( exitButton, 8, 2, 1, 1 );
  
   
    pack() ;
      setVisible( true );
   }
   // method to set constraints on 
   private void addComponent( Component component,
      int row, int column, int width, int height )
   {
      // set gridx and gridy 
      constraints.gridx = column;
      constraints.gridy = row;
      // set gridwidth and gridheight
      constraints.gridwidth = width;   
      constraints.gridheight = height;
      // set constraints and add component
      layout.setConstraints( component, constraints );  
      container.add( component );      
   }
   // execute application
   public static void main( String args[] )
   {
      GridBagBank application = new GridBagBank();
      application.setDefaultCloseOperation(
         JFrame.EXIT_ON_CLOSE );
   }
}  // end class GridBagBank  

Thanks for having a look

[Fernando Sanz]

OK, I have it now, I just didn't have to use Label, but JLabel
also, now my code is much nicer (shame on the me for the previous one...)
thanks anyway!