Using JOptionPane in NoSalesException

[Holly Leery]

Hello everyone! I am having some trouble creating a NoSalesException. I am not getting any errors or anything like that, it just is not running properly. When I first run the program it pops up 5 times and then never pops up again. I think the exception should be thrown from calculateSales and handled from the calling method; however I could not get that to work. When I handle this exception, it will print a warning message dialog box that states the name of the salesman and that he has no sales. So here is my Sales code and NoSalesException.

NoSalesException:

public class NoSalesException extends Exception
{
public NoSalesException()
{
super("Sales Equals Zero");
}
public NoSalesException(String message)
{
super(message);
}
}

Sales:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.util.ArrayList;
import java.io.*;
import java.util.*;
import java.text.NumberFormat;
 
//Class Sales runs a program that reads data from an existing file (file contains salesmen name and the amount of products sold),
//calculates their sales amount and adds their bonus to it.  The class also allows a user to enter additional salesman information
//which is also calculated and totaled.  Last all of the Salesman data is printed to the textarea.
 
public class Sales extends JFrame
{
static JLabel salesmanlabel;
static JTextField salesmanname;
static JLabel amtsold;
static JTextField amount;
static JLabel extra;
static JLabel productname;
static JComboBox product;
static JLabel level;
static JComboBox saleslevel;
static JButton salesmandone;
static JButton entrydone;
static JButton calctotal;
static JTextArea output;
static String outp;
Handler handler = new Handler();
static ArrayList<Salesman> myList = new ArrayList<Salesman>();
static NumberFormat currencyFormat = NumberFormat.getCurrencyInstance();

//Creates GUI and adds ActionListeners.
public Sales()
{
super("Monthly Sales");
setDefaultCloseOperation(EXIT_ON_CLOSE);
Container c = getContentPane();
c.setLayout(new FlowLayout());

salesmanlabel = new JLabel("Salesman:");
salesmanname = new JTextField(20);
amtsold = new JLabel("Amount Sold:");
amount = new JTextField(20);
productname = new JLabel("Product Sold:");
product = new JComboBox();
extra = new JLabel("");
level = new JLabel("Sales Level:");
saleslevel = new JComboBox();
salesmandone = new JButton("Salesman Entry Done");
entrydone = new JButton("All Data Entry Done");
calctotal = new JButton("Grand Total");
output = new JTextArea(300, 300);

product.addItem("");
product.addItem("Product 1");
product.addItem("Product 2");
product.addItem("Product 3");
product.addItem("Product 4");
product.addItem("Product 5");

saleslevel.addItem("");
saleslevel.addItem("Entry");
saleslevel.addItem("Junior");
saleslevel.addItem("Senior");

c.add(salesmanlabel);
c.add(salesmanname);
c.add(amtsold);
c.add(amount);
c.add(extra);
c.add(productname);
c.add(product);
c.add(level);
c.add(saleslevel);
c.add(salesmandone);
c.add(entrydone);
c.add(calctotal);
c.add(output);
 
output.setVisible(true);
output.setRows(26);
output.setColumns(30);

salesmandone.addActionListener(handler);
entrydone.addActionListener(handler);
calctotal.addActionListener(handler);
}
 
//Creates the JFrame and runs the method readFileData().
public static void main (String args[])
{
Sales sale = new Sales();
sale.setSize(350,600);
sale.setVisible(true);

readFileData();
}

//Reads data from an existing text file and cacualtes a salesmans total sales.
public static void readFileData()
{
String line;
ClassificationLevel level;

try
{
FileReader file = new FileReader("SalesData.txt");
BufferedReader buff = new BufferedReader(file);


while ((line = buff.readLine())!= null)
{
String[] elements = line.split("&");
String name = elements [0];
double sales = 0.0;
double sales1 = 0.0;
double sales2 = 0.0;
double sales3 = 0.0;
double sales4 = 0.0;
double sales5 = 0.0;

sales1 = Double.parseDouble(elements[1]) * 2.98;
sales2 = Double.parseDouble(elements[2]) * 4.50;
sales3 = Double.parseDouble(elements[3]) * 9.98;
sales4 = Double.parseDouble(elements[4]) * 4.49;
sales5 = Double.parseDouble(elements[5]) * 6.87;

level = ClassificationLevel.valueOf(elements[6]);
 
sales = (sales1 + sales2 + sales3 + sales4 + sales5);

sales = sales + (sales * level.getBonus());

if( sales == 0.00 )
{
throw new NoSalesException();
}

myList.add(new Salesman(name, sales));

}
buff.close();

 
}
catch(IOException ioe)
{
ioe.printStackTrace();
}
catch(NoSalesException nse)
{
for(Salesman salesm : myList)
{
JOptionPane.showMessageDialog(null, salesm.getName() + " has no Sales!!", "Sales Equals Zero",
JOptionPane.WARNING_MESSAGE);
}
}
}
 
//Implements three ActionListeners to three different buttons on the GUI.
public class Handler implements ActionListener
{
public void actionPerformed(ActionEvent e)
{
if(e.getSource() == salesmandone)
{
addSalesman();
}
else if(e.getSource() == entrydone)
{
writeFileData();
}
else if(e.getSource() == calctotal)
{
readObjectData();
}
}
}

//Sorts the names of salesman, if a name is already in the ArrayList then the name is not created again,
//instead the additional information is added to the one name.
public static Salesman getSalesman(String salesman)
{
for (Salesman salesm : myList)
{
        if (salesman.equals(salesm.getName()))
        {
             return salesm;
         }
     }
return null;
}

//Adds each Salesman name and sales to the ArrayList
public void addSalesman()
{
double sales = calculateSales(product.getSelectedIndex(), Integer.parseInt(amount.getText()));

if (getSalesman(salesmanname.getText()) != null)
{
getSalesman(salesmanname.getText()).addToSales(sales);
}
else
{
myList.add(new Salesman(salesmanname.getText(), sales));
}
 

salesmanname.setText("");
product.setSelectedIndex(0);
amount.setText("");
saleslevel.setSelectedIndex(0);
salesmanname.requestFocus();
}

//Calculates each salesman's sales and bonus and then returns that total to addSalesman() to be entered in the ArrayList.
public static double calculateSales(int product,int amount)
{
double sales1;
double sales = 0.0;

product++;

switch(product)
{
case 2:   sales1 = (amount * 2.98);
break;
 
case 3:   sales1 = (amount * 4.50);
break;

case 4:   sales1 = (amount * 9.98);
break;

case 5:   sales1 = (amount * 4.49);
break;

case 6:   sales1 = (amount * 6.87);
break;
 
default: sales1 = (0.00);
}

if( sales == 0.00 )
{
throw new NoSalesException();
}

if(saleslevel.getSelectedItem().equals("Entry"))
{
sales = sales1 + (sales1 * .05);
}
else if(saleslevel.getSelectedItem().equals("Junior"))
{
sales = sales1 + (sales1 * .10);
}
else if(saleslevel.getSelectedItem().equals("Senior"))
{
sales = sales1 + (sales1 * .15);
}

return sales;

}

//Writes the ArrayList data as objects to Salesman.data.
public static void writeFileData()
{
try
{
ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream("Salesman.data"));
     
try
{
for (Salesman s : myList)
{
oos.writeObject(s);
}
}
finally
{
oos.close();
}
}
catch(IOException ioe)
{
            ioe.printStackTrace();
        }
}
 
//Reads the data in Salesman.data as objects and puts that data into a vector which then sorts the Salesman in alphabetical
//order and then displays the data in the texatarea.
public static void readObjectData()
{
 
boolean eof = false;
Salesman salesman;
Vector<Salesman> salesmanList = new Vector<Salesman>();

try
{
ObjectInputStream ois = new ObjectInputStream(new FileInputStream("Salesman.data"));

try
{
while(true)
{
salesman = (Salesman) ois.readObject();

salesmanList.add(salesman);

Collections.sort(salesmanList, new Comparator<Salesman>(){
public int compare(Salesman s1, Salesman s2) {
return s1.getName().compareTo(s2.getName());}});

StringBuilder builder = new StringBuilder("\tTOTAL SALES\n\n");

double total = 0.00;

for (Salesman s : salesmanList)
{
builder.append(s.toString() +"\n");
total += s.getSales();
}
 
builder.append("\nTotal\t\t       " + currencyFormat.format(total));

output.setText(builder.toString());

}
}
finally
{
ois.close();
}
}
catch(EOFException eofe) 
{
    System.out.println("End of file");
}
catch (IOException ioe )
{
            ioe.printStackTrace();
        }  
catch (ClassNotFoundException cnfe)   
{      
cnfe.printStackTrace();   
}
}
}

[Michael Dunn]

just reading through the code, it seems you have the try/catch and while the
wrong way around

as written, if sales == 0.0, the exception will be thrown, breaking out of
the while(), which doesn't appear to be what you want

basically you have this

    
try
{
  while(blah blah)
  {
    salesman name = whatever
    sales = ??
    if(sales == 0.0) throw exception //will break out of 'while' here
  }
}
catch(exception)
{
  for_loop iterating salesman list printing out salesman name and "no sales" (all 5 salesmen?)
}

and you possibly want something like this

    
while(blah blah)
{
  salesman name = whatever
  try
  {
    sales = ??
    if(sales == 0.0) throw exception
  }
  catch(exception)
  {
    print out salesman name and "no sales"
  }
} //will continue until end of file

[Holly Leery]

Do you mean something like this:

public static void readFileData()
{
String line;
ClassificationLevel level;
double sales = 0.0;

try
{
FileReader file = new FileReader("SalesData.txt");
BufferedReader buff = new BufferedReader(file);

while ((line = buff.readLine())!= null)
{
String[] elements = line.split("&");
String name = elements [0];
double sales1 = 0.0;
double sales2 = 0.0;
double sales3 = 0.0;
double sales4 = 0.0;
double sales5 = 0.0;

sales1 = Double.parseDouble(elements[1]) * 2.98;
sales2 = Double.parseDouble(elements[2]) * 4.50;
sales3 = Double.parseDouble(elements[3]) * 9.98;
sales4 = Double.parseDouble(elements[4]) * 4.49;
sales5 = Double.parseDouble(elements[5]) * 6.87;

level = ClassificationLevel.valueOf(elements[6]);
 
try
{
sales = (sales1 + sales2 + sales3 + sales4 + sales5);

if( sales == 0.00 )
{
throw new NoSalesException();
}
}
catch(NoSalesException nse)
{
for(Salesman salesm : myList)
{
JOptionPane.showMessageDialog(null, salesm.getName() + " has no Sales!!", "Sales Equals Zero",
JOptionPane.WARNING_MESSAGE);
}
}

sales = sales + (sales * level.getBonus());

myList.add(new Salesman(name, sales));

}
 
buff.close();
 
}
catch(IOException ioe)
{
ioe.printStackTrace();
}
}

I still can't get it to run right. It just pops up on every name.

[Michael Dunn]

each time sales = 0, in your catch{} you display a messagebox showing
salesm.getName() + " has no Sales!!"
for every salesman in myList, regardless of whether the salesman has 0 sales or not.
Note: the current data of the while() has not been added to myList yet,
so it seems the salesman with 0 sales triggers a printout of all the other
salesmen, declaring their sales are 0.

is this what you really want?

are you trying to exclude a salesman with 0 sales from myList?

if so, it might be easier to do without the NoSalesException

    
if(sales == 0.00)
{
  JOptionPane.showMessageDialog(null, name + " has no Sales!!","Sales Equals Zero",JOptionPane.WARNING_MESSAGE);
}
else
{
  sales = sales + (sales * level.getBonus());
  myList.add(new Salesman(name, sales));
}

perhaps a bit more info on what the requirements are for a salesman with 0 sales
might get you a better/more detailed answer