JTextFields & storing data

[John Lockheart]

I want to store data (name, number), after the user clicks on a JButton "set". The premise of the program is that there are 6 circles drawn in a frame. Selecting a circle on mouse click, entering data and clicking the set button will store that information for that circle. Then when the circle is clicked again, the information will be displayed in the same JTextFields. And clicking a circle and clicking the "reset" button would clear that data. I'm not sure if I should use arrays, write a class that extends the one that creates the circles....I'm kind of lost on where I should start.

[Russell Peters]

The buttons "Set" and "Reset" -- are they on the circles or somewhere else on the panel?

Either way, you could define the JTextFields to be class members and do a field.setText() to set the value and field.getText() to display the value. Resetting can be done by setting the value to be an empty string.

[John Lockheart]

They are somewhere else on the panel. Well I have to be able to store the information up to 6 times for each player. Then recal the stored information when that player is clicked. Then clear the entires made if reset is clicked.

[Michael Dunn]

easier to post an example (rough), than try to explain it.

this uses a JList instead of your 6 circles, but the principle is the same
click on an item to display the stored data, 'set' to store the data from the
textfields, 'reset' to clear the data

    
import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;
class Testing
{
  DefaultListModel dlm = new DefaultListModel();
  JList list = new JList(dlm);
  JTextField[] tf = new JTextField[4];
  public void buildGUI()
  {
    dlm.addElement(new Player("Player1"));
    dlm.addElement(new Player("Player2"));
    dlm.addElement(new Player("Player3"));
    dlm.addElement(new Player("Player4"));
    dlm.addElement(new Player("Player5"));
    dlm.addElement(new Player("Player6"));
    JPanel p = new JPanel(new GridLayout(tf.length,1));
    for(int x = 0, y = tf.length; x < y; x++)
    {
      tf[x] = new JTextField(10);
      p.add(tf[x]);
    }
    JPanel p2 = new JPanel();
    p2.add(p);
    JPanel p1 = new JPanel();
    JButton setBtn = new JButton("Set");
    JButton resetBtn = new JButton("Reset");
    setBtn.setPreferredSize(resetBtn.getPreferredSize());
    p1.add(resetBtn);
    p1.add(setBtn);
    JFrame f = new JFrame();
    f.getContentPane().add(new JScrollPane(list),BorderLayout.CENTER);
    f.getContentPane().add(p2,BorderLayout.EAST);
    f.getContentPane().add(p1,BorderLayout.SOUTH);
    f.pack();
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setVisible(true);
    list.addListSelectionListener(new ListSelectionListener(){
      public void valueChanged(ListSelectionEvent lse){
        if(lse.getValueIsAdjusting() == false)
        {
          Player player = (Player)list.getSelectedValue();
          for(int x = 0, y = tf.length; x < y; x++) tf[x].setText(player.data[x]);
        }
      }
    });
    setBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        int index = list.getSelectedIndex();
        if(index > -1)
        {
          Player player = (Player)list.getSelectedValue();
          for(int x = 0, y = tf.length; x < y; x++) player.data[x] = tf[x].getText();
        }
        else errorMessage();
      }
    });
    resetBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        int index = list.getSelectedIndex();
        if(index > -1)
        {
          Player player = (Player)list.getSelectedValue();
          player.reset();
          for(int x = 0, y = tf.length; x < y; x++) tf[x].setText("");
        }
        else errorMessage();
      }
    });
  }
  public void errorMessage()
  {
    JOptionPane.showMessageDialog(null,"No player selected");
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}
class Player
{
  String player;
  String[] data = new String[5];
  public Player(String p)
  {
    player = p;
    reset();
  }
  public void reset()
  {
    for(int x = 0, y = data.length; x < y; x++) data[x] = "";
  }
  public String toString(){return player;}
}

[John Lockheart]

That was a very informative example, although i'm not 100% sure on how to incorporate it into my program. Here's what I have. Not sure whether the class should extend my Player class (which extends the Shape abstract class).

    
class HockecyLineupFrame{
 
//create two frames, and border layouts for panels, add buttons, labels and textfields...code omitted for space.
}
 
private class HockeyLineUpPanel extends JPanel {
public void paintComponent(Graphics g) {
   super.paintComponent(g);
   Graphics2D g2 = (Graphics2D)g;
 
         //Players
  p1 = new Player(size, colour1, filled, MidX, 75);
  p1.draw(g2);
 
  p2 = new Player(size, colour2, filled, MidX/2, MidY);
  p2.draw(g2);
 
  p3 = new Player(size, colour2, filled, MidX+(MidX/2), MidY);
  p3.draw(g2);
 
  p4 = new Player(size, colour3, filled, MidX/3, MidY+(MidY/2));
  p4.draw(g2);
 
  p5 = new Player(size, colour3, filled, MidX, MidY+(MidY/2)+30);
  p5.draw(g2);
 
 p6 = new Player(size, colour3, filled, MaxX-(MidX/3), MidY+(MidY/2));
 p6.draw(g2);
 
 //Selector, (rectangle drawn around player thats clicked)
 if(rect != null){
rect.draw(g2);
}
 
private class ENDMouseListener extends MouseAdapter {
    public void mouseClicked(MouseEvent e) {

int MidX = (int)(end_panel.getSize().getWidth() / 2),
    MidY = (int)(end_panel.getSize().getHeight() / 2),
    MaxX = (int)(end_panel.getSize().getWidth()),
    MaxY = (int)(end_panel.getSize().getHeight());
 
// Determine which object (if any) was clicked in
Shape s = null;
String position = " ";
 
if (p1 != null && p1.contains(e.getX(), e.getY())){
                s = p1;
                point_x = MidX; //for the rectangle
                point_y = 75; //for the rectangle
                position = "Goalie"; //label text
                index = 0; //thought it could represent the index value of the array that holds the player's information
}else if (p2 != null && p2.contains(e.getX(), e.getY())){
                s = p2;
                point_x = MidX/2;
                point_y = MidY;
                position = "Right Defender";
                index = 1;
}else if (p3 != null && p3.contains(e.getX(), e.getY())){
                s = p3;
                point_x = MidX+(MidX/2);
                point_y = MidY;
                position = "Left Defender";
                index = 2;
}else if (p4 != null && p4.contains(e.getX(), e.getY())){
                s = p4;
                point_x = MidX/3;
                point_y = MidY+(MidY/2);
            position = "Right Wing";
            index = 3;
}else if (p5 != null && p5.contains(e.getX(), e.getY())){
                s = p5;
                point_x = MidX;
                point_y = MidY+(MidY/2)+30;
            position = "Center";
            index = 4;
}else if (p6 != null && p6.contains(e.getX(), e.getY())){
s = p6;
point_x = MaxX-(MidX/3);
point_y = MidY+(MidY/2);
position = "Left Wing";
index = 5;
}
 
// Have we got anything?
if (s != null) {
 
   player_number_text.setEditable(true);
   player_name_text.setEditable(true);
   player = s;
   rect = new Selector(Shape.MEDIUM, Color.black, false, point_x, point_y);
   player_position_label2.setText(position);
 
       }else{

               player_number_text.setEditable(false);       player_name_text.setEditable(false);
       rect = null;
       player_position_label2.setText("Click a player!");
 
      }
repaint();
       }
 
}
 
private class SetOrResetListener implements ActionListener { //no code for setting player information, just conditions for the data entered (whether valid or not)
     public void actionPerformed(ActionEvent e) {

        Object source = e.getSource();
 
           if (source == set_button) {
 
           if(player_number_text.getText().length() > 2 || player_number_text.getText().length() == 0 || player_name_text.getText().length() == 0){
JOptionPane.showMessageDialog(null, "Invalid entry!");player_number_text.setText("");
player_name_text.setText("");
}
 
if(player_number_text.getText().length() > 0){
 
   try{
     int playerNumber = Integer.parseInt(player_number_text.getText());    player_number = player_number_text.getText();
 
   }catch(NumberFormatException nFE) {
JOptionPane.showMessageDialog(null, "Invalid input for number")player_number_text.setText("");
player_name_text.setText("");
 
}
}
     if(player_name_text.getText().length() > 0){
player_name = player_name_text.getText();
     }
 
    player_number_text.setEditable(false);
    player_number_text.setText("");
    player_name_text.setEditable(false);
    player_name_text.setText("");
    rect = null;
            
   }else if(source == reset_button) {
rect = null;
player_number_text.setEditable(false);
player_name_text.setEditable(false);
    }
 
 repaint();
}
}
 
abstract class Shape {
    public Shape(float new_size, Color new_color, boolean new_filled) {
        size = new_size;
        color = new_color;
        filled = new_filled;
    }
    public void draw(Graphics2D g2) {
        g2.setColor(color);
    }
    public boolean is_filled() {
        return filled;
    }
    public float get_size() {
        return size;
    }
    public abstract boolean contains(int x, int y);
 
    public String toString() {
        return "size=" + size + " color=" + color + " filled=" + filled;
    }
 
    private float size;
    private Color color;
    private boolean filled;
    public static final float SMALL = 0.5f;
    public static final float MEDIUM = 1.5f;
    public static final float LARGE = 2.0f;
    public static final float XLARGE = 4.0f;
    public static final float BASE_WIDTH = 50;
    public static final float BASE_HEIGHT = 45;
}
 
class Player extends Shape {
    public Player(float new_size, Color new_color, boolean new_filled, int mid_x, int mid_y) {
        super(new_size, new_color, new_filled);
        ellipse = new Ellipse2D.Float(mid_x - BASE_WIDTH * get_size() / 2.0f,
                                      mid_y - BASE_HEIGHT * get_size() / 2.0f,
                                      BASE_WIDTH * get_size(), BASE_HEIGHT * get_size());
    }
    public void draw(Graphics2D g2) {
        super.draw(g2);
        g2.draw(ellipse);
 
        if (is_filled() == true) {
            g2.fill(ellipse);
        }
    }
     public boolean contains(int x, int y) {
        // Find out if the x,y coordinates are in this shape
        return ellipse.contains(x, y);
    }
    public String toString() {
        return super.toString() + "; ellipse=" + ellipse.getX() + ", " + ellipse.getY() +
            ", " + ellipse.getWidth() + ", " + ellipse.getHeight();
    }
    private Ellipse2D.Float ellipse;
}

[Michael Dunn]

> i'm not 100% sure on how to incorporate it into my program

you have a panel with circles
I have a Jlist with items

click a circle selects the circle
click an item selects the item

click 'set' or 'reset' and the action works with the current selection.

the difference is how you identify the current selection, and which
listener best suits.

[John Lockheart]

sorry I should have been more clear, thats what I was curious about, how I identify the current selection. upon mouse event s = the current selection, whether it's p1, p2, etc.. It's already a shape object, so using that code from your example I will have a type shape which is incompatible with type Player. When i wasn't sure about how to incorporate it, thats because my Shape and Player superclass have alot of variables. I wasn't sure how to extend the Player class with a playerInfo class (in your example was called Player). I would have to make a super call and have many extra parameters. Then if I make it an independent class, the circle objects created are of type Shape, created using the Shape superclass and the Player class which extends it (in my program, Player class is diffrent).

 
Player player = (Player)list.getSelectedValue();//yours
Player player = (Player)s; //mine
//resulting error would be : Type found .Shape, Required .Player

[Michael Dunn]

here's the earlier code modified for JLabels - click a label to get/set/reset
the data. There is now a field 'currentPlayer' which is set when a label is
clicked.

you should be able to adapt this (the labels) to your shapes.

note: in paintComponent(), it is generally not a good idea to do this
p1 = new Player(size, colour1, filled, MidX, 75);
as paintComponent() is called numerous times

    
import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;
class Testing
{
  JTextField[] tf = new JTextField[4];
  Player currentPlayer;
  public void buildGUI()
  {
    JPanel labelPanel = new JPanel(new GridLayout(6,1));
    labelPanel.add(new Player("Player1"));
    labelPanel.add(new Player("Player2"));
    labelPanel.add(new Player("Player3"));
    labelPanel.add(new Player("Player4"));
    labelPanel.add(new Player("Player5"));
    labelPanel.add(new Player("Player6"));
    JPanel p = new JPanel(new GridLayout(tf.length,1));
    for(int x = 0, y = tf.length; x < y; x++)
    {
      tf[x] = new JTextField(10);
      p.add(tf[x]);
    }
    JPanel p2 = new JPanel();
    p2.add(p);
    JPanel p1 = new JPanel();
    JButton setBtn = new JButton("Set");
    JButton resetBtn = new JButton("Reset");
    setBtn.setPreferredSize(resetBtn.getPreferredSize());
    p1.add(resetBtn);
    p1.add(setBtn);
    JFrame f = new JFrame();
    f.getContentPane().add(labelPanel,BorderLayout.CENTER);
    f.getContentPane().add(p2,BorderLayout.EAST);
    f.getContentPane().add(p1,BorderLayout.SOUTH);
    f.pack();
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setVisible(true);
    setBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        if(currentPlayer != null)
        {
          for(int x = 0, y = tf.length; x < y; x++) currentPlayer.data[x] = tf[x].getText();
        }
      }
    });
    resetBtn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        if(currentPlayer != null)
        {
          currentPlayer.reset();
          for(int x = 0, y = tf.length; x < y; x++) tf[x].setText("");
        }
      }
    });
  }
  public void errorMessage()
  {
    JOptionPane.showMessageDialog(null,"No player selected");
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
  class Player extends JLabel
  {
    String[] data = new String[4];
    public Player(String p)
    {
      super(p);
      reset();
      addMouseListener(new MouseAdapter(){
        public void mousePressed(MouseEvent me){
          currentPlayer = Player.this;
          for(int x = 0, y = tf.length; x < y; x++) tf[x].setText(data[x]);
        }
      });
    }
    public void reset()
    {
      for(int x = 0, y = data.length; x < y; x++) data[x] = "";
    }
  }
}

[John Lockheart]

This is how I would have to code it. Since I saved this until the last step I have to make it fit within the program i've already created. I've tried alot of diffrent things, and attempting to assimilate your examples just gives me errors. Mostly cannot find symbol because i'm not sure how to code the PlayerInfo class (information of the player clicked) which should extend the Player class (player objects created), which extends the Shape class (which is used for circles or rectangles at the moment). So I have to make a super call inside PlayerInfo to Player (which has all the variables for creating a circle). Inside my mouse event, i set whichever player is clicked to a Shape variable called player. Then no matter what I try in set or reset, I can't make it work. Mostly because i'm having difficulty coding my PlayerInfo class.

private class HockeyLineUpPanel extends JPanel {
   public void paintComponent(Graphics g) {
        //create new player objects to be painted...p1-p6,
        //p1 = new Player((size, colour1, filled, MidX, 75);
//p1.draw(g2);
        //etc....
}
}
private class ENDMouseListener extends MouseAdapter {
    public void mouseClicked(MouseEvent e) {
 
    //set shape player to whichever player clicked.  Now shape s equals the current player selected
}
}
 

class Shape{
   public class Shape(float new_size, Color new_color, boolean new_filled){
 
  //all code for creating a shape
}
}
 
class Player extends Shape{
   public class Player(float new_size, Color new_color, boolean new_filled, int mid_x, int mid_y){
 
//all the code for creating a Player shape (circle)
}
}
 
class PlayerInfo extends Player{
   public class PlayerInfo(String p){
 
   //I would have to make a super call to all the variables of whichever player i'm using at the time.  Which would be annoying because I already have a player object created.  I can't write it the way you described in your examples.  And all the ways i've tried aren't working either
}
}

[Michael Dunn]

can you post a working demo program
just 2 circles, 1 textField, set and reset buttons.

then we can see (running) exactly what you have.

[John Lockheart]

import java.awt.Container;
import java.awt.Graphics;
import java.awt.Graphics2D;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.awt.event.MouseMotionAdapter;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import java.awt.Color;
import java.awt.geom.Rectangle2D;
import java.awt.geom.Ellipse2D;
import java.awt.geom.Line2D;
import java.awt.BorderLayout;
import java.awt.GridLayout;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JTextField;
import javax.swing.JTextArea;
import javax.swing.JLabel;
import javax.swing.SwingConstants;
import javax.swing.border.EtchedBorder;
import javax.swing.border.TitledBorder;
import javax.swing.ButtonGroup;
import javax.swing.JRadioButton;
import javax.swing.JComboBox;
import javax.swing.JCheckBox;
import javax.swing.JButton;
import javax.swing.JMenuBar;
import javax.swing.JMenu;
import javax.swing.JMenuItem;
import javax.swing.JOptionPane;
 
public class HockeyLineUp {
public static void main(String[] args) {
 
        HockeyLineUpFrame frame = new HockeyLineUpFrame(400, 600);
        frame.setTitle("Hockey Line Up");
        frame.show();
    }
}
 
class HockeyLineUpFrame extends JFrame {
 
    public HockeyLineUpFrame(int width, int height) {
 
        setSize(width, height);
        addWindowListener(new WindowCloser());
        Container content_pane = getContentPane();
 
        //Drawings
        end_panel = new HockeyLineUpPanel();
content_pane.add(end_panel, "Center");
ENDMouseListener end_mouse_listener = new ENDMouseListener();
end_panel.addMouseListener(end_mouse_listener);
 
        //User interface
        JPanel controls = new JPanel();
controls.setLayout(new BorderLayout());
        content_pane.add(controls, "South");
 
        //Player name
        JPanel name = new JPanel();
        controls2.add(name, "Center");
 
JPanel player_name_panel = new JPanel();
JLabel player_name_label = new JLabel("Player Name:",  SwingConstants.RIGHT);
player_name_text = new JTextField(15);
player_name_text.setEditable(false);
player_name_panel.add(player_name_label);
player_name_panel.add(player_name_text);
        name.add(player_name_panel);
 
       //Buttons
       JPanel setreset = new JPanel();
       controls.add(setreset, "South");
 
set_button = new JButton("Set");
reset_button = new JButton("Reset");
setreset.add(set_button);
setreset.add(reset_button);
SetOrResetListener sor_listener = new SetOrResetListener();
set_button.addActionListener(sor_listener);
        reset_button.addActionListener(sor_listener);
}
 
Shape player = null;
int index = -1;
Shape[] players = new Shape[2];
 
private HockeyLineUpPanel end_panel;
private JTextField player_name_text;
private JButton set_button;
private JButton reset_button;
}
 
private class WindowCloser extends WindowAdapter {
   public void windowClosing(WindowEvent e) {
      System.exit(0);
    }
}
 
private class HockeyLineUpPanel extends JPanel {
   public void paintComponent(Graphics g) {
    super.paintComponent(g);
        Graphics2D g2 = (Graphics2D)g;
 
                int MidX = (int)(end_panel.getSize().getWidth() / 2),
            MidY = (int)(end_panel.getSize().getHeight() / 2),
            MaxX = (int)(end_panel.getSize().getWidth()),
    MaxY = (int)(end_panel.getSize().getHeight());
                 
                players[0] = new Player(Shape.MEDIUM, Color.black, true, MidX, 75);
players[1] = new Player(Shape.MEDIUM, Color.black, true, MidX/2, MidY);
 
                for(int i = 0; i < players.length; i++){
players[i].draw(g2);
}
 
}
}
 
private class ENDMouseListener extends MouseAdapter {
    public void mouseClicked(MouseEvent e) {
 
        if (players[0] != null && players[0].contains(e.getX(), e.getY())){
     player = players[0];
     index = 0;
}else if(players[0] != null && players[0].contains(e.getX(), e.getY())){
            player = players[1];
            index = 1;
}
}
 
private class SetOrResetListener implements ActionListener { 
    public void actionPerformed(ActionEvent e) {
 
    Object source = e.getSource();
 
    if (source == set_button) {
if(player != null && index>-1){
   for(int x = 0; x<player_name_text.getText().length(); x++){
players[index].nameData[x] = player_name_text.getText();
   }
        }
    }else if(source == reset_button){
        if(player != null && index>-1){
   players[index].reset();

           for(int x = 0; x<player_name_text.getText().length(); x++){
players[index].nameData[x] = player_name_text.setText("");
   }
 
    }
}
}
 
abstract class Shape {
    public Shape(float new_size, Color new_color, boolean new_filled) {
        size = new_size;
        color = new_color;
        filled = new_filled;
    }
 
    public void draw(Graphics2D g2) {
        g2.setColor(color);
    }
 
    public boolean is_filled() {
        return filled;
    }
 
    public float get_size() {
        return size;
    }
 
    public abstract boolean contains(int x, int y);
   
    public String toString() {
        return "size=" + size + " color=" + color + " filled=" + filled;
    }
 
    private float size;
    private Color color;
    private boolean filled;
 
    public static final float SMALL = 0.5f;
    public static final float MEDIUM = 1.5f;
    public static final float LARGE = 2.0f;
    public static final float XLARGE = 4.0f;
 
    public static final float BASE_WIDTH = 50;
    public static final float BASE_HEIGHT = 45;
}
 
class Player extends Shape {
    public Player(float new_size, Color new_color, boolean new_filled, int mid_x, int mid_y) {
        super(new_size, new_color, new_filled);
        ellipse = new Ellipse2D.Float(mid_x - BASE_WIDTH * get_size() / 2.0f, mid_y - BASE_HEIGHT * get_size() / 2.0f, BASE_WIDTH * get_size(), BASE_HEIGHT * get_size());
    
}
    public void draw(Graphics2D g2) {
        super.draw(g2);
        g2.draw(ellipse);
 
        if (is_filled() == true) {
            g2.fill(ellipse);
        }
 
    }
     
      public boolean contains(int x, int y) {
        // Find out if the x,y coordinates are in this shape
        return ellipse.contains(x, y);
      }
 
    public String toString() {
        return super.toString() + "; ellipse=" + ellipse.getX() + ", " + ellipse.getY() + ", " + ellipse.getWidth() + ", " + ellipse.getHeight();
    }
    
   private Ellipse2D.Float ellipse;
}
 
class PlayerInfo extends Player{
public PlayerInfo(float new_size, Color new_color, boolean new_filled, int mid_x, int mid_y, String new_name){
 
super(new_size, new_color, new_filled, mid_x, mid_y);
name = new_name;
reset();
}
 
public void setName(String new_name){
 
this.name = new_name;
 
for(int x = 0; x < nameData.length; x++){
 
nameData[x] = name;
}
}
 
public String getName(){
return name;
}

         public void reset(){
 
for(int x = 0; x<nameData.length; x++){
nameData[x] = "";
}
}
 
public String toString(){
return "Name : " + name; //could be player_name.setText(name)
}

       String[] nameData = new String[6]; //hold 6 names
 
}
}

[John Lockheart]

The demo doesn't even work, my program was to big, when I tried chopping it up there were way to many errors to debug. I can send you the full program if you want via email. The demo can at least give you an idea of what i'm trying to do. Instead I now create an array containting player objects. I made it so I have a PlayerInfo class that extends player and makes a super call to all the variables. In the setOrReset listener the main problem is I cannot reference nameData, because i'm looking inside Shape.

[Michael Dunn]

email me the files (address in my profile)

include 'java' in the subject, so I can ID it - address gets a lot of spam

[John Lockheart]

Alright, i'm not even going to bother anymore. I took the easy way out and just created an array inside my main program called names. This array stores all the names when "set" is clicked, and then when you click on a player the index value adjusts to that player. Using the index value if playerClicked != null i use setText(names[index]). I'm going to finsh up the program then try and re-write code to make it look more presentable. Thanks for all your help.