• Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other Pie Elite all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Jeanne Boyarsky
  • Ron McLeod
  • Paul Clapham
  • Liutauras Vilda
Sheriffs:
  • paul wheaton
  • Rob Spoor
  • Devaka Cooray
Saloon Keepers:
  • Stephan van Hulst
  • Tim Holloway
  • Carey Brown
  • Frits Walraven
  • Tim Moores
Bartenders:
  • Mikalai Zaikin

What do you think of my filter ?

 
clojure forum advocate
Posts: 3479
Mac Objective C Clojure
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Hi.
I'm creating a small web forum, this forum uses cookies to store username and password.
This app contains a servlet filter, this filter is responsible to try to collect the cookies and create a session scope object contains the informations (this filter is applied to all pages in the app).
Some code:

getUserFromCookies(request, session); is a method iterates over the cookies in user's cache and try to create a session scope object.
What do you think of my design ? is it good (implementation, performance, a hole ....)
Thanks guys.
 
author & internet detective
Posts: 41855
904
Eclipse IDE VI Editor Java
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
John,
The logic/design are sound. My only question is why you are passing both request and session to the getUserFromCookies method. As you can get either from the other, this is a redundant parameter.

I would also move the chain doFilter() call outside the if statement since it is done either way. The intent is a bit clearer that way.

 
With a little knowledge, a cast iron skillet is non-stick and lasts a lifetime.
reply
    Bookmark Topic Watch Topic
  • New Topic