log4j...

[S�bastien Bervoets]

Hi all,

I'm new and I've already a problem with log4j.

Here my implementation of log4j :

[h1]be.arista.Oscar.servlet.OscarServletContextListener[/h1]

package be.arista.Oscar.servlet;
 
import org.apache.log4j.Logger;
import org.apache.log4j.PropertyConfigurator;
import javax.servlet.ServletContext;
import javax.servlet.ServletContextEvent;
import javax.servlet.ServletContextListener;
 
public class OscarServletContextListener implements ServletContextListener {
 
private ServletContext ctx = null;

public void contextInitialized(ServletContextEvent event) {

ctx = event.getServletContext();
String props = ctx.getInitParameter("log4j-init-file");

PropertyConfigurator.configure(ctx.getRealPath(props));
Logger logger = Logger.getLogger(this.getClass());

logger.info("Application initialised");
}
 
public void contextDestroyed(ServletContextEvent event) {
Logger logger = Logger.getLogger(this.getClass());
logger.info("Applicaiton Shutting Down");
}
 
}
 

[h1]web.xml[/h1]

<?xml version="1.0" encoding="UTF-8"?>
<web-app xmlns="http://java.sun.com/xml/ns/j2ee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="2.4"
xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee   [url=http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd">]http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd">[/url]
  <servlet>
    <servlet-name>action</servlet-name>
    <servlet-class>org.apache.struts.action.ActionServlet</servlet-class>
    <init-param>
      <param-name>config</param-name>
      <param-value>/WEB-INF/struts-config.xml</param-value>
    </init-param>
    <init-param>
      <param-name>debug</param-name>
      <param-value>3</param-value>
    </init-param>
    <init-param>
      <param-name>detail</param-name>
      <param-value>3</param-value>
    </init-param>
    <load-on-startup>1</load-on-startup>
  </servlet>
 
<listener>
<listener-class>be.arista.Oscar.servlet.OscarServletContextListener</listener-class>
</listener>
  
  <context-param>
  <param-name>log4j-init-file</param-name>
  <param-value>../../conf/log4jOscar.properties</param-value>
</context-param>

  <servlet-mapping>
    <servlet-name>action</servlet-name>
    <url-pattern>*.do</url-pattern>
  </servlet-mapping>
  
  <welcome-file-list>
  <welcome-file>/jsp/index.jsp</welcome-file>
  </welcome-file-list>
  
  <taglib>
    <taglib-uri>http://jakarta.apache.org/taglibs/log-1.0</taglib-uri>
    <taglib-location>/WEB-INF/taglibs-log.tld</taglib-location>
  </taglib>
  
</web-app>
 
 

[h1]log4jOscar.properties[/h1]

# Sample properties to initialise log4j
log4j.rootLogger=fatal, stdout
log4j.rootLogger.be.arista.Oscar=debug, stdout, Oscar
 
log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
 
# Pattern to output the caller's file name and line number.
log4j.appender.stdout.layout.ConversionPattern=%d{dd.MM.yyyy HH:mm:ss} %-5p [%c{1}] %m%n
 
log4j.appender.Oscar=org.apache.log4j.RollingFileAppender
log4j.appender.Oscar.File=c:\\temp\\oscar.log
 
log4j.appender.Oscar.MaxFileSize=100KB
# Keep one backup file
log4j.appender.Oscar.MaxBackupIndex=2
 
log4j.appender.Oscar.layout=org.apache.log4j.PatternLayout
log4j.appender.Oscar.layout.ConversionPattern=%d{dd.MM.yyyy HH:mm:ss} %-5p [%c{1}] %m%n
 
 

My problem is that nothing appens. What's wrong ?

Thank you so much

[Edit to break long line]
[ October 15, 2005: Message edited by: David O'Meara ]

[David O'Meara]

     <context-param>
  <param-name>log4j-init-file</param-name>
  <param-value>../../conf/log4jOscar.properties</param-value>
</context-param>

This is not pointing where you think it is. Try a solution that provides the filename only and use the application context or ClassLoader to find the file.

[S�bastien Bervoets]

I've tried to put the path directly like this :

PropertyConfigurator.configure("c:\\temp\\log4jOscar.properties");

but nothing better

[Ben Souther]

I put log4j.properties in my classes directory (to get it on the classpath) and log4j finds it without a problem.

[S�bastien Bervoets]

Yes I know I've this solution and that works fine! But my need is to have 3 or more properties files for my different environments (dev, prod, test, ...)

The solution I've found is to install my log4j files into the conf directory into tomcat 5

So I'd like to configure my webapp with log4j with a property file independent of the deployment

Do you have an idea ?

[David O'Meara]

Try a solution that provides the filename only and use the application context or ClassLoader to find the file.

1) Use the web.xml init setting to define the different files via conguration (use the file name, no '..', no slashes)
2) Place the file in the WEB-INF directory (so it is off the web-app classpath)
3) Check the ServletContext API and use getResource to find a URL to the file (use the value directly from the init parameters)
4) Pass this to the PropertyConfigurator as a URL

This may not be exactly right, but it should work overall and it should work for your requirements. The other way is to allow the file to be loaded from the web app classpath and just place other values earlier on the classpath, then they will be picked up earlier.

[S�bastien Bervoets]

I finally found a solution :

InitServlet.class

...
public void init() throws ServletException {
 
String log4jfile = getInitParameter("log4j-init-file");
if (log4jfile != null) {
String propfile = getServletContext().getRealPath(log4jfile);
PropertyConfigurator.configure(propfile);
}
    Logger log = Logger.getLogger(this.getClass());
    log.info("Application initialized!!!");
}
...

web.xml

...<servlet>
  <servlet-name>InitServlet</servlet-name>
  <servlet-class>be.arista.Oscar.servlet.InitServlet</servlet-class>
  <init-param>
  <param-name>log4j-init-file</param-name>
<param-value>../../conf/log4jOscar.properties</param-value>
</init-param>
<load-on-startup>1</load-on-startup>
</servlet>
...

log4j.properties

log4j.logger.be.arista.Oscar=DEBUG, Oscar
 
log4j.appender.Oscar=org.apache.log4j.DailyRollingFileAppender
log4j.appender.Oscar.File=${catalina.home}/logs/Oscar/oscar.log
log4j.appender.Oscar.DatePattern='.'yyyy-MM-dd
log4j.appender.Oscar.Append=true
log4j.appender.Oscar.Threshold=debug
log4j.appender.Oscar.layout=org.apache.log4j.PatternLayout
log4j.appender.Oscar.layout.ConversionPattern=%d{dd.MM.yyyy HH:mm:ss} %-5p [%c{1}] %m%n

Now I try to use a xml format for the log4j config file.

And then the code should be (I think) :

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE log4j:configuration SYSTEM "log4j.dtd">
<log4j:configuration xmlns:log4j="http://jakarta.apache.org/log4j/" threshold="debug" debug="true">
<appender name="OSCAR" class="org.apache.log4j.DailyRollingFileAppender">
<param name="File" value="${catalina.home}/logs/Oscar/oscar.log"/>
<param name="Append" value="true"/>
<param name="DatePattern" value="'.'yyyy-MM-dd"/>
<param name="Threshold" value="DEBUG"/>
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%d{dd.MM.yyyy HH:mm:ss} %-5p [%c{1}] %m%n"/>
</layout>       
</appender>
<logger name="be.arista.Oscar">
<appender-ref ref="STDOUT"/>
</logger>
</log4j:configuration>

Unfortunatly this code doesn't work. I'm working with Tomcat 5.0.28 (configured with a xml file for log4j logging), log4j-1.2.12, JDK 1.4.2_09

Somebody have an idea ?

PS : Thank to David and Ben for their help

[Neeraj Dheer]

For using xml property files in log4j, instead of calling
PropertyConfigurator.configurer(), call DOMConfigurator.configurer()