Saving a Inputstream to file

[Alex Philippi]

Hi,
I am saving a inputstream to a temp File (for accessing the stream more than once). But I think thats a kind of "ugly" code. Is there a better way to implement this?

Here the code:

public class TempXmlFile {
 
    private File tempFile;
 
    
    public TempXmlFile(InputStream in) throws IOException {
        this.init(in);
    }
 
    private void init(InputStream in) throws IOException {
 
        tempFile = File.createTempFile("tempFile", ".tmp");
        tempFile.deleteOnExit();
 
        FileOutputStream fout = null;
 
        try {
 
            fout = new FileOutputStream(tempFile);
            int c;
 
            while ((c = in.read()) != -1) {
                fout.write(c);
            }
 
        }finally {
            if (in != null) {
                in.close();
            }
            if (fout != null) {
                fout.close();
            }
        }
    }
 
    public File getTempFile() {
        return tempFile;
    }
}

Best Regards
Alex

[Rob Spoor]

You can gain some performance speed by using buffers for copying. So instead of

int c;
 
while ((c = in.read()) != -1) {
    fout.write(c);
}

use

byte[] buf = new byte[1024];
int len;
while ((len = in.read(buf)) != -1) {
    fout.write(buf, 0, len);
}

Varying the buffer size can improve speed even more.
Also try wrapping the reader in a BufferedReader and read from that.

Perform multiple tests to see which one is best for you.