Help with overriding methods

[Eric Johns]

I need some help with overridding methods. I have car class and then some children class of the car class.. here is my car class

public class Car 
{
//Attributes

private String make;
private String model;
private String type;
protected double suggestedRetailPrice;
private double safetyRating;
private int milesPerGallon;
    private double totalFitWeight;
    
 // Weights
 
 private final double SUGGEST_PRICE=0.40;
private final double SAFETY_RATEING=0.45;
 private final double MILES_GALLON=0.15;   
      

//constructors

public Car( String inputMake,String inputModel,String inputType,double inputPrice,double inputSafetyRating, int inputMpg)
{
make=inputMake;
model=inputModel;
type=inputType;
suggestedRetailPrice=inputPrice;
safetyRating=inputSafetyRating;
milesPerGallon=inputMpg;

}//end Car constructor
  
//Getter methods

public String getCarMake()
{
return make;

}

public String getCarModel()
{
return model;
}

public String getCarType()
{
return type;
}

public double getCarSuggestedRetailPrice()
{
return suggestedRetailPrice;

}

public double getCarSafetyRating()
{
return safetyRating;
}

public int getCarMilesPerGallon()
{
return milesPerGallon;
}

//setter methods

 public void setCarMake(String inputMake)
 {
 make=inputMake;
 }
 
 public void setCarModel(String inputModel)
 {
 model=inputModel;
 }
 
 public void setCarType(String inputType)
 {
 type=inputType;
 }
 
 public void setCarSuggestedRetailPrice(double inputPrice)
 {
 suggestedRetailPrice=inputPrice;
 }
 
 public void setCarSafetyRating(double inputSafetyRating)
 {
 safetyRating=inputSafetyRating;
 }
 
 public void setMilesPerGallon(int inputMilesPerGallon )
 {
 milesPerGallon=inputMilesPerGallon;
 
 }
 
 
 //Methods
 
  
 public double findSuggestedRetailPriceFit(double userPrice)
 {
 double priceFit;
 
 if ((userPrice<=1.1 * suggestedRetailPrice) && (userPrice >=0.9 * suggestedRetailPrice))
   
   {
   priceFit=100*SUGGEST_PRICE;
   
   }
   
  else if ((userPrice<=1.2* suggestedRetailPrice) && (userPrice >= 1 * suggestedRetailPrice))
  
 { 
    priceFit=50*SUGGEST_PRICE;
 
 } 
  else priceFit=0;
  
  return priceFit;
 
 }
 
 public double findSafetyRatingFit(double userSafety)
 {
 double safetyFit;
 
 if (userSafety<= 1.1 * safetyRating) 
  {
      safetyFit=100*SAFETY_RATEING;
 
  }

 else if (userSafety<= 1.2 * safetyRating)
{ 
     safetyFit=50*SAFETY_RATEING;
} 

else safetyFit=0;

 return safetyFit;
 }
 
 public double findMilesPerGallonFit(int userMpg)
 {
 double mpgFit;
 
 if (userMpg<= 1.1 * milesPerGallon) 

{
mpgFit=100*MILES_GALLON;

}


   else if(userMpg<= 1.2 * milesPerGallon)
   
   {
   mpgFit=50*MILES_GALLON;
   }

else mpgFit=0;

return mpgFit;
 }
 
 
 public double findTotalFit(double inputPrice, double inputSafety, int inputMpg)
 { 
  this.totalFitWeight=totalFitWeight;
  double priceFit;
  double safetyFit;
  double mpgFit;
  
  priceFit=findSuggestedRetailPriceFit(inputPrice);
  safetyFit=findSafetyRatingFit(inputSafety);
  mpgFit=findMilesPerGallonFit(inputMpg);
  
  totalFitWeight=(priceFit + safetyFit + mpgFit);
   
  return totalFitWeight;
 }
 
 
 public void printCarDetails()
 {  
   System.out.println();
System.out.println("Make: "+ make);
System.out.println("Model: "+ model);
System.out.println("Type: "+ type);    
       System.out.println("Safety Rating: "+ safetyRating);
       System.out.println("Miles Per Gallon: "+ milesPerGallon);
        System.out.println("Fit: "+ totalFitWeight);
        System.out.println("Retail Price: "+ suggestedRetailPrice);
        System.out.println();
 }
class PassengerCar extends Car
{
private double manufacturerDiscount;
private double dealerDiscount;

//Constructor
public PassengerCar(String inputMake,String inputModel,String inputType, double inputPrice, double inputSafetyRating, int inputMpg)
{
super(inputMake,inputModel,inputType,inputPrice,inputSafetyRating,inputMpg);
}

//Overridden Methods

public double getCarSuggestedRetailPrice()
{
suggestedRetailPrice=suggestedRetailPrice-((suggestedRetailPrice*manufacturerDiscount)+(suggestedRetailPrice*dealerDiscount));

return suggestedRetailPrice;
}

public void printCarDetails()
{
System.out.println("Passenger Car Details:");
super.printCarDetails();
}
  

Now what I am trying to due is in the client class I'm trying to overide the car class's getCarsuggestedRetailPrice with this new getCarSuggestedRetatilPrice in PassengerCar Class, but no matter how I do or I should say where I put the code,I am always getting the same suggested Retail price value no change which leads me to think that it's not overriding the Car class's methods or somethings not right, would anybody have any suggestions? thanks.

[chi Lin]

In the PassengerCar class there are two variables
manufacturerDiscount, dealerDiscount
Do you initialize them to a proper value ? As those two are invloved with calculation of suggestedRetailPriceor and the deafult is 0.0

[Eric Johns]

my problem was I forgot to bring the values in for those var. thanks alot don't know how I missed that one.. thanks Eric