Valadation problem!!!!!!

[joe kane]

Hi,
Im writing this program, it displays a inputbox asking for a grade(e.g. number), I have it valadated so there can be no letters etc....
I am trying to valadate it so the value entered by the user has to be between 1 & 100, It works and displays a message to the user, but if I enter a number between 1 & 100 I get the same message.....Heres the code, any help much appricated..

import javax.swing.JOptionPane;
public class Main_1 {
  
public static void main(String[] args) {
    
        start();
        
}
    
public static void start(){
   
String choice;
String choice1, choice2, choice3;
int one;
int two;
int three;
double num1;
double num2;
double num3;
int tot1, tot2, tot3;
int totals;

choice1 = JOptionPane.showInputDialog("Enter Grade 1");
 
while (choice1 == null){ System.exit(0); }
while ( !choice1.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice1 = JOptionPane.showInputDialog("Enter Grade 1");
}
int num = Integer.parseInt(choice1);
while (( num < 0 ) || ( num > 100)){
    JOptionPane.showMessageDialog(null,"Number must be between 1 & 100");
    choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    while ( !choice1.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    }}

choice2 = JOptionPane.showInputDialog("Enter Grade 2");
while (choice2 == null){ System.exit(0); }
while ( !choice2.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice2 = JOptionPane.showInputDialog("Enter Grade 2");
}
int numz = Integer.parseInt(choice1);
while (( numz < 0 ) || ( numz > 100)){
    JOptionPane.showMessageDialog(null,"Number must be between 1 & 100");
    choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    while ( !choice1.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    }}
choice3 = JOptionPane.showInputDialog("Enter Grade 3");
while (choice3 == null){ System.exit(0); }
while ( !choice3.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice3 = JOptionPane.showInputDialog("Enter Grade 3");
}
int numx = Integer.parseInt(choice1);
while (( numx < 0 ) || ( numx > 100)){
    JOptionPane.showMessageDialog(null,"Number must be between 1 & 100");
    choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    while ( !choice1.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    }}

num1 = Double.parseDouble (choice1);
        
num2 = Double.parseDouble (choice2);
        
num3 = Double.parseDouble (choice3);
double result1 = methodone(num1);
double result2 = methodtwo(num2);
double result3 = methodthree(num3);
double finish = methodtotals(result1,result2,result3);

}
//------------------------------------------------------------------------------
public static double methodtotals(double x, double y, double z){
    String result1 = "" ;
    String x1 = "Pass";
    String x2 = "Merit";
    String x3 = "Fail";
    
    int result = ((int)(x + y + z));
    
    if (result > 49){
        
        result1 = x1;
    }    
    if (result > 79){
        
        result1 = x2;
    }
    if (result < 49){
        
       result1 = x3;
    }
    
    int score = ((int)(x + y + z));
    
    JOptionPane.showMessageDialog(null,
        "Results  "+x+"/30  "+y+"/40  "+z+"/30  "
        +"\nTotal Result: "+score+"%/100\n Grade: "+ result1+"");
  start();
    return(x);
}
//------------------------------------------------------------------------------
public static double methodone(double x){
    
return (x * 0.3);
    
}
//------------------------------------------------------------------------------
//------------------------------------------------------------------------------
public static double methodtwo(double x){
    
return (x * 0.4);
    
}
//------------------------------------------------------------------------------

//------------------------------------------------------------------------------
public static double methodthree(double x){
    
return (x * 0.3);
    
}}
//---------------------------------------------------  

Thanks loads in advance.....
Thanks joe
[ February 01, 2004: Message edited by: Jim Yingst ]

[Elouise Kivineva]

This is so long I haven't been able to see the error yet, but start here:
The input checking is the same for the strings received from all three input dialogs, so use the same method for checking.
What the check method should do:
If it's not an int then Inger.parseInt will throw an exception. Use try/catch to find this error.
If you get past try/catch you know you have an int, you just need to make sure it's within the desired range. Maybe you should test for numbers that are too low separately from numbers that are too high, at least until you get things working right.
If the program still gives you the same error message when it shouldn't, try printing the number to an output dialog so you can see what it looks like and whether it's getting changed or garbled somewhere along the line.

[Jim Yingst]

Elouise's advice above is all excellent. Here's some more.
Indent your code carefully. When the indentation jumps around at random it becomes painful to read and therefore harder to understand. E.g.

while (( num < 0 ) || ( num > 100)){
    JOptionPane.showMessageDialog(null,"Number must be between 1 & 100");
    choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    while ( !choice1.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice1 = JOptionPane.showInputDialog("Enter Grade 1");
    
    }}

should be

        while ((num < 0) || (num > 100)) {
            JOptionPane.showMessageDialog(null, "Number must be between 1 & 100");
            choice1 = JOptionPane.showInputDialog("Enter Grade 1");
            while (!choice1.matches("[0-9]+")) {
                JOptionPane.showMessageDialog(null, "Error, Numbers only");
                choice1 = JOptionPane.showInputDialog("Enter Grade 1");
            }
        }

Your start() method is far too long to understand easily. Try breaking it up into smaller methods. As you did with the last bits, methodone() -two() -three() and methodtotals(). Your start method could be something simple like

public static void start() {
    double grade1 = requestTestScore("Grade 1");
    double grade2 = requestTestScore("Grade 2");
    double grade3 = requestTestScore("Grade 3");
    showTotals(grade1, grade2, grade3);
}

Most of the work will be in requestTestScore() of course. Which can also be broken into smaller methods. E.g. you may find it helpful to create a method

/** True if input is a number in range 0-100 */
private static boolean isValidTestScore(String input) {
    ...
}

or alternately

/** Returns test score in range 0-100, or -1 if input is invalid */
private static double parseAsTestScore(String input) {
    ...
}

or something similar. There are many possible ways to do this.
Last, when you write the requestTestScore() method, you may want to consider a do/while loop. It's less common than other loop structures, but it matches what you want to do here - first do something (ask for input), then test a condition to see if you should repeat the first action. You can still do this without do while, but it's something to consider.
[ February 01, 2004: Message edited by: Jim Yingst ]

[Loveen Jain]

I read ur message they are right, the problem is all the inputs are being taken as the Strings and thats why u are recieving the same error.
Try to use Integer.parseInt() to take the values and it will run fine

happy programin